From 1ad4dd92882b5e299b02d981386c6ec9d60ee5cb Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Fri, 6 Oct 2023 11:16:37 +1300 Subject: [PATCH] s4:dns_server: Check return value of ldb_transaction_commit() (CID 1034631) Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- source4/dns_server/dns_update.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/source4/dns_server/dns_update.c b/source4/dns_server/dns_update.c index 13f16f244f8..4d2ee0bac71 100644 --- a/source4/dns_server/dns_update.c +++ b/source4/dns_server/dns_update.c @@ -753,7 +753,10 @@ static WERROR handle_updates(struct dns_server *dns, failed: if (W_ERROR_IS_OK(werror)) { - ldb_transaction_commit(dns->samdb); + ret = ldb_transaction_commit(dns->samdb); + if (ret != LDB_SUCCESS) { + werror = DNS_ERR(SERVER_FAILURE); + } } else { ldb_transaction_cancel(dns->samdb); } -- 2.47.3