From 1f66bd238f9897c4e1911627af038bc4a3924eac Mon Sep 17 00:00:00 2001 From: James Coglan Date: Mon, 10 Jun 2024 16:21:40 +0100 Subject: [PATCH] resolved: tests for dns_packet_append_answer(); SRV records --- src/resolve/test-dns-packet-append.c | 53 ++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) diff --git a/src/resolve/test-dns-packet-append.c b/src/resolve/test-dns-packet-append.c index 6eb2357074c..e55ce35273d 100644 --- a/src/resolve/test-dns-packet-append.c +++ b/src/resolve/test-dns-packet-append.c @@ -716,4 +716,57 @@ TEST(packet_append_answer_single_mx) { ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); } +TEST(packet_append_answer_single_srv) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL; + DnsResourceRecord *rr = NULL; + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_SRV, "_ldap._tcp.example.com"); + ASSERT_NOT_NULL(rr); + rr->ttl = 3601; + rr->srv.priority = 17185; + rr->srv.weight = 25976; + rr->srv.port = 389; + rr->srv.name = strdup("cloud.example.com"); + + answer = dns_answer_new(1); + ASSERT_NOT_NULL(answer); + dns_answer_add(answer, rr, 1, 0, NULL); + dns_resource_record_unref(rr); + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + + DNS_PACKET_ID(packet) = htobe16(42); + DNS_PACKET_HEADER(packet)->flags = htobe16(DNS_PACKET_MAKE_FLAGS(1, 0, 1, 0, 1, 1, 0, 0, DNS_RCODE_SUCCESS)); + DNS_PACKET_HEADER(packet)->ancount = htobe16(dns_answer_size(answer)); + + ASSERT_OK(dns_packet_append_answer(packet, answer, NULL)); + + const uint8_t data[] = { + 0x00, 0x2a, BIT_QR | BIT_AA | BIT_RD, BIT_RA | DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, + + /* name */ 0x05, '_', 'l', 'd', 'a', 'p', + 0x04, '_', 't', 'c', 'p', + 0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e', + 0x03, 'c', 'o', 'm', + 0x00, + /* SRV */ 0x00, 0x21, + /* IN */ 0x00, 0x01, + /* ttl */ 0x00, 0x00, 0x0e, 0x11, + /* rdata */ 0x00, 0x19, + /* priority */ 0x43, 0x21, + /* weight */ 0x65, 0x78, + /* port */ 0x01, 0x85, + /* name */ 0x05, 'c', 'l', 'o', 'u', 'd', + 0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e', + 0x03, 'c', 'o', 'm', + 0x00 + }; + + ASSERT_EQ(packet->size, sizeof(data)); + ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); +} + DEFINE_TEST_MAIN(LOG_DEBUG) -- 2.47.3