From 200a5b7617d6f12a3907702bf0473f7ddda1c53b Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 26 Oct 2023 14:26:26 +0200 Subject: [PATCH] lib:util: Add boolean return type for memcache_add() Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett --- lib/util/memcache.c | 12 +++++++----- lib/util/memcache.h | 2 +- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/util/memcache.c b/lib/util/memcache.c index 7b0b27eaddb..d2016cd8193 100644 --- a/lib/util/memcache.c +++ b/lib/util/memcache.c @@ -265,7 +265,7 @@ void memcache_delete(struct memcache *cache, enum memcache_number n, memcache_delete_element(cache, e); } -void memcache_add(struct memcache *cache, enum memcache_number n, +bool memcache_add(struct memcache *cache, enum memcache_number n, DATA_BLOB key, DATA_BLOB value) { struct memcache_element *e; @@ -278,11 +278,11 @@ void memcache_add(struct memcache *cache, enum memcache_number n, cache = global_cache; } if (cache == NULL) { - return; + return false; } if (key.length == 0) { - return; + return false; } e = memcache_find(cache, n, key); @@ -312,7 +312,7 @@ void memcache_add(struct memcache *cache, enum memcache_number n, memcpy(&mtv, cache_value.data, sizeof(mtv)); cache->size += mtv.len; } - return; + return true; } memcache_delete_element(cache, e); @@ -323,7 +323,7 @@ void memcache_add(struct memcache *cache, enum memcache_number n, e = talloc_size(cache, element_size); if (e == NULL) { DEBUG(0, ("talloc failed\n")); - return; + return false; } talloc_set_type(e, struct memcache_element); @@ -363,6 +363,8 @@ void memcache_add(struct memcache *cache, enum memcache_number n, cache->size += mtv.len; } memcache_trim(cache, e); + + return true; } void memcache_add_talloc(struct memcache *cache, enum memcache_number n, diff --git a/lib/util/memcache.h b/lib/util/memcache.h index 803af813025..d1ab6c28323 100644 --- a/lib/util/memcache.h +++ b/lib/util/memcache.h @@ -68,7 +68,7 @@ void memcache_set_global(struct memcache *cache); * Add a data blob to the cache */ -void memcache_add(struct memcache *cache, enum memcache_number n, +bool memcache_add(struct memcache *cache, enum memcache_number n, DATA_BLOB key, DATA_BLOB value); /* -- 2.47.3