From 227351345d0caa596eff8325144f15b15f704c08 Mon Sep 17 00:00:00 2001 From: Jonathan Wakely Date: Thu, 12 Jan 2023 13:03:01 +0000 Subject: [PATCH] libstdc++: Do not include in concurrency headers The , , and headers use std::errc constants, but don't use std::system_error itself. They only use the __throw_system_error(int) function, which is defined in . By including the header for the errc constants instead of the whole of we avoid depending on the whole std::string definition. libstdc++-v3/ChangeLog: * include/bits/std_mutex.h: Remove include. * include/std/condition_variable: Add include. * include/std/mutex: Likewise. * include/std/shared_mutex: Likewise. --- libstdc++-v3/include/bits/std_mutex.h | 1 - libstdc++-v3/include/std/condition_variable | 3 ++- libstdc++-v3/include/std/mutex | 2 +- libstdc++-v3/include/std/shared_mutex | 1 + 4 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libstdc++-v3/include/bits/std_mutex.h b/libstdc++-v3/include/bits/std_mutex.h index 68f5fb9ed65b..bc515358d23b 100644 --- a/libstdc++-v3/include/bits/std_mutex.h +++ b/libstdc++-v3/include/bits/std_mutex.h @@ -36,7 +36,6 @@ # include #else -#include #include #include diff --git a/libstdc++-v3/include/std/condition_variable b/libstdc++-v3/include/std/condition_variable index b885e1baa1b6..f671fe4afe1c 100644 --- a/libstdc++-v3/include/std/condition_variable +++ b/libstdc++-v3/include/std/condition_variable @@ -38,6 +38,7 @@ #else #include +#include #include #include #include @@ -372,7 +373,7 @@ _GLIBCXX_BEGIN_INLINE_ABI_NAMESPACE(_V2) { return __p(); } - + std::stop_callback __cb(__stoken, [this] { notify_all(); }); shared_ptr __mutex = _M_mutex; while (!__p()) diff --git a/libstdc++-v3/include/std/mutex b/libstdc++-v3/include/std/mutex index aca5f91e03c6..4eedbe5038ce 100644 --- a/libstdc++-v3/include/std/mutex +++ b/libstdc++-v3/include/std/mutex @@ -40,8 +40,8 @@ #include #include #include -#include #include +#include #include #include #if ! _GTHREAD_USE_MUTEX_TIMEDLOCK diff --git a/libstdc++-v3/include/std/shared_mutex b/libstdc++-v3/include/std/shared_mutex index 7b70697f1785..57c3cc54d81c 100644 --- a/libstdc++-v3/include/std/shared_mutex +++ b/libstdc++-v3/include/std/shared_mutex @@ -36,6 +36,7 @@ #if __cplusplus >= 201402L #include +#include #include #include // move, __exchange #include // defer_lock_t -- 2.47.3