From 235aa8858b9999c14603ff1d12c91c855d5dcf94 Mon Sep 17 00:00:00 2001 From: Heiko Hund Date: Mon, 3 Nov 2025 12:59:40 +0100 Subject: [PATCH] iservice: fix DNS address list generation While generating the address list string for the DNS server addresses, to be set in the registry, the offset is calculated the wrong way. This results in gaps between addresses after the first two. Reported-By: aarnav@srlabs.de Change-Id: I7252d5a252e91ffc03db142aa226c9eb1656480b Signed-off-by: Heiko Hund Acked-by: Lev Stipakov Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1339 Message-Id: <20251103115945.6615-1-gert@greenie.muc.de> Signed-off-by: Gert Doering --- src/openvpnserv/interactive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpnserv/interactive.c b/src/openvpnserv/interactive.c index 577d89ce9..58f1e0266 100644 --- a/src/openvpnserv/interactive.c +++ b/src/openvpnserv/interactive.c @@ -1873,7 +1873,7 @@ HandleDNSConfigMessage(const dns_cfg_message_t *msg, undo_lists_t *lists) { RtlIpv4AddressToStringA(&msg->addr[i].ipv4, addrs + offset); } - offset += strlen(addrs); + offset = strlen(addrs); } err = SetNameServers(iid, msg->family, addrs); -- 2.47.3