From 25d38cc6ecfb3086b6ace2c4f35de954f9c696f4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Pavel=20Filipensk=C3=BD?= Date: Fri, 24 Jun 2022 12:35:59 +0200 Subject: [PATCH] s3:winbind: Improve logging in winbindd_dsgetdcname.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Test scenario: $ bin/wbinfo --dsgetdcname=ADDOMAIN Signed-off-by: Pavel Filipenský Reviewed-by: Andreas Schneider --- source3/winbindd/winbindd_dsgetdcname.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/source3/winbindd/winbindd_dsgetdcname.c b/source3/winbindd/winbindd_dsgetdcname.c index d001213c875..9dadeab863b 100644 --- a/source3/winbindd/winbindd_dsgetdcname.c +++ b/source3/winbindd/winbindd_dsgetdcname.c @@ -18,6 +18,7 @@ */ #include "includes.h" +#include "util/debug.h" #include "winbindd.h" #include "librpc/gen_ndr/ndr_winbind_c.h" #include "lib/util/string_wrappers.h" @@ -48,6 +49,10 @@ struct tevent_req *winbindd_dsgetdcname_send(TALLOC_CTX *mem_ctx, return NULL; } + D_NOTICE("[%s (%u)] Winbind external command DSGETDCNAME start.\n", + cli->client_name, + (unsigned int)cli->pid); + request->data.dsgetdcname.domain_name [sizeof(request->data.dsgetdcname.domain_name)-1] = '\0'; request->data.dsgetdcname.site_name @@ -55,8 +60,8 @@ struct tevent_req *winbindd_dsgetdcname_send(TALLOC_CTX *mem_ctx, request->data.dsgetdcname.domain_guid [sizeof(request->data.dsgetdcname.domain_guid)-1] = '\0'; - DEBUG(3, ("[%5lu]: dsgetdcname for %s\n", (unsigned long)cli->pid, - request->data.dsgetdcname.domain_name)); + D_NOTICE("Calling DsGetDcName for domain '%s'.\n", + request->data.dsgetdcname.domain_name); ds_flags = get_dsgetdc_flags(request->data.dsgetdcname.flags); @@ -106,12 +111,12 @@ NTSTATUS winbindd_dsgetdcname_recv(struct tevent_req *req, char *guid_str; NTSTATUS status; + D_NOTICE("Winbind external command DSGETDCNAME end.\n"); if (tevent_req_is_nterror(req, &status)) { - DEBUG(5, ("dsgetdcname failed: %s\n", nt_errstr(status))); + D_WARNING("Failed with: %s\n", nt_errstr(status)); return status; } - fstrcpy(response->data.dsgetdcname.dc_unc, state->dc_info->dc_unc); fstrcpy(response->data.dsgetdcname.dc_address, -- 2.47.3