From 2a06c992c81010ef9408bb9db065a2d1b2b49876 Mon Sep 17 00:00:00 2001 From: Noel Power Date: Mon, 18 Apr 2016 16:04:26 +0100 Subject: [PATCH] s4:torture:raw: fix 'Syscall param writev(vector[...])' valgrind error running smbtorture test raw.open.chained-ntcreatex.chained-ntcreatex results in the following valgrind trace ==30405== Syscall param writev(vector[...]) points to uninitialised byte(s) ==30405== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==30405== by 0x106CB033: writev_handler (async_sock.c:340) ==30405== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30405== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==30405== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==30405== by 0x5AE3400: smbcli_request_receive (rawrequest.c:416) ==30405== by 0x5AE343E: smbcli_request_simple_recv (rawrequest.c:430) ==30405== by 0x5ADC8BC: smb_raw_close (rawfile.c:847) ==30405== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30405== by 0x1A66B4: test_chained_ntcreatex_readx (open.c:1735) ==30405== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30405== by 0x955368F: internal_torture_run_test (torture.c:442) ==30405== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30405== by 0x2600A4: run_matching (smbtorture.c:110) ==30405== by 0x25FF66: run_matching (smbtorture.c:95) ==30405== by 0x25FF66: run_matching (smbtorture.c:95) ==30405== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==30405== by 0x261E44: main (smbtorture.c:665) ==30405== Address 0x187e1196 is 598 bytes inside a block of size 1,325 alloc'd ==30405== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==30405== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==30405== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==30405== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==30405== by 0x5ADFAB7: smbcli_transport_setup_subreq (clitransport.c:254) ==30405== by 0x5ADFC37: smbcli_transport_send (clitransport.c:326) ==30405== by 0x5AE33C3: smbcli_request_send (rawrequest.c:400) ==30405== by 0x5ADC869: smb_raw_close_send (rawfile.c:832) ==30405== by 0x5ADC8AC: smb_raw_close (rawfile.c:846) ==30405== by 0x9BE60B4: smbcli_close (clifile.c:316) ==30405== by 0x1A66B4: test_chained_ntcreatex_readx (open.c:1735) ==30405== by 0x16B21D: wrap_simple_1smb_test (util_smb.c:856) ==30405== by 0x955368F: internal_torture_run_test (torture.c:442) ==30405== by 0x9553A6B: torture_run_test_restricted (torture.c:542) ==30405== by 0x2600A4: run_matching (smbtorture.c:110) ==30405== by 0x25FF66: run_matching (smbtorture.c:95) ==30405== by 0x25FF66: run_matching (smbtorture.c:95) ==30405== by 0x2601C5: torture_run_named_tests (smbtorture.c:143) ==30405== by 0x261E44: main (smbtorture.c:665) Signed-off-by: Noel Power Reviewed-by: Volker Lendecke Reviewed-by: Andreas Schneider --- source4/torture/raw/open.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/source4/torture/raw/open.c b/source4/torture/raw/open.c index dc76b0bf08b..fb8749d5220 100644 --- a/source4/torture/raw/open.c +++ b/source4/torture/raw/open.c @@ -1700,6 +1700,8 @@ static bool test_chained_ntcreatex_readx(struct torture_context *tctx, struct sm const char buf[] = "test"; char buf2[4]; + ZERO_STRUCT(io); + torture_assert(tctx, torture_setup_dir(cli, BASEDIR), "Failed to setup up test directory: " BASEDIR); torture_comment(tctx, "Checking RAW_NTCREATEX_READX chained on " -- 2.47.3