From 2a57c75ec68ca68ccfaede8d61af5736a514b020 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Fri, 7 Jan 2022 14:25:47 +0100 Subject: [PATCH] 4.4-stable patches added patches: mac80211-initialize-variable-have_higher_than_11mbit.patch --- ...ize-variable-have_higher_than_11mbit.patch | 41 +++++++++++++++++++ queue-4.4/series | 1 + 2 files changed, 42 insertions(+) create mode 100644 queue-4.4/mac80211-initialize-variable-have_higher_than_11mbit.patch diff --git a/queue-4.4/mac80211-initialize-variable-have_higher_than_11mbit.patch b/queue-4.4/mac80211-initialize-variable-have_higher_than_11mbit.patch new file mode 100644 index 00000000000..35898e1a419 --- /dev/null +++ b/queue-4.4/mac80211-initialize-variable-have_higher_than_11mbit.patch @@ -0,0 +1,41 @@ +From 68a18ad71378a56858141c4449e02a30c829763e Mon Sep 17 00:00:00 2001 +From: Tom Rix +Date: Thu, 23 Dec 2021 08:28:48 -0800 +Subject: mac80211: initialize variable have_higher_than_11mbit + +From: Tom Rix + +commit 68a18ad71378a56858141c4449e02a30c829763e upstream. + +Clang static analysis reports this warnings + +mlme.c:5332:7: warning: Branch condition evaluates to a + garbage value + have_higher_than_11mbit) + ^~~~~~~~~~~~~~~~~~~~~~~ + +have_higher_than_11mbit is only set to true some of the time in +ieee80211_get_rates() but is checked all of the time. So +have_higher_than_11mbit needs to be initialized to false. + +Fixes: 5d6a1b069b7f ("mac80211: set basic rates earlier") +Signed-off-by: Tom Rix +Reviewed-by: Nick Desaulniers +Link: https://lore.kernel.org/r/20211223162848.3243702-1-trix@redhat.com +Signed-off-by: Johannes Berg +Signed-off-by: Greg Kroah-Hartman +--- + net/mac80211/mlme.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +--- a/net/mac80211/mlme.c ++++ b/net/mac80211/mlme.c +@@ -4431,7 +4431,7 @@ static int ieee80211_prep_connection(str + + if (new_sta) { + u32 rates = 0, basic_rates = 0; +- bool have_higher_than_11mbit; ++ bool have_higher_than_11mbit = false; + int min_rate = INT_MAX, min_rate_index = -1; + struct ieee80211_chanctx_conf *chanctx_conf; + const struct cfg80211_bss_ies *ies; diff --git a/queue-4.4/series b/queue-4.4/series index 812bda88cfe..abe5d454e37 100644 --- a/queue-4.4/series +++ b/queue-4.4/series @@ -1,3 +1,4 @@ bpf-test-fix-ld_abs-vlan-push-pop-stress-test.patch bluetooth-btusb-apply-qca-rome-patches-for-some-ath3012-models.patch ieee802154-atusb-fix-uninit-value-in-atusb_set_extended_addr.patch +mac80211-initialize-variable-have_higher_than_11mbit.patch -- 2.47.3