From 2aecc668878feebf8c88e2d38a657070a8ddb07a Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 21 Jan 2020 10:13:07 +0100 Subject: [PATCH] hwdb: use strv_extend() where we can --- src/libsystemd/sd-hwdb/hwdb-util.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/src/libsystemd/sd-hwdb/hwdb-util.c b/src/libsystemd/sd-hwdb/hwdb-util.c index 1a2da9c79bd..658fa5fbcf3 100644 --- a/src/libsystemd/sd-hwdb/hwdb-util.c +++ b/src/libsystemd/sd-hwdb/hwdb-util.c @@ -477,7 +477,6 @@ static int import_file(struct trie *trie, const char *filename, uint16_t file_pr _cleanup_fclose_ FILE *f = NULL; _cleanup_strv_free_ char **match_list = NULL; uint32_t line_number = 0; - char *match = NULL; int r = 0, err; f = fopen(filename, "re"); @@ -527,11 +526,7 @@ static int import_file(struct trie *trie, const char *filename, uint16_t file_pr /* start of record, first match */ state = HW_MATCH; - match = strdup(line); - if (!match) - return -ENOMEM; - - err = strv_consume(&match_list, match); + err = strv_extend(&match_list, line); if (err < 0) return err; @@ -549,11 +544,7 @@ static int import_file(struct trie *trie, const char *filename, uint16_t file_pr if (line[0] != ' ') { /* another match */ - match = strdup(line); - if (!match) - return -ENOMEM; - - err = strv_consume(&match_list, match); + err = strv_extend(&match_list, line); if (err < 0) return err; -- 2.47.3