From 32c492e8516ba17ad7e411e24169bf4e5498aed7 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sun, 24 Nov 2024 12:05:39 +0100 Subject: [PATCH] smbd: TALLOC_FREE(sd) where it was allocated Signed-off-by: Volker Lendecke Reviewed-by: Martin Schwenke --- source3/smbd/open.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/source3/smbd/open.c b/source3/smbd/open.c index e61b50b3801..b87b74988ae 100644 --- a/source3/smbd/open.c +++ b/source3/smbd/open.c @@ -198,8 +198,6 @@ static NTSTATUS smbd_check_access_rights_sd( } } - TALLOC_FREE(sd); - if (NT_STATUS_IS_OK(status) || !NT_STATUS_EQUAL(status, NT_STATUS_ACCESS_DENIED)) { @@ -327,13 +325,15 @@ NTSTATUS smbd_check_access_rights_fsp(struct files_struct *dirfsp, return status; } - return smbd_check_access_rights_sd(fsp->conn, - dirfsp, - fsp->fsp_name, - sd, - use_privs, - access_mask, - do_not_check_mask); + status = smbd_check_access_rights_sd(fsp->conn, + dirfsp, + fsp->fsp_name, + sd, + use_privs, + access_mask, + do_not_check_mask); + TALLOC_FREE(sd); + return status; } /* -- 2.47.3