From 340563633cab974f3b3420137fedf2dec85ca88c Mon Sep 17 00:00:00 2001
From: Martin Schwenke <mschwenke@ddn.com>
Date: Sat, 22 Jun 2024 14:54:53 +1000
Subject: [PATCH] ctdb-tests: Add more reloadnodes unit tests

There are no existing tests to exercise node IP address change
detection.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Reviewed-by: Guenther Deschner <gd@samba.org>
---
 ctdb/tests/UNIT/tool/ctdb.reloadnodes.030.sh | 25 +++++++++++++++++
 ctdb/tests/UNIT/tool/ctdb.reloadnodes.031.sh | 25 +++++++++++++++++
 ctdb/tests/UNIT/tool/ctdb.reloadnodes.032.sh | 25 +++++++++++++++++
 ctdb/tests/UNIT/tool/ctdb.reloadnodes.033.sh | 27 ++++++++++++++++++
 ctdb/tests/UNIT/tool/ctdb.reloadnodes.034.sh | 26 ++++++++++++++++++
 ctdb/tests/UNIT/tool/ctdb.reloadnodes.035.sh | 29 ++++++++++++++++++++
 6 files changed, 157 insertions(+)
 create mode 100755 ctdb/tests/UNIT/tool/ctdb.reloadnodes.030.sh
 create mode 100755 ctdb/tests/UNIT/tool/ctdb.reloadnodes.031.sh
 create mode 100755 ctdb/tests/UNIT/tool/ctdb.reloadnodes.032.sh
 create mode 100755 ctdb/tests/UNIT/tool/ctdb.reloadnodes.033.sh
 create mode 100755 ctdb/tests/UNIT/tool/ctdb.reloadnodes.034.sh
 create mode 100755 ctdb/tests/UNIT/tool/ctdb.reloadnodes.035.sh

diff --git a/ctdb/tests/UNIT/tool/ctdb.reloadnodes.030.sh b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.030.sh
new file mode 100755
index 00000000000..ddf69b8ac9a
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.030.sh
@@ -0,0 +1,25 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "3 nodes, 1st node changes IP address"
+
+setup_nodes <<EOF
+192.168.20.51
+192.168.20.42
+192.168.20.43
+EOF
+
+setup_ctdbd <<EOF
+NODEMAP
+0       192.168.20.41   0x0     CURRENT RECMASTER
+1       192.168.20.42   0x0
+2       192.168.20.43   0x0
+EOF
+
+required_result 1 <<EOF
+Node 0 has changed IP address (was 192.168.20.41, now 192.168.20.51)
+ERROR: Nodes will not be reloaded due to previous error
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.reloadnodes.031.sh b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.031.sh
new file mode 100755
index 00000000000..61c7fab04fb
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.031.sh
@@ -0,0 +1,25 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "3 nodes, 2nd node changes IP address"
+
+setup_nodes <<EOF
+192.168.20.41
+192.168.20.52
+192.168.20.43
+EOF
+
+setup_ctdbd <<EOF
+NODEMAP
+0       192.168.20.41   0x0     CURRENT RECMASTER
+1       192.168.20.42   0x0
+2       192.168.20.43   0x0
+EOF
+
+required_result 1 <<EOF
+Node 1 has changed IP address (was 192.168.20.42, now 192.168.20.52)
+ERROR: Nodes will not be reloaded due to previous error
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.reloadnodes.032.sh b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.032.sh
new file mode 100755
index 00000000000..18b20649b46
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.032.sh
@@ -0,0 +1,25 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "3 nodes, 3rd node changes IP address"
+
+setup_nodes <<EOF
+192.168.20.41
+192.168.20.42
+192.168.20.53
+EOF
+
+setup_ctdbd <<EOF
+NODEMAP
+0       192.168.20.41   0x0     CURRENT RECMASTER
+1       192.168.20.42   0x0
+2       192.168.20.43   0x0
+EOF
+
+required_result 1 <<EOF
+Node 2 has changed IP address (was 192.168.20.43, now 192.168.20.53)
+ERROR: Nodes will not be reloaded due to previous error
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.reloadnodes.033.sh b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.033.sh
new file mode 100755
index 00000000000..b3aaf1f686c
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.033.sh
@@ -0,0 +1,27 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "3 nodes, all nodes change IP address"
+
+setup_nodes <<EOF
+192.168.20.51
+192.168.20.52
+192.168.20.53
+EOF
+
+setup_ctdbd <<EOF
+NODEMAP
+0       192.168.20.41   0x0     CURRENT RECMASTER
+1       192.168.20.42   0x0
+2       192.168.20.43   0x0
+EOF
+
+required_result 1 <<EOF
+Node 0 has changed IP address (was 192.168.20.41, now 192.168.20.51)
+Node 1 has changed IP address (was 192.168.20.42, now 192.168.20.52)
+Node 2 has changed IP address (was 192.168.20.43, now 192.168.20.53)
+ERROR: Nodes will not be reloaded due to previous error
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.reloadnodes.034.sh b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.034.sh
new file mode 100755
index 00000000000..e2d423d1c55
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.034.sh
@@ -0,0 +1,26 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "3 nodes, list reversed nodes change IP address"
+
+setup_nodes <<EOF
+192.168.20.43
+192.168.20.42
+192.168.20.41
+EOF
+
+setup_ctdbd <<EOF
+NODEMAP
+0       192.168.20.41   0x0     CURRENT RECMASTER
+1       192.168.20.42   0x0
+2       192.168.20.43   0x0
+EOF
+
+required_result 1 <<EOF
+Node 0 has changed IP address (was 192.168.20.41, now 192.168.20.43)
+Node 2 has changed IP address (was 192.168.20.43, now 192.168.20.41)
+ERROR: Nodes will not be reloaded due to previous error
+EOF
+
+simple_test
diff --git a/ctdb/tests/UNIT/tool/ctdb.reloadnodes.035.sh b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.035.sh
new file mode 100755
index 00000000000..9c058bd20d3
--- /dev/null
+++ b/ctdb/tests/UNIT/tool/ctdb.reloadnodes.035.sh
@@ -0,0 +1,29 @@
+#!/bin/sh
+
+. "${TEST_SCRIPTS_DIR}/unit.sh"
+
+define_test "3 nodes, comment at beginning, deleted node, nodes move"
+
+setup_nodes <<EOF
+# Adding a comment!
+192.168.20.41
+192.168.20.42
+192.168.20.43
+EOF
+
+setup_ctdbd <<EOF
+NODEMAP
+0       192.168.20.41   0x0     CURRENT RECMASTER
+1       192.168.20.42   0x0
+2       192.168.20.43   0x0
+EOF
+
+required_result 1 <<EOF
+Node 0 is DELETED
+ERROR: Node 0 is still connected
+Node 1 has changed IP address (was 192.168.20.42, now 192.168.20.41)
+Node 2 has changed IP address (was 192.168.20.43, now 192.168.20.42)
+ERROR: Nodes will not be reloaded due to previous error
+EOF
+
+simple_test
-- 
2.47.3