From 34a35ac15efee431a7848da51409f7dcdf95b48b Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 24 Sep 2019 09:51:08 -0700 Subject: [PATCH] smbd: Fix CID 1453984: Null pointer dereferences (REVERSE_INULL) Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme --- source3/locking/share_mode_lock.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/source3/locking/share_mode_lock.c b/source3/locking/share_mode_lock.c index abd911f4be2..aeb9fd4b18b 100644 --- a/source3/locking/share_mode_lock.c +++ b/source3/locking/share_mode_lock.c @@ -2031,9 +2031,7 @@ static void mark_share_mode_disconnected_fn( bool mark_share_mode_disconnected(struct share_mode_lock *lck, struct files_struct *fsp) { - struct mark_share_mode_disconnected_state state = { - .open_persistent_id = fsp->op->global->open_persistent_id, - }; + struct mark_share_mode_disconnected_state state; bool ok; if (lck->data->num_share_modes != 1) { @@ -2047,6 +2045,10 @@ bool mark_share_mode_disconnected(struct share_mode_lock *lck, return false; } + state = (struct mark_share_mode_disconnected_state) { + .open_persistent_id = fsp->op->global->open_persistent_id, + }; + ok = share_mode_entry_do( lck, messaging_server_id(fsp->conn->sconn->msg_ctx), -- 2.47.3