From 36e289ca6496bb820b112398398f45ab78d23a1d Mon Sep 17 00:00:00 2001 From: Nicholas Nethercote Date: Wed, 5 Aug 2009 05:05:15 +0000 Subject: [PATCH] Augment a comment. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@10714 --- memcheck/mc_main.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/memcheck/mc_main.c b/memcheck/mc_main.c index 7929d24541..d83464fcda 100644 --- a/memcheck/mc_main.c +++ b/memcheck/mc_main.c @@ -5780,6 +5780,12 @@ static void mc_pre_clo_init(void) // - Telying on the zeroed-ness of whole brk'd pages is pretty grotty... I // doubt most programmers know the above information. // So I'm not terribly unhappy with marking it as undefined. --njn. + // + // [More: I think most of what John said only applies to sbrk(). It seems + // that brk() always deals in whole pages. And since this event deals + // directly with brk(), not with sbrk(), perhaps it would be reasonable to + // just mark all memory it allocates as defined.] + // VG_(track_new_mem_brk) ( make_mem_undefined_w_tid ); VG_(track_new_mem_mmap) ( mc_new_mem_mmap ); -- 2.47.3