From 383e5e1c4bfa604bcd479100258b4ff354dbaabb Mon Sep 17 00:00:00 2001 From: "D. Ben Knoble" Date: Sun, 2 Nov 2025 11:17:48 -0500 Subject: [PATCH] parseopt: restore const qualifier to parsed filename This was unintentionally dropped in ccfcaf399f (parseopt: values of pathname type can be prefixed with :(optional), 2025-09-28). Notably, continue dropping the const qualifier when free'ing value; see 4049b9cfc0 (fix const issues with some functions, 2007-10-16) or 83838d5c1b (cast variable in call to free() in builtin/diff.c and submodule.c, 2011-11-06) for more details on why. Suggested-by: Phillip Wood Signed-off-by: D. Ben Knoble Signed-off-by: Junio C Hamano --- parse-options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/parse-options.c b/parse-options.c index b105e4b6cf..27c1e75d53 100644 --- a/parse-options.c +++ b/parse-options.c @@ -213,7 +213,7 @@ static enum parse_opt_result do_get_value(struct parse_opt_ctx_t *p, if (unset) value = NULL; else if (opt->flags & PARSE_OPT_OPTARG && !p->opt) - value = (char *)opt->defval; + value = (const char *)opt->defval; else { int err = get_arg(p, opt, flags, &value); if (err) -- 2.47.3