From 3929fdae1a13ab029e173ce53598d3fa6cf40e9c Mon Sep 17 00:00:00 2001 From: Anoop C S Date: Wed, 14 Aug 2024 19:47:35 +0530 Subject: [PATCH] source3/script: Fix installation of winbind_ctdb_updatekeytab.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit winbind_ctdb_updatekeytab.sh assumes the presence `onnode` utility to execute `net ads` command on all nodes in the cluster. But `onnode` is only built when configured with clustering support. Therefore perform the script installation only with ctdb configuration. Also fix the installation path to /usr/share/ctdb/scripts. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15689 Signed-off-by: Anoop C S Reviewed-by: Andreas Schneider Reviewed-by: Guenther Deschner Reviewed-by: Pavel Filipenský --- source3/script/wscript_build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source3/script/wscript_build b/source3/script/wscript_build index 2b0643b0876..bc451497298 100644 --- a/source3/script/wscript_build +++ b/source3/script/wscript_build @@ -6,7 +6,9 @@ bld.INSTALL_FILES('${BINDIR}', 'smbtar', chmod=MODE_755, flat=True) bld.INSTALL_FILES('${BINDIR}', 'samba-log-parser', chmod=MODE_755, flat=True) -bld.INSTALL_FILES('${DATADIR}', 'winbind_ctdb_updatekeytab.sh', chmod=MODE_755, flat=True) +if conf.env.with_ctdb: + bld.INSTALL_FILES(bld.env.CTDB_DATADIR+"/scripts", + 'winbind_ctdb_updatekeytab.sh', chmod=MODE_755, flat=True) # Callout scripts for use in selftest environment bld.SAMBA_SCRIPT('smbaddshare', pattern='smbaddshare', installdir='.') -- 2.47.3