From 3a71d619a935b57acacb6a8ba7c80b0ae938eacd Mon Sep 17 00:00:00 2001 From: Christof Schmitt Date: Wed, 19 Jun 2019 13:42:19 -0700 Subject: [PATCH] nfs4_acls: Change type of smbacl4_substitute_simple to void The function always returned true and the return code was never checked, so simply change to void. Signed-off-by: Christof Schmitt Reviewed-by: Ralph Boehme --- source3/modules/nfs4_acls.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/source3/modules/nfs4_acls.c b/source3/modules/nfs4_acls.c index 974f72c2223..bec7cc390d3 100644 --- a/source3/modules/nfs4_acls.c +++ b/source3/modules/nfs4_acls.c @@ -902,14 +902,11 @@ static void smbacl4_substitute_special(struct SMB4ACL_T *acl, DEBUG(10,("replaced with special group ace\n")); } } - return true; /* OK */ } -static int smbacl4_substitute_simple( - struct SMB4ACL_T *acl, - uid_t ownerUID, - gid_t ownerGID -) +static void smbacl4_substitute_simple(struct SMB4ACL_T *acl, + uid_t ownerUID, + gid_t ownerGID) { struct SMB4ACE_T *aceint; @@ -939,7 +936,6 @@ static int smbacl4_substitute_simple( DEBUG(10,("replaced with special group ace\n")); } } - return true; /* OK */ } static struct SMB4ACL_T *smbacl4_win2nfs4( -- 2.47.3