From 3bb4dbecc3020a7eae58b06d5d312be6d4979dfb Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Thu, 1 Apr 2021 15:23:48 +1300 Subject: [PATCH] py/provision/sambadns: Add a comment about DNS types Signed-off-by: Douglas Bagnall Reviewed-by: Andreas Schneider --- python/samba/provision/sambadns.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/python/samba/provision/sambadns.py b/python/samba/provision/sambadns.py index 7c6ef0978cf..4ddde36b4cb 100644 --- a/python/samba/provision/sambadns.py +++ b/python/samba/provision/sambadns.py @@ -75,6 +75,15 @@ def get_dnsadmins_sid(samdb, domaindn): return dnsadmins_sid +# Note: these classses are not quite the same as similar looking ones +# in ../dnsserver.py -- those ones are based on +# dnsserver.DNS_RPC_RECORD ([MS-DNSP]2.2.2.2.5 "DNS_RPC_RECORD"), +# these are based on dnsp.DnssrvRpcRecord ([MS-DNSP] 2.3.2.2 +# "DnsRecord"). +# +# They are not interchangeable or mergeable. If you're talking over +# the wire you want those other ones; these are the on-disk format. + class ARecord(dnsp.DnssrvRpcRecord): def __init__(self, ip_addr, serial=1, ttl=900, rank=dnsp.DNS_RANK_ZONE): -- 2.47.3