From 3ceff9968be059209f0d7271365f38895207b24d Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Mon, 7 Feb 2022 00:05:29 -0800 Subject: [PATCH] bpo-40479: Fix undefined behavior in Modules/_hashopenssl.c (GH-31153) va_end() must be called before returning. (cherry picked from commit 59e004af63742361b67d1e1ae70229ff0db1059d) Co-authored-by: Zackery Spytz --- .../Core and Builtins/2022-02-06-23-08-30.bpo-40479.zED3Zu.rst | 1 + Modules/_hashopenssl.c | 1 + 2 files changed, 2 insertions(+) create mode 100644 Misc/NEWS.d/next/Core and Builtins/2022-02-06-23-08-30.bpo-40479.zED3Zu.rst diff --git a/Misc/NEWS.d/next/Core and Builtins/2022-02-06-23-08-30.bpo-40479.zED3Zu.rst b/Misc/NEWS.d/next/Core and Builtins/2022-02-06-23-08-30.bpo-40479.zED3Zu.rst new file mode 100644 index 000000000000..52701d53d8fe --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2022-02-06-23-08-30.bpo-40479.zED3Zu.rst @@ -0,0 +1 @@ +Add a missing call to ``va_end()`` in ``Modules/_hashopenssl.c``. diff --git a/Modules/_hashopenssl.c b/Modules/_hashopenssl.c index 2eaa5f7d85d8..65538f63f7bf 100644 --- a/Modules/_hashopenssl.c +++ b/Modules/_hashopenssl.c @@ -266,6 +266,7 @@ _setException(PyObject *exc, const char* altmsg, ...) } else { PyErr_FormatV(exc, altmsg, vargs); } + va_end(vargs); return NULL; } va_end(vargs); -- 2.47.3