From 3d618689e254429cd2c36132af0c0b3904c1d7e4 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Sun, 22 Nov 2020 20:14:19 +0100 Subject: [PATCH] python:tests:samba_tool: create temporary files under $SELFTEST_TMPDIR Tests should not create files in the build nor the source directory! Signed-off-by: Stefan Metzmacher Reviewed-by: Andrew Bartlett Reviewed-by: Andreas Schneider --- python/samba/tests/samba_tool/computer_edit.sh | 2 +- python/samba/tests/samba_tool/contact_edit.sh | 2 +- python/samba/tests/samba_tool/group_edit.sh | 2 +- python/samba/tests/samba_tool/user_edit.sh | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/python/samba/tests/samba_tool/computer_edit.sh b/python/samba/tests/samba_tool/computer_edit.sh index 7459c396603..9830fe3f681 100755 --- a/python/samba/tests/samba_tool/computer_edit.sh +++ b/python/samba/tests/samba_tool/computer_edit.sh @@ -23,7 +23,7 @@ display_name_new="Bjoerns new laptop" # echo -e "test \a string" | base64 display_name_con_b64="dGVzdCAHIHN0cmluZwo=" -tmpeditor=$(mktemp --suffix .sh -p $STpath/bin samba-tool-editor-XXXXXXXX) +tmpeditor=$(mktemp --suffix .sh -p $SELFTEST_TMPDIR samba-tool-editor-XXXXXXXX) chmod +x $tmpeditor create_test_computer() { diff --git a/python/samba/tests/samba_tool/contact_edit.sh b/python/samba/tests/samba_tool/contact_edit.sh index ee9c40b59ce..038fbe2b4d7 100755 --- a/python/samba/tests/samba_tool/contact_edit.sh +++ b/python/samba/tests/samba_tool/contact_edit.sh @@ -23,7 +23,7 @@ display_name_new="Renamed Bjoern" # echo -e "test \a string" | base64 display_name_con_b64="dGVzdCAHIHN0cmluZwo=" -tmpeditor=$(mktemp --suffix .sh -p $STpath/bin samba-tool-editor-XXXXXXXX) +tmpeditor=$(mktemp --suffix .sh -p $SELFTEST_TMPDIR samba-tool-editor-XXXXXXXX) chmod +x $tmpeditor create_test_contact() { diff --git a/python/samba/tests/samba_tool/group_edit.sh b/python/samba/tests/samba_tool/group_edit.sh index d0428af9169..e8e4fecb2a9 100755 --- a/python/samba/tests/samba_tool/group_edit.sh +++ b/python/samba/tests/samba_tool/group_edit.sh @@ -23,7 +23,7 @@ display_name_new="Users in Goettingen" # echo -e "test \a string" | base64 display_name_con_b64="dGVzdCAHIHN0cmluZwo=" -tmpeditor=$(mktemp --suffix .sh -p $STpath/bin samba-tool-editor-XXXXXXXX) +tmpeditor=$(mktemp --suffix .sh -p $SELFTEST_TMPDIR samba-tool-editor-XXXXXXXX) chmod +x $tmpeditor create_test_group() { diff --git a/python/samba/tests/samba_tool/user_edit.sh b/python/samba/tests/samba_tool/user_edit.sh index ae0854e89f6..7f0140ce6dd 100755 --- a/python/samba/tests/samba_tool/user_edit.sh +++ b/python/samba/tests/samba_tool/user_edit.sh @@ -23,7 +23,7 @@ display_name_new="Renamed Bjoern" # echo -e "test \a string" | base64 display_name_con_b64="dGVzdCAHIHN0cmluZwo=" -tmpeditor=$(mktemp --suffix .sh -p $STpath/bin samba-tool-editor-XXXXXXXX) +tmpeditor=$(mktemp --suffix .sh -p ${SELFTEST_TMPDIR} samba-tool-editor-XXXXXXXX) chmod +x $tmpeditor create_test_user() { -- 2.47.3