From 3d8aec664476b62a3bacb6ad531d02f01007fc11 Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Sat, 1 Apr 2017 12:20:20 +1300 Subject: [PATCH] Add move semantics to Security::ServerOptions and Security::PeerOptions This apparently will make the clear() operators faster as they no longer have to data-copy. Detected by Coverity Scan. Issues 1364734 and 1364737 --- src/security/PeerOptions.h | 2 ++ src/security/ServerOptions.h | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/src/security/PeerOptions.h b/src/security/PeerOptions.h index cbe848ecd6..72cf2904d1 100644 --- a/src/security/PeerOptions.h +++ b/src/security/PeerOptions.h @@ -25,6 +25,8 @@ public: PeerOptions(); PeerOptions(const PeerOptions &) = default; PeerOptions &operator =(const PeerOptions &) = default; + PeerOptions(PeerOptions &&) = default; + PeerOptions &operator =(PeerOptions &&) = default; virtual ~PeerOptions() {} /// parse a TLS squid.conf option diff --git a/src/security/ServerOptions.h b/src/security/ServerOptions.h index cb79f47f7a..6072d97399 100644 --- a/src/security/ServerOptions.h +++ b/src/security/ServerOptions.h @@ -24,6 +24,10 @@ public: // is more secure to have only a small set of trusted CA. flags.tlsDefaultCa.defaultTo(false); } + ServerOptions(const ServerOptions &) = default; + ServerOptions &operator =(const ServerOptions &) = default; + ServerOptions(ServerOptions &&) = default; + ServerOptions &operator =(ServerOptions &&) = default; virtual ~ServerOptions() = default; /* Security::PeerOptions API */ -- 2.47.3