From 409cd516ca4faf0a7305a917d93d72a81b80bc9c Mon Sep 17 00:00:00 2001 From: Noel Power Date: Fri, 15 Apr 2016 16:22:02 +0100 Subject: [PATCH] s4:libnet: fix 'Syscall param writev(vector[...])' valgrind error running smbtorture rpc.dfs.netdfs.StdRoot yields the following valgrind trace ==18861== Syscall param writev(vector[...]) points to uninitialised byte(s) ==18861== at 0xFBA2C87: writev (in /lib64/libc-2.19.so) ==18861== by 0x106CB033: writev_handler (async_sock.c:340) ==18861== by 0xF67812A: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF6765F6: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF6727FC: _tevent_loop_once (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF673ACE: tevent_req_poll (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0x5D19325: tevent_req_poll_ntstatus (tevent_ntstatus.c:109) ==18861== by 0x88B2E0D: dcerpc_binding_handle_call (binding_handle.c:556) ==18861== by 0xBC6D0D2: dcerpc_srvsvc_NetShareDel_r (ndr_srvsvc_c.c:4272) ==18861== by 0x9786C0C: libnet_DelShare (libnet_share.c:195) ==18861== by 0x2E0174: test_NetShareDel (dfs.c:103) ==18861== by 0x2E126F: test_cleanup_stdroot (dfs.c:488) ==18861== Address 0x18869b46 is 598 bytes inside a block of size 1,325 alloc'd ==18861== at 0x4C29110: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==18861== by 0xF464A73: _talloc_pooled_object (in /usr/lib64/libtalloc.so.2.1.5) ==18861== by 0xF67366D: _tevent_req_create (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xB0D49FF: smb1cli_req_create (smbXcli_base.c:1322) ==18861== by 0xB0E1E6D: smb1cli_trans_send (smb1cli_trans.c:512) ==18861== by 0xB0ED47D: tstream_smbXcli_np_readv_trans_start (tstream_smbXcli_np.c:901) ==18861== by 0xB0EC847: tstream_smbXcli_np_writev_write_next (tstream_smbXcli_np.c:578) ==18861== by 0xB0EC4D7: tstream_smbXcli_np_writev_send (tstream_smbXcli_np.c:505) ==18861== by 0xC259DFA: tstream_writev_send (tsocket.c:695) ==18861== by 0xC25AD64: tstream_writev_queue_trigger (tsocket_helpers.c:513) ==18861== by 0xF673023: tevent_common_loop_immediate (in /usr/lib64/libtevent.so.0.9.26) ==18861== by 0xF677EED: ??? (in /usr/lib64/libtevent.so.0.9.26) ==18861== Signed-off-by: Noel Power Reviewed-by: Volker Lendecke Reviewed-by: Andreas Schneider --- source4/libnet/libnet_share.c | 1 + 1 file changed, 1 insertion(+) diff --git a/source4/libnet/libnet_share.c b/source4/libnet/libnet_share.c index 7c9121b1391..d8e8240303b 100644 --- a/source4/libnet/libnet_share.c +++ b/source4/libnet/libnet_share.c @@ -175,6 +175,7 @@ NTSTATUS libnet_DelShare(struct libnet_context *ctx, struct srvsvc_NetShareDel s; ZERO_STRUCT(c); + ZERO_STRUCT(s); c.level = LIBNET_RPC_CONNECT_SERVER; c.in.name = r->in.server_name; -- 2.47.3