From 40b29347c05e969dc2d23223a426ce652b123589 Mon Sep 17 00:00:00 2001 From: Frank Lichtenheld Date: Mon, 3 Nov 2025 12:55:46 +0100 Subject: [PATCH] manage: Correctly handle port 65535 in man_kill Commit c66d433111c958c42cc98f4ba12d3cfc1bd5b3b4 introduced an off-by-one when changing a literal to a constant. Github: fixes OpenVPN/openvpn#887 Change-Id: I19373408a82332d7b2e5c634e5509c8be3727b5a Signed-off-by: Frank Lichtenheld Acked-by: Gert Doering Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1341 Message-Id: <20251103115552.6201-1-gert@greenie.muc.de> Signed-off-by: Gert Doering --- src/openvpn/manage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/openvpn/manage.c b/src/openvpn/manage.c index e46b5f227..6efa1001a 100644 --- a/src/openvpn/manage.c +++ b/src/openvpn/manage.c @@ -612,7 +612,7 @@ man_kill(struct management *man, const char *victim) : (streq(p1, "udp")) ? PROTO_UDP : PROTO_NONE; - if ((port > 0 && port < UINT16_MAX) && (proto != PROTO_NONE)) + if ((port > 0 && port <= UINT16_MAX) && (proto != PROTO_NONE)) { n_killed = (*man->persist.callback.kill_by_addr)(man->persist.callback.arg, addr, (uint16_t)port, proto); -- 2.47.3