From 40c31f0563ec10e5b112be35e2e003f8ce4afe98 Mon Sep 17 00:00:00 2001 From: Ethan Tidmore Date: Wed, 25 Feb 2026 16:24:53 -0600 Subject: [PATCH] ntfs: Fix null pointer dereference The variable ctx can be null and once confirmed to be null in its error path goes to label err_out. Once there it can be immediately dereferenced by the function ntfs_attr_put_search_ctx() which has no null pointer check. Detected by Smatch: fs/ntfs/ea.c:687 ntfs_new_attr_flags() error: we previously assumed 'ctx' could be null (see line 577) Add null pointer check before running ntfs_attr_put_search_ctx() in error path. Signed-off-by: Ethan Tidmore Reviewed-by: Hyunchul Lee Signed-off-by: Namjae Jeon --- fs/ntfs/ea.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/ntfs/ea.c b/fs/ntfs/ea.c index 82ad9b61ec64b..b2b0a9a043a9e 100644 --- a/fs/ntfs/ea.c +++ b/fs/ntfs/ea.c @@ -684,7 +684,8 @@ out: a->flags = new_aflags; mark_mft_record_dirty(ctx->ntfs_ino); err_out: - ntfs_attr_put_search_ctx(ctx); + if (ctx) + ntfs_attr_put_search_ctx(ctx); unmap_mft_record(ni); return err; } -- 2.47.3