From 437b30db77460a3af41d4fd0398bd6ff03f910ae Mon Sep 17 00:00:00 2001 From: Philipp Stanner Date: Tue, 28 Oct 2025 14:46:01 +0100 Subject: [PATCH] drm/sched: Fix comment in drm_sched_run_job_work() drm_sched_run_job_work() contains a comment which explains that an entity being NULL means that there is no more work to do. It can, however, also mean that there is work, but the scheduler doesn't have enough credits to process the jobs right now. Provide this detail in the comment. Reviewed-by: Matthew Brost Signed-off-by: Philipp Stanner Link: https://patch.msgid.link/20251028134602.94125-3-phasta@kernel.org --- drivers/gpu/drm/scheduler/sched_main.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index c39f0245e3a97..492e8af639dbe 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -1237,8 +1237,13 @@ static void drm_sched_run_job_work(struct work_struct *w) /* Find entity with a ready job */ entity = drm_sched_select_entity(sched); - if (!entity) - return; /* No more work */ + if (!entity) { + /* + * Either no more work to do, or the next ready job needs more + * credits than the scheduler has currently available. + */ + return; + } sched_job = drm_sched_entity_pop_job(entity); if (!sched_job) { -- 2.47.3