From 466d30c0d7fa861a5fcbaebd2e2010a8c2aea322 Mon Sep 17 00:00:00 2001 From: Nicola Tuveri Date: Sat, 27 Jun 2020 01:42:49 +0300 Subject: [PATCH] [apps/genpkey] exit status should not be 0 on output errors If the key is to be serialized or printed as text and the framework returns an error, the app should signal the failure to the user using a non-zero exit status. Reviewed-by: Matt Caswell (Merged from https://github.com/openssl/openssl/pull/12305) --- apps/genpkey.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apps/genpkey.c b/apps/genpkey.c index 8954ef19c75..4a4a83fd40a 100644 --- a/apps/genpkey.c +++ b/apps/genpkey.c @@ -189,9 +189,12 @@ int genpkey_main(int argc, char **argv) goto end; } + ret = 0; + if (rv <= 0) { BIO_puts(bio_err, "Error writing key\n"); ERR_print_errors(bio_err); + ret = 1; } if (text) { @@ -203,11 +206,10 @@ int genpkey_main(int argc, char **argv) if (rv <= 0) { BIO_puts(bio_err, "Error printing key\n"); ERR_print_errors(bio_err); + ret = 1; } } - ret = 0; - end: EVP_PKEY_free(pkey); EVP_PKEY_CTX_free(ctx); -- 2.47.3