From 47c171005fb3803d936e65fcd4436c643883ae16 Mon Sep 17 00:00:00 2001 From: Alexandru DAMIAN Date: Wed, 18 Sep 2013 13:15:50 +0100 Subject: [PATCH] bitbake: cooker: get extra information from recipe cache The loaded cache modules may add extra attributes to the recipecache, that will be populated by the cache classes required by the UI. These attributes will be used by the UI to display relevant information. Adds cachefields cache class field to specify for each cache class which attributes will be set in the recipecache. Adds code to automatically expand depends tree with the fields exported by the extra cache class. Fixes a cache field name in the HOB UI. Signed-off-by: Alexandru DAMIAN Signed-off-by: Richard Purdie --- lib/bb/cache_extra.py | 6 ++++ lib/bb/cooker.py | 50 ++++++++++++++++++-------------- lib/bb/ui/crumbs/hoblistmodel.py | 2 +- 3 files changed, 36 insertions(+), 22 deletions(-) diff --git a/lib/bb/cache_extra.py b/lib/bb/cache_extra.py index 9e38a439e8f..83f4959d6ce 100644 --- a/lib/bb/cache_extra.py +++ b/lib/bb/cache_extra.py @@ -35,6 +35,12 @@ class HobRecipeInfo(RecipeInfoCommon): # such as (bb_cache.dat, bb_extracache_hob.dat) cachefile = "bb_extracache_" + classname +".dat" + # override this member with the list of extra cache fields + # that this class will provide + cachefields = ['summary', 'license', 'section', + 'description', 'homepage', 'bugtracker', + 'prevision', 'files_info'] + def __init__(self, filename, metadata): self.summary = self.getvar('SUMMARY', metadata) diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py index dd45ae8173b..fafa5189116 100644 --- a/lib/bb/cooker.py +++ b/lib/bb/cooker.py @@ -481,6 +481,19 @@ class BBCooker: depend_tree["pn"][pn] = {} depend_tree["pn"][pn]["filename"] = fn depend_tree["pn"][pn]["version"] = version + + # if we have extra caches, list all attributes they bring in + extra_info = [] + for cache_class in self.caches_array: + if type(cache_class) is type and issubclass(cache_class, bb.cache.RecipeInfoCommon) and hasattr(cache_class, 'cachefields'): + cachefields = getattr(cache_class, 'cachefields', []) + extra_info = extra_info + cachefields + + # for all attributes stored, add them to the dependency tree + for ei in extra_info: + depend_tree["pn"][pn][ei] = vars(self.recipecache)[ei][fn] + + for dep in rq.rqdata.runq_depends[task]: depfn = taskdata.fn_index[rq.rqdata.runq_fnid[dep]] deppn = self.recipecache.pkg_fn[depfn] @@ -543,35 +556,30 @@ class BBCooker: depend_tree["rdepends-pkg"] = {} depend_tree["rrecs-pkg"] = {} + # if we have extra caches, list all attributes they bring in + extra_info = [] + for cache_class in self.caches_array: + if type(cache_class) is type and issubclass(cache_class, bb.cache.RecipeInfoCommon) and hasattr(cache_class, 'cachefields'): + cachefields = getattr(cache_class, 'cachefields', []) + extra_info = extra_info + cachefields + for task in xrange(len(tasks_fnid)): fnid = tasks_fnid[task] fn = taskdata.fn_index[fnid] pn = self.recipecache.pkg_fn[fn] - version = "%s:%s-%s" % self.recipecache.pkg_pepvpr[fn] - summary = self.recipecache.summary[fn] - lic = self.recipecache.license[fn] - section = self.recipecache.section[fn] - description = self.recipecache.description[fn] - homepage = self.recipecache.homepage[fn] - bugtracker = self.recipecache.bugtracker[fn] - files_info = self.recipecache.files_info[fn] - rdepends = self.recipecache.rundeps[fn] - rrecs = self.recipecache.runrecs[fn] - prevision = self.recipecache.prevision[fn] - inherits = self.recipecache.inherits.get(fn, None) + if pn not in depend_tree["pn"]: depend_tree["pn"][pn] = {} depend_tree["pn"][pn]["filename"] = fn + version = "%s:%s-%s" % self.recipecache.pkg_pepvpr[fn] depend_tree["pn"][pn]["version"] = version - depend_tree["pn"][pn]["summary"] = summary - depend_tree["pn"][pn]["license"] = lic - depend_tree["pn"][pn]["section"] = section - depend_tree["pn"][pn]["description"] = description - depend_tree["pn"][pn]["inherits"] = inherits - depend_tree["pn"][pn]["homepage"] = homepage - depend_tree["pn"][pn]["bugtracker"] = bugtracker - depend_tree["pn"][pn]["files_info"] = files_info - depend_tree["pn"][pn]["revision"] = prevision + rdepends = self.recipecache.rundeps[fn] + rrecs = self.recipecache.runrecs[fn] + depend_tree["pn"][pn]["inherits"] = self.recipecache.inherits.get(fn, None) + + # for all extra attributes stored, add them to the dependency tree + for ei in extra_info: + depend_tree["pn"][pn][ei] = vars(self.recipecache)[ei][fn] if fnid not in seen_fnids: seen_fnids.append(fnid) diff --git a/lib/bb/ui/crumbs/hoblistmodel.py b/lib/bb/ui/crumbs/hoblistmodel.py index 74d335c88b0..b4d2a621b77 100644 --- a/lib/bb/ui/crumbs/hoblistmodel.py +++ b/lib/bb/ui/crumbs/hoblistmodel.py @@ -690,7 +690,7 @@ class RecipeListModel(gtk.ListStore): inherits = event_model["pn"][item]["inherits"] summary = event_model["pn"][item]["summary"] version = event_model["pn"][item]["version"] - revision = event_model["pn"][item]["revision"] + revision = event_model["pn"][item]["prevision"] homepage = event_model["pn"][item]["homepage"] bugtracker = event_model["pn"][item]["bugtracker"] filename = event_model["pn"][item]["filename"] -- 2.47.3