From 482bb31ce3268e05f8396df139c30f4970fc558c Mon Sep 17 00:00:00 2001 From: James Coglan Date: Thu, 30 May 2024 18:46:12 +0100 Subject: [PATCH] resolved: tests for dns_question_matches_cname_or_dname() --- src/resolve/test-dns-question.c | 78 +++++++++++++++++++++++++++++++++ 1 file changed, 78 insertions(+) diff --git a/src/resolve/test-dns-question.c b/src/resolve/test-dns-question.c index 5f68829b1e0..3cbb3a99ee6 100644 --- a/src/resolve/test-dns-question.c +++ b/src/resolve/test-dns-question.c @@ -316,4 +316,82 @@ TEST(dns_question_matches_rr_fail) { ASSERT_FALSE(dns_question_matches_rr(question, rr, NULL)); } +/* ================================================================ + * dns_question_matches_cname_or_dname() + * ================================================================ */ + +TEST(dns_question_matches_cname) { + _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL; + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + question = dns_question_new(1); + ASSERT_NOT_NULL(question); + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(key); + dns_question_add(question, key, 0); + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com"); + ASSERT_NOT_NULL(rr); + ASSERT_TRUE(dns_question_matches_cname_or_dname(question, rr, NULL)); +} + +TEST(dns_question_matches_dname) { + _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL; + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + question = dns_question_new(1); + ASSERT_NOT_NULL(question); + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(key); + dns_question_add(question, key, 0); + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNAME, "example.com"); + ASSERT_NOT_NULL(rr); + ASSERT_TRUE(dns_question_matches_cname_or_dname(question, rr, NULL)); +} + +TEST(dns_question_matches_cname_or_dname_fail) { + _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL; + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + question = dns_question_new(1); + ASSERT_NOT_NULL(question); + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(key); + dns_question_add(question, key, 0); + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + ASSERT_FALSE(dns_question_matches_cname_or_dname(question, rr, NULL)); +} + +TEST(dns_question_matches_cname_or_dname_all_must_redirect) { + _cleanup_(dns_question_unrefp) DnsQuestion *question = NULL; + DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + question = dns_question_new(2); + ASSERT_NOT_NULL(question); + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_CNAME, "example.com"); + ASSERT_NOT_NULL(key); + dns_question_add(question, key, 0); + dns_resource_key_unref(key); + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(key); + dns_question_add(question, key, 0); + dns_resource_key_unref(key); + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com"); + ASSERT_NOT_NULL(rr); + ASSERT_FALSE(dns_question_matches_cname_or_dname(question, rr, NULL)); +} + DEFINE_TEST_MAIN(LOG_DEBUG); -- 2.47.3