From 49019ba3a92eb96127004efb1b79c712b741cc1a Mon Sep 17 00:00:00 2001 From: "W.C.A. Wijngaards" Date: Tue, 25 Aug 2020 16:07:25 +0200 Subject: [PATCH] Review fix: defense check of qdcount in debug output. --- services/outside_network.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/services/outside_network.c b/services/outside_network.c index 6f5ebd2f1..5f60b847c 100644 --- a/services/outside_network.c +++ b/services/outside_network.c @@ -805,6 +805,7 @@ reuse_move_writewait_away(struct outside_network* outnet, /* since the current query is not written, it can also * move to a free buffer */ if(verbosity >= 5 && pend->query->pkt_len > 12+2+2 && + LDNS_QDCOUNT(pend->query->pkt) > 0 && dname_valid(pend->query->pkt+12, pend->query->pkt_len-12)) { char buf[LDNS_MAX_DOMAINLEN+1]; dname_str(pend->query->pkt+12, buf); @@ -829,6 +830,7 @@ reuse_move_writewait_away(struct outside_network* outnet, } while((w = reuse_write_wait_pop(&pend->reuse)) != NULL) { if(verbosity >= 5 && w->pkt_len > 12+2+2 && + LDNS_QDCOUNT(w->pkt) > 0 && dname_valid(w->pkt+12, w->pkt_len-12)) { char buf[LDNS_MAX_DOMAINLEN+1]; dname_str(w->pkt+12, buf); -- 2.47.3