From 503007991b8212203954c4febae7ad7f245d97c6 Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Tue, 2 Jul 2024 11:23:13 +0200 Subject: [PATCH] rename: use ul_basename() Fixes: https://github.com/util-linux/util-linux/issues/3071 Signed-off-by: Karel Zak (cherry picked from commit 0309a6f5ca018d83420e49e0f9d046fecdb29261) --- meson.build | 1 + misc-utils/Makemodule.am | 1 + misc-utils/rename.c | 4 ++-- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index e3a2780ad1..b9e3eb59f1 100644 --- a/meson.build +++ b/meson.build @@ -2992,6 +2992,7 @@ exe = executable( 'rename', rename_sources, include_directories : includes, + link_with : [lib_common], install_dir : usrbin_exec_dir, install : opt, build_by_default : opt) diff --git a/misc-utils/Makemodule.am b/misc-utils/Makemodule.am index 6104c648ae..bb6f13b8e9 100644 --- a/misc-utils/Makemodule.am +++ b/misc-utils/Makemodule.am @@ -232,6 +232,7 @@ usrbin_exec_PROGRAMS += rename MANPAGES += misc-utils/rename.1 dist_noinst_DATA += misc-utils/rename.1.adoc rename_SOURCES = misc-utils/rename.c +rename_LDADD = $(LDADD) libcommon.la endif if BUILD_GETOPT diff --git a/misc-utils/rename.c b/misc-utils/rename.c index 9ab38695f2..bb2e3103db 100644 --- a/misc-utils/rename.c +++ b/misc-utils/rename.c @@ -28,7 +28,6 @@ for i in $@; do N=`echo "$i" | sed "s/$FROM/$TO/g"`; mv "$i" "$N"; done #include #include #include -#include #include #include #include @@ -40,6 +39,7 @@ for i in $@; do N=`echo "$i" | sed "s/$FROM/$TO/g"`; mv "$i" "$N"; done #include "closestream.h" #include "optutils.h" #include "rpmatch.h" +#include "fileutils.h" #define RENAME_EXIT_SOMEOK 2 #define RENAME_EXIT_NOTHING 4 @@ -59,7 +59,7 @@ static char *find_initial_replace(char *from, char *to, char *orig) /* We only want to search in the final path component. Don't include the final '/' in that component; if `from` is empty, we want it to first match after the '/', not before. */ - search_start = basename(orig); + search_start = ul_basename(orig); } return strstr(search_start, from); -- 2.47.3