From 504b58ec76b7f020a9b4bfe12cf8666dbcae8ce3 Mon Sep 17 00:00:00 2001 From: Pieter Lexis Date: Mon, 13 Oct 2025 14:36:36 +0200 Subject: [PATCH] feat(dnsdist): Add Span Kind to Spans and add a name to ScopeSpan --- pdns/dnsdistdist/dnsdist-opentelemetry.cc | 2 ++ pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/pdns/dnsdistdist/dnsdist-opentelemetry.cc b/pdns/dnsdistdist/dnsdist-opentelemetry.cc index f5fea72056..822f385bea 100644 --- a/pdns/dnsdistdist/dnsdist-opentelemetry.cc +++ b/pdns/dnsdistdist/dnsdist-opentelemetry.cc @@ -45,6 +45,7 @@ TracesData Tracer::getTracesData() "service.name", pdns::trace::AnyValue{"dnsdist"}}, }}, .scope_spans = std::vector{{.scope = { + .name = "queryFromFrontend", .attributes = {d_attributes.begin(), d_attributes.end()}, }, .spans = {}}}}}}; @@ -59,6 +60,7 @@ TracesData Tracer::getTracesData() .span_id = preActivationTrace.span_id, .parent_span_id = preActivationTrace.parent_span_id, .name = preActivationTrace.name, + .kind = pdns::trace::Span::SpanKind::SPAN_KINSERVER, .start_time_unix_nano = preActivationTrace.start_time_unix_nano, .end_time_unix_nano = preActivationTrace.end_time_unix_nano, }); diff --git a/pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc b/pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc index 847437aa32..49364631be 100644 --- a/pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc +++ b/pdns/dnsdistdist/test-dnsdist-opentelemetry_cc.cc @@ -238,12 +238,12 @@ BOOST_AUTO_TEST_CASE(getOTProtobuf) { auto tracer = pdns::trace::dnsdist::Tracer::getTracer(); auto data = tracer->getOTProtobuf(); - BOOST_TEST(data.size() == 31U); + BOOST_TEST(data.size() == 54U); tracer->activate(); tracer->setTraceAttribute("foo", AnyValue{"bar"}); data = tracer->getOTProtobuf(); - BOOST_TEST(data.size() == 49U); + BOOST_TEST(data.size() == 68U); } BOOST_AUTO_TEST_SUITE_END() -- 2.47.3