From 51250c6142c47def3f835f124e7416b0b375b9ef Mon Sep 17 00:00:00 2001 From: =?utf8?q?Pavel=20Filipensk=C3=BD?= Date: Mon, 11 Jul 2022 22:39:06 +0200 Subject: [PATCH] s3:winbind: Change num_sids from int to uint32_t in wb_lookupuseraliases_send() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Pavel Filipenský Reviewed-by: Andreas Schneider --- source3/winbindd/wb_lookupuseraliases.c | 12 ++++++------ source3/winbindd/winbindd_getsidaliases.c | 2 +- source3/winbindd/winbindd_proto.h | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/source3/winbindd/wb_lookupuseraliases.c b/source3/winbindd/wb_lookupuseraliases.c index 49d257e883e..4517e066df9 100644 --- a/source3/winbindd/wb_lookupuseraliases.c +++ b/source3/winbindd/wb_lookupuseraliases.c @@ -33,12 +33,12 @@ static void wb_lookupuseraliases_done(struct tevent_req *subreq); struct tevent_req *wb_lookupuseraliases_send(TALLOC_CTX *mem_ctx, struct tevent_context *ev, struct winbindd_domain *domain, - int num_sids, + uint32_t num_sids, const struct dom_sid *sids) { struct tevent_req *req, *subreq; struct wb_lookupuseraliases_state *state; - int i; + uint32_t i; req = tevent_req_create(mem_ctx, &state, struct wb_lookupuseraliases_state); @@ -47,12 +47,12 @@ struct tevent_req *wb_lookupuseraliases_send(TALLOC_CTX *mem_ctx, } D_INFO("WB command lookupuseraliases start.\n" - "Query domain %s for max %d SID(s).\n", + "Query domain %s for max %u SID(s).\n", domain->name, num_sids); for (i = 0; i < num_sids; i++) { struct dom_sid_buf buf; - D_INFO("%d: SID %s\n", i, dom_sid_str_buf(&sids[i], &buf)); + D_INFO("%u: SID %s\n", i, dom_sid_str_buf(&sids[i], &buf)); } state->sids.num_sids = num_sids; state->sids.sids = discard_const_p(struct dom_sid, sids); @@ -97,10 +97,10 @@ NTSTATUS wb_lookupuseraliases_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx, return status; } *num_aliases = state->rids.num_rids; - D_INFO("WB command lookupuseraliases end.\nGot %d alias(es):\n", + D_INFO("WB command lookupuseraliases end.\nGot %u alias(es):\n", *num_aliases); for (i = 0; i < *num_aliases; i++) { - D_INFO("%d: RID %d\n", i, state->rids.rids[i]); + D_INFO("%u: RID %u\n", i, state->rids.rids[i]); } *aliases = talloc_move(mem_ctx, &state->rids.rids); diff --git a/source3/winbindd/winbindd_getsidaliases.c b/source3/winbindd/winbindd_getsidaliases.c index de323a19251..d3326276744 100644 --- a/source3/winbindd/winbindd_getsidaliases.c +++ b/source3/winbindd/winbindd_getsidaliases.c @@ -37,7 +37,7 @@ struct tevent_req *winbindd_getsidaliases_send(TALLOC_CTX *mem_ctx, struct tevent_req *req, *subreq; struct winbindd_getsidaliases_state *state; struct winbindd_domain *domain; - uint32_t num_sids; + uint32_t num_sids, i; struct dom_sid *sids; req = tevent_req_create(mem_ctx, &state, diff --git a/source3/winbindd/winbindd_proto.h b/source3/winbindd/winbindd_proto.h index 6824cdbbe53..b2e33098cf9 100644 --- a/source3/winbindd/winbindd_proto.h +++ b/source3/winbindd/winbindd_proto.h @@ -649,7 +649,7 @@ NTSTATUS winbindd_getpwuid_recv(struct tevent_req *req, struct tevent_req *wb_lookupuseraliases_send(TALLOC_CTX *mem_ctx, struct tevent_context *ev, struct winbindd_domain *domain, - int num_sids, + uint32_t num_sids, const struct dom_sid *sids); NTSTATUS wb_lookupuseraliases_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx, uint32_t *num_aliases, uint32_t **aliases); -- 2.47.3