From 516501e20ef1db8a4b02f685a090712e807ede9f Mon Sep 17 00:00:00 2001 From: Evan You Date: Thu, 24 Oct 2019 15:39:31 -0400 Subject: [PATCH] chore: remove unused util function --- .../compiler-core/__tests__/utils.spec.ts | 46 +------------------ packages/compiler-core/src/utils.ts | 6 +-- 2 files changed, 3 insertions(+), 49 deletions(-) diff --git a/packages/compiler-core/__tests__/utils.spec.ts b/packages/compiler-core/__tests__/utils.spec.ts index d93d321299..b5d1bea04c 100644 --- a/packages/compiler-core/__tests__/utils.spec.ts +++ b/packages/compiler-core/__tests__/utils.spec.ts @@ -1,9 +1,5 @@ -import { Position, NodeTypes } from '../src/ast' -import { - getInnerRange, - advancePositionWithClone, - isEmptyExpression -} from '../src/utils' +import { Position } from '../src/ast' +import { getInnerRange, advancePositionWithClone } from '../src/utils' function p(line: number, column: number, offset: number): Position { return { column, line, offset } @@ -71,41 +67,3 @@ describe('getInnerRange', () => { expect(loc2.end.offset).toBe(7) }) }) - -describe('isEmptyExpression', () => { - test('empty', () => { - expect( - isEmptyExpression({ - content: '', - type: NodeTypes.SIMPLE_EXPRESSION, - isStatic: true, - isConstant: true, - loc: null as any - }) - ).toBe(true) - }) - - test('spaces', () => { - expect( - isEmptyExpression({ - content: ' \t ', - type: NodeTypes.SIMPLE_EXPRESSION, - isStatic: true, - isConstant: true, - loc: null as any - }) - ).toBe(true) - }) - - test('identifier', () => { - expect( - isEmptyExpression({ - content: 'foo', - type: NodeTypes.SIMPLE_EXPRESSION, - isStatic: true, - isConstant: true, - loc: null as any - }) - ).toBe(false) - }) -}) diff --git a/packages/compiler-core/src/utils.ts b/packages/compiler-core/src/utils.ts index 2017d6910b..cb0b562cc6 100644 --- a/packages/compiler-core/src/utils.ts +++ b/packages/compiler-core/src/utils.ts @@ -164,7 +164,7 @@ export function findProp( const p = node.props[i] if (p.type === NodeTypes.ATTRIBUTE) { if (dynamicOnly) continue - if (p.name === name && p.value && !p.value.isEmpty) { + if (p.name === name && p.value) { return p } } else if ( @@ -248,10 +248,6 @@ export function toValidAssetId( return `_${type}_${name.replace(/[^\w]/g, '_')}` } -export function isEmptyExpression(node: ExpressionNode) { - return node.type === NodeTypes.SIMPLE_EXPRESSION && !node.content.trim() -} - // Check if a node contains expressions that reference current context scope ids export function hasScopeRef( node: TemplateChildNode | IfBranchNode | ExpressionNode | undefined, -- 2.47.3