From 51ace4d00106920cfae560d3d4489c5daefdeb79 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Tue, 13 Apr 2021 12:06:16 +1200 Subject: [PATCH] dns_record_match: drop pretense of HINFO support We don't support it really, and if we did there is no sense in which it could be updated, which is the context in which this function is used. (modern HINFO returns the constant string "RFC8482". See RFC 8482). Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- source4/dns_server/dnsserver_common.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/source4/dns_server/dnsserver_common.c b/source4/dns_server/dnsserver_common.c index b0b430342ad..855323035fb 100644 --- a/source4/dns_server/dnsserver_common.c +++ b/source4/dns_server/dnsserver_common.c @@ -1329,10 +1329,6 @@ bool dns_records_match(struct dnsp_DnssrvRpcRecord *rec1, return rec1->data.mx.wPriority == rec2->data.mx.wPriority && dns_name_equal(rec1->data.mx.nameTarget, rec2->data.mx.nameTarget); - case DNS_TYPE_HINFO: - return strcmp(rec1->data.hinfo.cpu, rec2->data.hinfo.cpu) == 0 && - strcmp(rec1->data.hinfo.os, rec2->data.hinfo.os) == 0; - case DNS_TYPE_SOA: return dns_name_equal(rec1->data.soa.mname, rec2->data.soa.mname) && dns_name_equal(rec1->data.soa.rname, rec2->data.soa.rname) && -- 2.47.3