From 559cd9e5a7fac3ce3769d457132cdcb28569b93d Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 25 Mar 2008 22:21:50 +0100 Subject: [PATCH] Fix a segfault When we get a NT_STATUS_WRONG_PASSWORD for example, my_info3 is not initialized at all. So first check that we have NT_STATUS_IS_OK(status) before we dereference my_info3. --- source/winbindd/winbindd_pam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/winbindd/winbindd_pam.c b/source/winbindd/winbindd_pam.c index c56eb1b3f89..5712f086038 100644 --- a/source/winbindd/winbindd_pam.c +++ b/source/winbindd/winbindd_pam.c @@ -1362,7 +1362,7 @@ NTSTATUS winbindd_dual_pam_auth_samlogon(struct winbindd_domain *domain, * caller, we look up the account flags ourselve - gd */ if ((state->request.flags & WBFLAG_PAM_INFO3_TEXT) && - (my_info3->base.acct_flags == 0) && NT_STATUS_IS_OK(result)) { + NT_STATUS_IS_OK(result) && (my_info3->base.acct_flags == 0)) { struct rpc_pipe_client *samr_pipe; POLICY_HND samr_domain_handle, user_pol; -- 2.47.3