From 55d2dfa12ceb88a8aebcbb69eb358ac5c9518fe7 Mon Sep 17 00:00:00 2001 From: Karel Zak Date: Thu, 25 Feb 2021 14:37:17 +0100 Subject: [PATCH] irqtop: check scols_line_set_data() return code Signed-off-by: Karel Zak --- sys-utils/irq-common.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sys-utils/irq-common.c b/sys-utils/irq-common.c index 4fb064251f..b066e4ba7f 100644 --- a/sys-utils/irq-common.c +++ b/sys-utils/irq-common.c @@ -465,10 +465,8 @@ struct libscols_table *get_scols_cpus_table(struct irq_output *out, /* per cpu % of total */ ln = new_scols_line(table); - if (!ln) + if (!ln || (!out->json && scols_line_set_data(ln, 0, "%irq:") != 0)) goto err; - if (!out->json) - scols_line_set_data(ln, 0, "%irq:"); for (i = 0; i < curr->nr_active_cpu; i++) { struct irq_cpu *cpu = &curr->cpus[i]; @@ -481,10 +479,8 @@ struct libscols_table *get_scols_cpus_table(struct irq_output *out, /* per cpu % of delta */ ln = new_scols_line(table); - if (!ln) + if (!ln || (!out->json && scols_line_set_data(ln, 0, _("%delta:")) != 0)) goto err; - if (!out->json) - scols_line_set_data(ln, 0, _("%delta:")); for (i = 0; i < curr->nr_active_cpu; i++) { struct irq_cpu *cpu = &curr->cpus[i]; -- 2.47.3