From 577c719a1158d93e9666eca43b2335f984d49f59 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Fri, 18 Jul 2014 14:27:59 -0400 Subject: [PATCH] - Fixed bug in oracle dialect test suite where in one test, 'username' was assumed to be in the database URL, even though this might not be the case. Fixes #3128 --- doc/build/changelog/changelog_09.rst | 9 +++++++++ test/dialect/test_oracle.py | 9 +++++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/doc/build/changelog/changelog_09.rst b/doc/build/changelog/changelog_09.rst index adfdae83d2..62cdeb7661 100644 --- a/doc/build/changelog/changelog_09.rst +++ b/doc/build/changelog/changelog_09.rst @@ -14,6 +14,15 @@ :version: 0.9.7 :released: + .. change:: + :tags: bug, oracle, tests + :tickets: 3128 + :versions: 1.0.0 + + Fixed bug in oracle dialect test suite where in one test, + 'username' was assumed to be in the database URL, even though + this might not be the case. + .. change:: :tags: bug, orm, eagerloading :tickets: 3131 diff --git a/test/dialect/test_oracle.py b/test/dialect/test_oracle.py index 0418758799..4e5a4bbd24 100644 --- a/test/dialect/test_oracle.py +++ b/test/dialect/test_oracle.py @@ -1688,14 +1688,15 @@ class RoundTripIndexTest(fixtures.TestBase): obj.columns]), getattr(obj, 'unique', None) # find what the primary k constraint name should be - primaryconsname = testing.db.execute( - text("""SELECT constraint_name + primaryconsname = testing.db.scalar( + text( + """SELECT constraint_name FROM all_constraints WHERE table_name = :table_name AND owner = :owner AND constraint_type = 'P' """), - table_name=table.name.upper(), - owner=testing.db.url.username.upper()).fetchall()[0][0] + table_name=table.name.upper(), + owner=testing.db.dialect.default_schema_name.upper()) reflectedtable = inspect.tables[table.name] -- 2.47.3