From 59e987a0b7cc8992f96db95d5e2027215662b90d Mon Sep 17 00:00:00 2001 From: James Coglan Date: Tue, 11 Jun 2024 15:48:30 +0100 Subject: [PATCH] resolved: tests for dns_packet_has_nsid_request() --- src/resolve/test-dns-packet-extract.c | 121 ++++++++++++++++++++++++++ 1 file changed, 121 insertions(+) diff --git a/src/resolve/test-dns-packet-extract.c b/src/resolve/test-dns-packet-extract.c index 1413ef17a4a..440eba3e9ba 100644 --- a/src/resolve/test-dns-packet-extract.c +++ b/src/resolve/test-dns-packet-extract.c @@ -3032,6 +3032,127 @@ TEST(packet_ede_rcode_malformed_ede_payload) { ASSERT_ERROR(dns_packet_ede_rcode(packet, &ret_ede_rcode, &ret_ede_msg), ENOENT); } +/* ================================================================ + * dns_packet_has_nsid_request() + * ================================================================ */ + +TEST(packet_has_nsid_request_no_match) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + dns_packet_truncate(packet, 0); + + const uint8_t data[] = { + 0x00, 0x42, BIT_QR | BIT_AA, DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, + + /* name */ 0x00, + /* OPT */ 0x00, 0x29, + /* udp max */ 0x02, 0x01, + /* rcode */ 0x00, + /* version */ 0x00, + /* flags */ 0x80, 0x00, + /* rdata */ 0x00, 0x00 + }; + + ASSERT_OK(dns_packet_append_blob(packet, data, sizeof(data), NULL)); + + ASSERT_OK(dns_packet_extract(packet)); + + ASSERT_FALSE(dns_packet_has_nsid_request(packet)); +} + +TEST(packet_has_nsid_request_match_empty_option) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + dns_packet_truncate(packet, 0); + + const uint8_t data[] = { + 0x00, 0x42, BIT_QR | BIT_AA, DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, + + /* name */ 0x00, + /* OPT */ 0x00, 0x29, + /* udp max */ 0x02, 0x01, + /* rcode */ 0x00, + /* version */ 0x00, + /* flags */ 0x80, 0x00, + /* rdata */ 0x00, 0x04, + 0x00, 0x03, /* NSID option code */ + 0x00, 0x00 + }; + + ASSERT_OK(dns_packet_append_blob(packet, data, sizeof(data), NULL)); + + ASSERT_OK(dns_packet_extract(packet)); + + ASSERT_TRUE(dns_packet_has_nsid_request(packet)); +} + +TEST(packet_has_nsid_request_match_multiple) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + dns_packet_truncate(packet, 0); + + const uint8_t data[] = { + 0x00, 0x42, BIT_QR | BIT_AA, DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, + + /* name */ 0x00, + /* OPT */ 0x00, 0x29, + /* udp max */ 0x02, 0x01, + /* rcode */ 0x00, + /* version */ 0x00, + /* flags */ 0x80, 0x00, + /* rdata */ 0x00, 0x08, + 0x00, 0x03, /* NSID option code */ + 0x00, 0x00, + 0x00, 0x03, /* NSID option code */ + 0x00, 0x00 + }; + + ASSERT_OK(dns_packet_append_blob(packet, data, sizeof(data), NULL)); + + ASSERT_OK(dns_packet_extract(packet)); + + ASSERT_ERROR(dns_packet_has_nsid_request(packet), EBADMSG); +} + +TEST(packet_has_nsid_request_match_not_empty) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + dns_packet_truncate(packet, 0); + + const uint8_t data[] = { + 0x00, 0x42, BIT_QR | BIT_AA, DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, + + /* name */ 0x00, + /* OPT */ 0x00, 0x29, + /* udp max */ 0x02, 0x01, + /* rcode */ 0x00, + /* version */ 0x00, + /* flags */ 0x80, 0x00, + /* rdata */ 0x00, 0x05, + 0x00, 0x03, /* NSID option code */ + 0x00, 0x01, + 0xff + }; + + ASSERT_OK(dns_packet_append_blob(packet, data, sizeof(data), NULL)); + + ASSERT_OK(dns_packet_extract(packet)); + + ASSERT_ERROR(dns_packet_has_nsid_request(packet), EBADMSG); +} + /* ================================================================ * reply: RRSIG * ================================================================ */ -- 2.47.3