From 5a4432b02ae02de3a74d538409ae6faa552c5201 Mon Sep 17 00:00:00 2001 From: Sasha Levin Date: Sun, 27 Dec 2020 23:33:23 -0500 Subject: [PATCH] Fixes for 4.4 Signed-off-by: Sasha Levin --- ...a5d3_xplained-add-pincontrol-for-usb.patch | 51 ++++++++ ...a5d4_xplained-add-pincontrol-for-usb.patch | 51 ++++++++ ...dling-of-lpae-translation-in-be-mode.patch | 55 +++++++++ ...40-i2s-add-missed-checks-for-clk_get.patch | 44 +++++++ .../asoc-pcm-drain-support-reactivation.patch | 51 ++++++++ ...ove-ctl-from-list-on-error-in-wm_ads.patch | 50 ++++++++ ...ll-pointer-dereference-in-hci_event_.patch | 49 ++++++++ .../cfg80211-initialize-rekey_data.patch | 36 ++++++ .../checkpatch-fix-unescaped-left-brace.patch | 42 +++++++ ...a-resource-leak-in-error-handling-pa.patch | 41 +++++++ ...-fix-memleak-in-ti_fapll_synth_setup.patch | 60 ++++++++++ ...ers-arm_arch_timer-correct-fault-pro.patch | 70 +++++++++++ ...bank-add-missing-module_device_table.patch | 45 +++++++ ...q-loongson1-add-missing-module_alias.patch | 38 ++++++ ...pufreq-scpi-add-missing-module_alias.patch | 38 ++++++ ...-fix-return-type-of-current_desc_hdr.patch | 55 +++++++++ ...ng-destroy_workqueue-on-error-in-cw1.patch | 46 ++++++++ ...-error-return-code-in-target_message.patch | 36 ++++++ ...nav_qmss_queue-fix-error-return-code.patch | 41 +++++++ ...500-fix-double-free-of-gma_connector.patch | 45 +++++++ ...er-fix-return-error-code-in-omap_dmm.patch | 36 ++++++ .../extcon-max77693-fix-modalias-string.patch | 34 ++++++ ...x-integer-overflow-on-rt-calculation.patch | 52 ++++++++ ...ads7846-fix-unaligned-access-on-7845.patch | 43 +++++++ ...yb-send-scancodes-in-addition-to-key.patch | 37 ++++++ ...-upside-down-quirk-for-teclast-x98-p.patch | 47 ++++++++ ...se-interval-based-rebinding-over-tcp.patch | 99 ++++++++++++++++ ...fix-array-overflow-in-vidioc_s_audio.patch | 56 +++++++++ ...ix-missing-snd_card_free-in-error-ha.patch | 38 ++++++ ...-a-double-free-bug-in-memstick_check.patch | 37 ++++++ ...-r592-fix-error-return-in-r592_probe.patch | 57 +++++++++ ...-kconfig-dependency-bug-for-bcm47xx_.patch | 48 ++++++++ ...e-after-free-in-mips_cdmm_bus_discov.patch | 41 +++++++ ...x-some-resources-leak-in-the-error-h.patch | 65 ++++++++++ ...-a-resource-leak-in-an-error-handlin.patch | 42 +++++++ ...te-net.ipv4.conf.all.proxy_arp_pvlan.patch | 38 ++++++ ....ipvx.conf.all.ignore_routes_with_li.patch | 111 ++++++++++++++++++ queue-4.4/net-korina-fix-return-value.patch | 43 +++++++ ...nfc-s3fwrn5-release-the-nfc-firmware.patch | 41 +++++++ ...ch-nfsiod-to-be-an-unbound-workqueue.patch | 52 ++++++++ ...lock-during-iterate-through-the-list.patch | 79 +++++++++++++ ...n-readdir-s-mask-for-security-label-.patch | 74 ++++++++++++ ...text-allocation-after-processing-the.patch | 60 ++++++++++ ...memory-leak-when-using-user-regs-to-.patch | 45 +++++++ ...dd-missing-put_device-call-in-pinctr.patch | 64 ++++++++++ ...fix-cpu_ftrs_always-by-removing-cpu_.patch | 68 +++++++++++ .../powerpc-ps3-use-dma_mapping_error.patch | 41 +++++++ ...hibernation-drop-pseries_suspend_beg.patch | 73 ++++++++++++ .../qlcnic-fix-error-code-in-probe.patch | 36 ++++++ ...work-around-wenum-conversion-warning.patch | 61 ++++++++++ ...-fix-error-return-code-in-fnic_probe.patch | 38 ++++++ ...fix-error-return-in-pm8001_pci_probe.patch | 41 +++++++ ...avoid-type-mismatch-for-seq_buf_init.patch | 68 +++++++++++ queue-4.4/series | 65 ++++++++++ ...eference-imbalance-in-knav_dma_probe.patch | 72 ++++++++++++ ...-fix-reference-leak-in-knav_queue_pr.patch | 36 ++++++ ...speakup-fix-uninitialized-flush_lock.patch | 39 ++++++ ...ix-reference-leak-in-img_spfi_resume.patch | 41 +++++++ ...-fix-reference-leak-in-ti_qspi_setup.patch | 37 ++++++ ...-fix-reference-leak-in-tegra-spi-ops.patch | 46 ++++++++ ...sh-fix-reference-leak-in-tegra_sflas.patch | 37 ++++++ ...k-fix-reference-leak-in-slink-ops-of.patch | 46 ++++++++ queue-4.4/um-chan_xterm-fix-fd-leak.patch | 66 +++++++++++ ...x-pm-disable-depth-umbalance-in-ehci.patch | 39 ++++++ ...hp-hcd-fix-memory-leak-in-oxu_create.patch | 42 +++++++ ...ore-btf-if-the-single-stepping-is-ca.patch | 46 ++++++++ 66 files changed, 3321 insertions(+) create mode 100644 queue-4.4/arm-dts-at91-sama5d3_xplained-add-pincontrol-for-usb.patch create mode 100644 queue-4.4/arm-dts-at91-sama5d4_xplained-add-pincontrol-for-usb.patch create mode 100644 queue-4.4/arm-p2v-fix-handling-of-lpae-translation-in-be-mode.patch create mode 100644 queue-4.4/asoc-jz4740-i2s-add-missed-checks-for-clk_get.patch create mode 100644 queue-4.4/asoc-pcm-drain-support-reactivation.patch create mode 100644 queue-4.4/asoc-wm_adsp-remove-ctl-from-list-on-error-in-wm_ads.patch create mode 100644 queue-4.4/bluetooth-fix-null-pointer-dereference-in-hci_event_.patch create mode 100644 queue-4.4/cfg80211-initialize-rekey_data.patch create mode 100644 queue-4.4/checkpatch-fix-unescaped-left-brace.patch create mode 100644 queue-4.4/clk-s2mps11-fix-a-resource-leak-in-error-handling-pa.patch create mode 100644 queue-4.4/clk-ti-fix-memleak-in-ti_fapll_synth_setup.patch create mode 100644 queue-4.4/clocksource-drivers-arm_arch_timer-correct-fault-pro.patch create mode 100644 queue-4.4/cpufreq-highbank-add-missing-module_device_table.patch create mode 100644 queue-4.4/cpufreq-loongson1-add-missing-module_alias.patch create mode 100644 queue-4.4/cpufreq-scpi-add-missing-module_alias.patch create mode 100644 queue-4.4/crypto-talitos-fix-return-type-of-current_desc_hdr.patch create mode 100644 queue-4.4/cw1200-fix-missing-destroy_workqueue-on-error-in-cw1.patch create mode 100644 queue-4.4/dm-ioctl-fix-error-return-code-in-target_message.patch create mode 100644 queue-4.4/drivers-soc-ti-knav_qmss_queue-fix-error-return-code.patch create mode 100644 queue-4.4/drm-gma500-fix-double-free-of-gma_connector.patch create mode 100644 queue-4.4/drm-omap-dmm_tiler-fix-return-error-code-in-omap_dmm.patch create mode 100644 queue-4.4/extcon-max77693-fix-modalias-string.patch create mode 100644 queue-4.4/input-ads7846-fix-integer-overflow-on-rt-calculation.patch create mode 100644 queue-4.4/input-ads7846-fix-unaligned-access-on-7845.patch create mode 100644 queue-4.4/input-cros_ec_keyb-send-scancodes-in-addition-to-key.patch create mode 100644 queue-4.4/input-goodix-add-upside-down-quirk-for-teclast-x98-p.patch create mode 100644 queue-4.4/lockd-don-t-use-interval-based-rebinding-over-tcp.patch create mode 100644 queue-4.4/media-saa7146-fix-array-overflow-in-vidioc_s_audio.patch create mode 100644 queue-4.4/media-solo6x10-fix-missing-snd_card_free-in-error-ha.patch create mode 100644 queue-4.4/memstick-fix-a-double-free-bug-in-memstick_check.patch create mode 100644 queue-4.4/memstick-r592-fix-error-return-in-r592_probe.patch create mode 100644 queue-4.4/mips-bcm47xx-fix-kconfig-dependency-bug-for-bcm47xx_.patch create mode 100644 queue-4.4/mips-cdmm-fix-use-after-free-in-mips_cdmm_bus_discov.patch create mode 100644 queue-4.4/net-allwinner-fix-some-resources-leak-in-the-error-h.patch create mode 100644 queue-4.4/net-bcmgenet-fix-a-resource-leak-in-an-error-handlin.patch create mode 100644 queue-4.4/net-evaluate-net.ipv4.conf.all.proxy_arp_pvlan.patch create mode 100644 queue-4.4/net-evaluate-net.ipvx.conf.all.ignore_routes_with_li.patch create mode 100644 queue-4.4/net-korina-fix-return-value.patch create mode 100644 queue-4.4/nfc-s3fwrn5-release-the-nfc-firmware.patch create mode 100644 queue-4.4/nfs-switch-nfsiod-to-be-an-unbound-workqueue.patch create mode 100644 queue-4.4/nfs_common-need-lock-during-iterate-through-the-list.patch create mode 100644 queue-4.4/nfsv4.2-condition-readdir-s-mask-for-security-label-.patch create mode 100644 queue-4.4/orinoco-move-context-allocation-after-processing-the.patch create mode 100644 queue-4.4/perf-record-fix-memory-leak-when-using-user-regs-to-.patch create mode 100644 queue-4.4/pinctrl-falcon-add-missing-put_device-call-in-pinctr.patch create mode 100644 queue-4.4/powerpc-feature-fix-cpu_ftrs_always-by-removing-cpu_.patch create mode 100644 queue-4.4/powerpc-ps3-use-dma_mapping_error.patch create mode 100644 queue-4.4/powerpc-pseries-hibernation-drop-pseries_suspend_beg.patch create mode 100644 queue-4.4/qlcnic-fix-error-code-in-probe.patch create mode 100644 queue-4.4/rdma-mthca-work-around-wenum-conversion-warning.patch create mode 100644 queue-4.4/scsi-fnic-fix-error-return-code-in-fnic_probe.patch create mode 100644 queue-4.4/scsi-pm80xx-fix-error-return-in-pm8001_pci_probe.patch create mode 100644 queue-4.4/seq_buf-avoid-type-mismatch-for-seq_buf_init.patch create mode 100644 queue-4.4/soc-ti-fix-reference-imbalance-in-knav_dma_probe.patch create mode 100644 queue-4.4/soc-ti-knav_qmss-fix-reference-leak-in-knav_queue_pr.patch create mode 100644 queue-4.4/speakup-fix-uninitialized-flush_lock.patch create mode 100644 queue-4.4/spi-img-spfi-fix-reference-leak-in-img_spfi_resume.patch create mode 100644 queue-4.4/spi-spi-ti-qspi-fix-reference-leak-in-ti_qspi_setup.patch create mode 100644 queue-4.4/spi-tegra114-fix-reference-leak-in-tegra-spi-ops.patch create mode 100644 queue-4.4/spi-tegra20-sflash-fix-reference-leak-in-tegra_sflas.patch create mode 100644 queue-4.4/spi-tegra20-slink-fix-reference-leak-in-slink-ops-of.patch create mode 100644 queue-4.4/um-chan_xterm-fix-fd-leak.patch create mode 100644 queue-4.4/usb-ehci-omap-fix-pm-disable-depth-umbalance-in-ehci.patch create mode 100644 queue-4.4/usb-oxu210hp-hcd-fix-memory-leak-in-oxu_create.patch create mode 100644 queue-4.4/x86-kprobes-restore-btf-if-the-single-stepping-is-ca.patch diff --git a/queue-4.4/arm-dts-at91-sama5d3_xplained-add-pincontrol-for-usb.patch b/queue-4.4/arm-dts-at91-sama5d3_xplained-add-pincontrol-for-usb.patch new file mode 100644 index 00000000000..619e98755c3 --- /dev/null +++ b/queue-4.4/arm-dts-at91-sama5d3_xplained-add-pincontrol-for-usb.patch @@ -0,0 +1,51 @@ +From c663c503b12c0270048a08574545016eac4e5827 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 18 Nov 2020 14:00:19 +0200 +Subject: ARM: dts: at91: sama5d3_xplained: add pincontrol for USB Host + +From: Cristian Birsan + +[ Upstream commit e1062fa7292f1e3744db0a487c4ac0109e09b03d ] + +The pincontrol node is needed for USB Host since Linux v5.7-rc1. Without +it the driver probes but VBus is not powered because of wrong pincontrol +configuration. + +Fixes: b7c2b61570798 ("ARM: at91: add Atmel's SAMA5D3 Xplained board") +Signed-off-by: Cristian Birsan +Signed-off-by: Alexandre Belloni +Acked-by: Ludovic Desroches +Link: https://lore.kernel.org/r/20201118120019.1257580-4-cristian.birsan@microchip.com +Signed-off-by: Sasha Levin +--- + arch/arm/boot/dts/at91-sama5d3_xplained.dts | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts +index 0bd325c314e15..2b882d129b16a 100644 +--- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts ++++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts +@@ -231,6 +231,11 @@ + atmel,pins = + ; /* PE9, conflicts with A9 */ + }; ++ pinctrl_usb_default: usb_default { ++ atmel,pins = ++ ; ++ }; + }; + }; + }; +@@ -288,6 +293,8 @@ + &pioE 3 GPIO_ACTIVE_LOW + &pioE 4 GPIO_ACTIVE_LOW + >; ++ pinctrl-names = "default"; ++ pinctrl-0 = <&pinctrl_usb_default>; + status = "okay"; + }; + +-- +2.27.0 + diff --git a/queue-4.4/arm-dts-at91-sama5d4_xplained-add-pincontrol-for-usb.patch b/queue-4.4/arm-dts-at91-sama5d4_xplained-add-pincontrol-for-usb.patch new file mode 100644 index 00000000000..374a8d53c82 --- /dev/null +++ b/queue-4.4/arm-dts-at91-sama5d4_xplained-add-pincontrol-for-usb.patch @@ -0,0 +1,51 @@ +From 04b5f604f2a71b0eef23a2cfceaae27bcd890e20 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 18 Nov 2020 14:00:18 +0200 +Subject: ARM: dts: at91: sama5d4_xplained: add pincontrol for USB Host + +From: Cristian Birsan + +[ Upstream commit be4dd2d448816a27c1446f8f37fce375daf64148 ] + +The pincontrol node is needed for USB Host since Linux v5.7-rc1. Without +it the driver probes but VBus is not powered because of wrong pincontrol +configuration. + +Fixes: 38153a017896f ("ARM: at91/dt: sama5d4: add dts for sama5d4 xplained board") +Signed-off-by: Cristian Birsan +Signed-off-by: Alexandre Belloni +Acked-by: Ludovic Desroches +Link: https://lore.kernel.org/r/20201118120019.1257580-3-cristian.birsan@microchip.com +Signed-off-by: Sasha Levin +--- + arch/arm/boot/dts/at91-sama5d4_xplained.dts | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/arch/arm/boot/dts/at91-sama5d4_xplained.dts b/arch/arm/boot/dts/at91-sama5d4_xplained.dts +index e27024cdf48bd..17adaa1a65c19 100644 +--- a/arch/arm/boot/dts/at91-sama5d4_xplained.dts ++++ b/arch/arm/boot/dts/at91-sama5d4_xplained.dts +@@ -152,6 +152,11 @@ + atmel,pins = + ; + }; ++ pinctrl_usb_default: usb_default { ++ atmel,pins = ++ ; ++ }; + pinctrl_key_gpio: key_gpio_0 { + atmel,pins = + ; +@@ -177,6 +182,8 @@ + &pioE 11 GPIO_ACTIVE_HIGH + &pioE 14 GPIO_ACTIVE_HIGH + >; ++ pinctrl-names = "default"; ++ pinctrl-0 = <&pinctrl_usb_default>; + status = "okay"; + }; + +-- +2.27.0 + diff --git a/queue-4.4/arm-p2v-fix-handling-of-lpae-translation-in-be-mode.patch b/queue-4.4/arm-p2v-fix-handling-of-lpae-translation-in-be-mode.patch new file mode 100644 index 00000000000..3e03660a6f6 --- /dev/null +++ b/queue-4.4/arm-p2v-fix-handling-of-lpae-translation-in-be-mode.patch @@ -0,0 +1,55 @@ +From 3ebfffa9fc0040c17a701bf2129d01b544ba0cd5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 21 Sep 2020 00:10:16 +0200 +Subject: ARM: p2v: fix handling of LPAE translation in BE mode + +From: Ard Biesheuvel + +[ Upstream commit 4e79f0211b473f8e1eab8211a9fd50cc41a3a061 ] + +When running in BE mode on LPAE hardware with a PA-to-VA translation +that exceeds 4 GB, we patch bits 39:32 of the offset into the wrong +byte of the opcode. So fix that, by rotating the offset in r0 to the +right by 8 bits, which will put the 8-bit immediate in bits 31:24. + +Note that this will also move bit #22 in its correct place when +applying the rotation to the constant #0x400000. + +Fixes: d9a790df8e984 ("ARM: 7883/1: fix mov to mvn conversion in case of 64 bit phys_addr_t and BE") +Acked-by: Nicolas Pitre +Reviewed-by: Linus Walleij +Signed-off-by: Ard Biesheuvel +Signed-off-by: Sasha Levin +--- + arch/arm/kernel/head.S | 6 +----- + 1 file changed, 1 insertion(+), 5 deletions(-) + +diff --git a/arch/arm/kernel/head.S b/arch/arm/kernel/head.S +index 04286fd9e09ce..2e336acd68b0a 100644 +--- a/arch/arm/kernel/head.S ++++ b/arch/arm/kernel/head.S +@@ -673,12 +673,8 @@ ARM_BE8(rev16 ip, ip) + ldrcc r7, [r4], #4 @ use branch for delay slot + bcc 1b + bx lr +-#else +-#ifdef CONFIG_CPU_ENDIAN_BE8 +- moveq r0, #0x00004000 @ set bit 22, mov to mvn instruction + #else + moveq r0, #0x400000 @ set bit 22, mov to mvn instruction +-#endif + b 2f + 1: ldr ip, [r7, r3] + #ifdef CONFIG_CPU_ENDIAN_BE8 +@@ -687,7 +683,7 @@ ARM_BE8(rev16 ip, ip) + tst ip, #0x000f0000 @ check the rotation field + orrne ip, ip, r6, lsl #24 @ mask in offset bits 31-24 + biceq ip, ip, #0x00004000 @ clear bit 22 +- orreq ip, ip, r0 @ mask in offset bits 7-0 ++ orreq ip, ip, r0, ror #8 @ mask in offset bits 7-0 + #else + bic ip, ip, #0x000000ff + tst ip, #0xf00 @ check the rotation field +-- +2.27.0 + diff --git a/queue-4.4/asoc-jz4740-i2s-add-missed-checks-for-clk_get.patch b/queue-4.4/asoc-jz4740-i2s-add-missed-checks-for-clk_get.patch new file mode 100644 index 00000000000..1f310a6f5fd --- /dev/null +++ b/queue-4.4/asoc-jz4740-i2s-add-missed-checks-for-clk_get.patch @@ -0,0 +1,44 @@ +From 6faad3063d382362f7dc3c4e76cb6072a7fa6f53 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 3 Dec 2020 22:42:27 +0800 +Subject: ASoC: jz4740-i2s: add missed checks for clk_get() + +From: Chuhong Yuan + +[ Upstream commit 1c1fb2653a0c2e3f310c07eacd8fc3a10e08c97a ] + +jz4740_i2s_set_sysclk() does not check the return values of clk_get(), +while the file dereferences the pointers in clk_put(). +Add the missed checks to fix it. + +Fixes: 11bd3dd1b7c2 ("ASoC: Add JZ4740 ASoC support") +Signed-off-by: Chuhong Yuan +Link: https://lore.kernel.org/r/20201203144227.418194-1-hslester96@gmail.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/jz4740/jz4740-i2s.c | 4 ++++ + 1 file changed, 4 insertions(+) + +diff --git a/sound/soc/jz4740/jz4740-i2s.c b/sound/soc/jz4740/jz4740-i2s.c +index 0dc1ab48fcebe..6440729facaf0 100644 +--- a/sound/soc/jz4740/jz4740-i2s.c ++++ b/sound/soc/jz4740/jz4740-i2s.c +@@ -315,10 +315,14 @@ static int jz4740_i2s_set_sysclk(struct snd_soc_dai *dai, int clk_id, + switch (clk_id) { + case JZ4740_I2S_CLKSRC_EXT: + parent = clk_get(NULL, "ext"); ++ if (IS_ERR(parent)) ++ return PTR_ERR(parent); + clk_set_parent(i2s->clk_i2s, parent); + break; + case JZ4740_I2S_CLKSRC_PLL: + parent = clk_get(NULL, "pll half"); ++ if (IS_ERR(parent)) ++ return PTR_ERR(parent); + clk_set_parent(i2s->clk_i2s, parent); + ret = clk_set_rate(i2s->clk_i2s, freq); + break; +-- +2.27.0 + diff --git a/queue-4.4/asoc-pcm-drain-support-reactivation.patch b/queue-4.4/asoc-pcm-drain-support-reactivation.patch new file mode 100644 index 00000000000..189fdda8517 --- /dev/null +++ b/queue-4.4/asoc-pcm-drain-support-reactivation.patch @@ -0,0 +1,51 @@ +From 03f79881bf498877073d63368bbd9aa81cca6e15 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 26 Oct 2020 11:01:29 +0100 +Subject: ASoC: pcm: DRAIN support reactivation + +From: Cezary Rojewski + +[ Upstream commit 4c22b80f61540ea99d9b4af0127315338755f05b ] + +soc-pcm's dpcm_fe_dai_do_trigger() supported DRAIN commnad up to kernel +v5.4 where explicit switch(cmd) has been introduced which takes into +account all SNDRV_PCM_TRIGGER_xxx but SNDRV_PCM_TRIGGER_DRAIN. Update +switch statement to reactive support for it. + +As DRAIN is somewhat unique by lacking negative/stop counterpart, bring +behaviour of dpcm_fe_dai_do_trigger() for said command back to its +pre-v5.4 state by adding it to START/RESUME/PAUSE_RELEASE group. + +Fixes: acbf27746ecf ("ASoC: pcm: update FE/BE trigger order based on the command") +Signed-off-by: Cezary Rojewski +Reviewed-by: Ranjani Sridharan +Link: https://lore.kernel.org/r/20201026100129.8216-1-cezary.rojewski@intel.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/soc-pcm.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c +index d4bf3dc6b0158..b773d61cd5bc7 100644 +--- a/sound/soc/soc-pcm.c ++++ b/sound/soc/soc-pcm.c +@@ -2075,6 +2075,7 @@ static int dpcm_fe_dai_do_trigger(struct snd_pcm_substream *substream, int cmd) + case SNDRV_PCM_TRIGGER_START: + case SNDRV_PCM_TRIGGER_RESUME: + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: ++ case SNDRV_PCM_TRIGGER_DRAIN: + ret = dpcm_dai_trigger_fe_be(substream, cmd, true); + break; + case SNDRV_PCM_TRIGGER_STOP: +@@ -2092,6 +2093,7 @@ static int dpcm_fe_dai_do_trigger(struct snd_pcm_substream *substream, int cmd) + case SNDRV_PCM_TRIGGER_START: + case SNDRV_PCM_TRIGGER_RESUME: + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE: ++ case SNDRV_PCM_TRIGGER_DRAIN: + ret = dpcm_dai_trigger_fe_be(substream, cmd, false); + break; + case SNDRV_PCM_TRIGGER_STOP: +-- +2.27.0 + diff --git a/queue-4.4/asoc-wm_adsp-remove-ctl-from-list-on-error-in-wm_ads.patch b/queue-4.4/asoc-wm_adsp-remove-ctl-from-list-on-error-in-wm_ads.patch new file mode 100644 index 00000000000..15a79ba9a35 --- /dev/null +++ b/queue-4.4/asoc-wm_adsp-remove-ctl-from-list-on-error-in-wm_ads.patch @@ -0,0 +1,50 @@ +From 92e1c03d71e6767f0594cddae469f8a53acc5c8f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 9 Dec 2020 09:54:09 +0300 +Subject: ASoC: wm_adsp: remove "ctl" from list on error in + wm_adsp_create_control() + +From: Dan Carpenter + +[ Upstream commit 85a7555575a0e48f9b73db310d0d762a08a46d63 ] + +The error handling frees "ctl" but it's still on the "dsp->ctl_list" +list so that could result in a use after free. Remove it from the list +before returning. + +Fixes: 2323736dca72 ("ASoC: wm_adsp: Add basic support for rev 1 firmware file format") +Signed-off-by: Dan Carpenter +Acked-by: Charles Keepax +Link: https://lore.kernel.org/r/X9B0keV/02wrx9Xs@mwanda +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + sound/soc/codecs/wm_adsp.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c +index f1f990b325ad7..5ff0d3b10bcfd 100644 +--- a/sound/soc/codecs/wm_adsp.c ++++ b/sound/soc/codecs/wm_adsp.c +@@ -852,7 +852,7 @@ static int wm_adsp_create_control(struct wm_adsp *dsp, + ctl_work = kzalloc(sizeof(*ctl_work), GFP_KERNEL); + if (!ctl_work) { + ret = -ENOMEM; +- goto err_ctl_cache; ++ goto err_list_del; + } + + ctl_work->dsp = dsp; +@@ -862,7 +862,8 @@ static int wm_adsp_create_control(struct wm_adsp *dsp, + + return 0; + +-err_ctl_cache: ++err_list_del: ++ list_del(&ctl->list); + kfree(ctl->cache); + err_ctl_name: + kfree(ctl->name); +-- +2.27.0 + diff --git a/queue-4.4/bluetooth-fix-null-pointer-dereference-in-hci_event_.patch b/queue-4.4/bluetooth-fix-null-pointer-dereference-in-hci_event_.patch new file mode 100644 index 00000000000..a9f141c532b --- /dev/null +++ b/queue-4.4/bluetooth-fix-null-pointer-dereference-in-hci_event_.patch @@ -0,0 +1,49 @@ +From 6188b76a0c8e2def7c2ccef7f7e00dc7ff84b8b0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 30 Sep 2020 19:48:13 +0530 +Subject: Bluetooth: Fix null pointer dereference in hci_event_packet() + +From: Anmol Karn + +[ Upstream commit 6dfccd13db2ff2b709ef60a50163925d477549aa ] + +AMP_MGR is getting derefernced in hci_phy_link_complete_evt(), when called +from hci_event_packet() and there is a possibility, that hcon->amp_mgr may +not be found when accessing after initialization of hcon. + +- net/bluetooth/hci_event.c:4945 +The bug seems to get triggered in this line: + +bredr_hcon = hcon->amp_mgr->l2cap_conn->hcon; + +Fix it by adding a NULL check for the hcon->amp_mgr before checking the ev-status. + +Fixes: d5e911928bd8 ("Bluetooth: AMP: Process Physical Link Complete evt") +Reported-and-tested-by: syzbot+0bef568258653cff272f@syzkaller.appspotmail.com +Link: https://syzkaller.appspot.com/bug?extid=0bef568258653cff272f +Signed-off-by: Anmol Karn +Signed-off-by: Marcel Holtmann +Signed-off-by: Sasha Levin +--- + net/bluetooth/hci_event.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c +index 70a73e7dbf161..586c005bdc1ee 100644 +--- a/net/bluetooth/hci_event.c ++++ b/net/bluetooth/hci_event.c +@@ -4336,6 +4336,11 @@ static void hci_phy_link_complete_evt(struct hci_dev *hdev, + return; + } + ++ if (!hcon->amp_mgr) { ++ hci_dev_unlock(hdev); ++ return; ++ } ++ + if (ev->status) { + hci_conn_del(hcon); + hci_dev_unlock(hdev); +-- +2.27.0 + diff --git a/queue-4.4/cfg80211-initialize-rekey_data.patch b/queue-4.4/cfg80211-initialize-rekey_data.patch new file mode 100644 index 00000000000..34e0e50e6e2 --- /dev/null +++ b/queue-4.4/cfg80211-initialize-rekey_data.patch @@ -0,0 +1,36 @@ +From ccbc2e1339b6efce609d18206b979b0a40e6fea6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 29 Nov 2020 17:30:44 +0200 +Subject: cfg80211: initialize rekey_data + +From: Sara Sharon + +[ Upstream commit f495acd8851d7b345e5f0e521b2645b1e1f928a0 ] + +In case we have old supplicant, the akm field is uninitialized. + +Signed-off-by: Sara Sharon +Signed-off-by: Luca Coelho +Link: https://lore.kernel.org/r/iwlwifi.20201129172929.930f0ab7ebee.Ic546e384efab3f4a89f318eafddc3eb7d556aecb@changeid +Signed-off-by: Johannes Berg +Signed-off-by: Sasha Levin +--- + net/wireless/nl80211.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c +index 7748d674677c9..eb25998a0032e 100644 +--- a/net/wireless/nl80211.c ++++ b/net/wireless/nl80211.c +@@ -9836,7 +9836,7 @@ static int nl80211_set_rekey_data(struct sk_buff *skb, struct genl_info *info) + struct net_device *dev = info->user_ptr[1]; + struct wireless_dev *wdev = dev->ieee80211_ptr; + struct nlattr *tb[NUM_NL80211_REKEY_DATA]; +- struct cfg80211_gtk_rekey_data rekey_data; ++ struct cfg80211_gtk_rekey_data rekey_data = {}; + int err; + + if (!info->attrs[NL80211_ATTR_REKEY_DATA]) +-- +2.27.0 + diff --git a/queue-4.4/checkpatch-fix-unescaped-left-brace.patch b/queue-4.4/checkpatch-fix-unescaped-left-brace.patch new file mode 100644 index 00000000000..24cdbbb0387 --- /dev/null +++ b/queue-4.4/checkpatch-fix-unescaped-left-brace.patch @@ -0,0 +1,42 @@ +From d95e9124114a37788f45df831eca15582dd156aa Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 15 Dec 2020 20:45:02 -0800 +Subject: checkpatch: fix unescaped left brace + +From: Dwaipayan Ray + +[ Upstream commit 03f4935135b9efeb780b970ba023c201f81cf4e6 ] + +There is an unescaped left brace in a regex in OPEN_BRACE check. This +throws a runtime error when checkpatch is run with --fix flag and the +OPEN_BRACE check is executed. + +Fix it by escaping the left brace. + +Link: https://lkml.kernel.org/r/20201115202928.81955-1-dwaipayanray1@gmail.com +Fixes: 8d1824780f2f ("checkpatch: add --fix option for a couple OPEN_BRACE misuses") +Signed-off-by: Dwaipayan Ray +Acked-by: Joe Perches +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Sasha Levin +--- + scripts/checkpatch.pl | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl +index 8835a4775d205..67a6a8a9b6722 100755 +--- a/scripts/checkpatch.pl ++++ b/scripts/checkpatch.pl +@@ -3580,7 +3580,7 @@ sub process { + $fix) { + fix_delete_line($fixlinenr, $rawline); + my $fixed_line = $rawline; +- $fixed_line =~ /(^..*$Type\s*$Ident\(.*\)\s*){(.*)$/; ++ $fixed_line =~ /(^..*$Type\s*$Ident\(.*\)\s*)\{(.*)$/; + my $line1 = $1; + my $line2 = $2; + fix_insert_line($fixlinenr, ltrim($line1)); +-- +2.27.0 + diff --git a/queue-4.4/clk-s2mps11-fix-a-resource-leak-in-error-handling-pa.patch b/queue-4.4/clk-s2mps11-fix-a-resource-leak-in-error-handling-pa.patch new file mode 100644 index 00000000000..7c7291c13d4 --- /dev/null +++ b/queue-4.4/clk-s2mps11-fix-a-resource-leak-in-error-handling-pa.patch @@ -0,0 +1,41 @@ +From 1cc3e0875feb0801b3eb7667a510d40a49bd21e0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 12 Dec 2020 13:28:18 +0100 +Subject: clk: s2mps11: Fix a resource leak in error handling paths in the + probe function + +From: Christophe JAILLET + +[ Upstream commit d2d94fc567624f96187e8b52083795620f93e69f ] + +Some resource should be released in the error handling path of the probe +function, as already done in the remove function. + +The remove function was fixed in commit bf416bd45738 ("clk: s2mps11: Add +missing of_node_put and of_clk_del_provider") + +Fixes: 7cc560dea415 ("clk: s2mps11: Add support for s2mps11") +Signed-off-by: Christophe JAILLET +Link: https://lore.kernel.org/r/20201212122818.86195-1-christophe.jaillet@wanadoo.fr +Reviewed-by: Krzysztof Kozlowski +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/clk-s2mps11.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c +index 14af5c916c9ca..8a42a9c2a8f28 100644 +--- a/drivers/clk/clk-s2mps11.c ++++ b/drivers/clk/clk-s2mps11.c +@@ -263,6 +263,7 @@ static int s2mps11_clk_probe(struct platform_device *pdev) + return ret; + + err_reg: ++ of_node_put(s2mps11_clks[0].clk_np); + while (--i >= 0) + clkdev_drop(s2mps11_clks[i].lookup); + +-- +2.27.0 + diff --git a/queue-4.4/clk-ti-fix-memleak-in-ti_fapll_synth_setup.patch b/queue-4.4/clk-ti-fix-memleak-in-ti_fapll_synth_setup.patch new file mode 100644 index 00000000000..e348186cfb5 --- /dev/null +++ b/queue-4.4/clk-ti-fix-memleak-in-ti_fapll_synth_setup.patch @@ -0,0 +1,60 @@ +From 89e0e20b7b4b19d0386608356eb49cec150f525f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 13 Nov 2020 21:16:23 +0800 +Subject: clk: ti: Fix memleak in ti_fapll_synth_setup + +From: Zhang Qilong + +[ Upstream commit 8c6239f6e95f583bb763d0228e02d4dd0fb3d492 ] + +If clk_register fails, we should goto free branch +before function returns to prevent memleak. + +Fixes: 163152cbbe321 ("clk: ti: Add support for FAPLL on dm816x") +Reported-by: Hulk Robot +Signed-off-by: Zhang Qilong +Link: https://lore.kernel.org/r/20201113131623.2098222-1-zhangqilong3@huawei.com +Acked-by: Tony Lindgren +Signed-off-by: Stephen Boyd +Signed-off-by: Sasha Levin +--- + drivers/clk/ti/fapll.c | 11 +++++++++-- + 1 file changed, 9 insertions(+), 2 deletions(-) + +diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c +index 66a0d0ed8b550..02ff499e36536 100644 +--- a/drivers/clk/ti/fapll.c ++++ b/drivers/clk/ti/fapll.c +@@ -497,6 +497,7 @@ static struct clk * __init ti_fapll_synth_setup(struct fapll_data *fd, + { + struct clk_init_data *init; + struct fapll_synth *synth; ++ struct clk *clk = ERR_PTR(-ENOMEM); + + init = kzalloc(sizeof(*init), GFP_KERNEL); + if (!init) +@@ -519,13 +520,19 @@ static struct clk * __init ti_fapll_synth_setup(struct fapll_data *fd, + synth->hw.init = init; + synth->clk_pll = pll_clk; + +- return clk_register(NULL, &synth->hw); ++ clk = clk_register(NULL, &synth->hw); ++ if (IS_ERR(clk)) { ++ pr_err("failed to register clock\n"); ++ goto free; ++ } ++ ++ return clk; + + free: + kfree(synth); + kfree(init); + +- return ERR_PTR(-ENOMEM); ++ return clk; + } + + static void __init ti_fapll_setup(struct device_node *node) +-- +2.27.0 + diff --git a/queue-4.4/clocksource-drivers-arm_arch_timer-correct-fault-pro.patch b/queue-4.4/clocksource-drivers-arm_arch_timer-correct-fault-pro.patch new file mode 100644 index 00000000000..45489c686b9 --- /dev/null +++ b/queue-4.4/clocksource-drivers-arm_arch_timer-correct-fault-pro.patch @@ -0,0 +1,70 @@ +From b9784c65b76c1fcd3befae397f1107091b5bb79c Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 4 Dec 2020 15:31:26 +0800 +Subject: clocksource/drivers/arm_arch_timer: Correct fault programming of + CNTKCTL_EL1.EVNTI + +From: Keqian Zhu + +[ Upstream commit 8b7770b877d187bfdae1eaf587bd2b792479a31c ] + +ARM virtual counter supports event stream, it can only trigger an event +when the trigger bit (the value of CNTKCTL_EL1.EVNTI) of CNTVCT_EL0 changes, +so the actual period of event stream is 2^(cntkctl_evnti + 1). For example, +when the trigger bit is 0, then virtual counter trigger an event for every +two cycles. + +While we're at it, rework the way we compute the trigger bit position +by making it more obvious that when bits [n:n-1] are both set (with n +being the most significant bit), we pick bit (n + 1). + +Fixes: 037f637767a8 ("drivers: clocksource: add support for ARM architected timer event stream") +Suggested-by: Marc Zyngier +Signed-off-by: Keqian Zhu +Acked-by: Marc Zyngier +Signed-off-by: Daniel Lezcano +Link: https://lore.kernel.org/r/20201204073126.6920-3-zhukeqian1@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/clocksource/arm_arch_timer.c | 23 ++++++++++++++++------- + 1 file changed, 16 insertions(+), 7 deletions(-) + +diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c +index c64d543d64bf6..4e303c77caed5 100644 +--- a/drivers/clocksource/arm_arch_timer.c ++++ b/drivers/clocksource/arm_arch_timer.c +@@ -310,15 +310,24 @@ static void arch_timer_evtstrm_enable(int divider) + + static void arch_timer_configure_evtstream(void) + { +- int evt_stream_div, pos; ++ int evt_stream_div, lsb; ++ ++ /* ++ * As the event stream can at most be generated at half the frequency ++ * of the counter, use half the frequency when computing the divider. ++ */ ++ evt_stream_div = arch_timer_rate / ARCH_TIMER_EVT_STREAM_FREQ / 2; ++ ++ /* ++ * Find the closest power of two to the divisor. If the adjacent bit ++ * of lsb (last set bit, starts from 0) is set, then we use (lsb + 1). ++ */ ++ lsb = fls(evt_stream_div) - 1; ++ if (lsb > 0 && (evt_stream_div & BIT(lsb - 1))) ++ lsb++; + +- /* Find the closest power of two to the divisor */ +- evt_stream_div = arch_timer_rate / ARCH_TIMER_EVT_STREAM_FREQ; +- pos = fls(evt_stream_div); +- if (pos > 1 && !(evt_stream_div & (1 << (pos - 2)))) +- pos--; + /* enable event stream */ +- arch_timer_evtstrm_enable(min(pos, 15)); ++ arch_timer_evtstrm_enable(max(0, min(lsb, 15))); + } + + static void arch_counter_set_user_access(void) +-- +2.27.0 + diff --git a/queue-4.4/cpufreq-highbank-add-missing-module_device_table.patch b/queue-4.4/cpufreq-highbank-add-missing-module_device_table.patch new file mode 100644 index 00000000000..06c8cb3b46c --- /dev/null +++ b/queue-4.4/cpufreq-highbank-add-missing-module_device_table.patch @@ -0,0 +1,45 @@ +From 1a3b3cc98c87037ebe7c17593363b42a26c73060 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 16:11:32 +0100 +Subject: cpufreq: highbank: Add missing MODULE_DEVICE_TABLE +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Pali Rohár + +[ Upstream commit 9433777a6e0aae27468d3434b75cd51bb88ff711 ] + +This patch adds missing MODULE_DEVICE_TABLE definition which generates +correct modalias for automatic loading of this cpufreq driver when it is +compiled as an external module. + +Signed-off-by: Pali Rohár +Fixes: 6754f556103be ("cpufreq / highbank: add support for highbank cpufreq") +Signed-off-by: Viresh Kumar +Signed-off-by: Sasha Levin +--- + drivers/cpufreq/highbank-cpufreq.c | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/drivers/cpufreq/highbank-cpufreq.c b/drivers/cpufreq/highbank-cpufreq.c +index 1608f7105c9f8..ad743f2f31e78 100644 +--- a/drivers/cpufreq/highbank-cpufreq.c ++++ b/drivers/cpufreq/highbank-cpufreq.c +@@ -104,6 +104,13 @@ out_put_node: + } + module_init(hb_cpufreq_driver_init); + ++static const struct of_device_id __maybe_unused hb_cpufreq_of_match[] = { ++ { .compatible = "calxeda,highbank" }, ++ { .compatible = "calxeda,ecx-2000" }, ++ { }, ++}; ++MODULE_DEVICE_TABLE(of, hb_cpufreq_of_match); ++ + MODULE_AUTHOR("Mark Langsdorf "); + MODULE_DESCRIPTION("Calxeda Highbank cpufreq driver"); + MODULE_LICENSE("GPL"); +-- +2.27.0 + diff --git a/queue-4.4/cpufreq-loongson1-add-missing-module_alias.patch b/queue-4.4/cpufreq-loongson1-add-missing-module_alias.patch new file mode 100644 index 00000000000..2768082e853 --- /dev/null +++ b/queue-4.4/cpufreq-loongson1-add-missing-module_alias.patch @@ -0,0 +1,38 @@ +From 8ffb971adcb10908f8762c103eafe1d8cb29116b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 16:11:37 +0100 +Subject: cpufreq: loongson1: Add missing MODULE_ALIAS +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Pali Rohár + +[ Upstream commit b9acab091842ca8b288882798bb809f7abf5408a ] + +This patch adds missing MODULE_ALIAS for automatic loading of this cpufreq +driver when it is compiled as an external module. + +Signed-off-by: Pali Rohár +Fixes: a0a22cf14472f ("cpufreq: Loongson1: Add cpufreq driver for Loongson1B") +Signed-off-by: Viresh Kumar +Signed-off-by: Sasha Levin +--- + drivers/cpufreq/ls1x-cpufreq.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/cpufreq/ls1x-cpufreq.c b/drivers/cpufreq/ls1x-cpufreq.c +index 262581b3318d7..367cb1615c30d 100644 +--- a/drivers/cpufreq/ls1x-cpufreq.c ++++ b/drivers/cpufreq/ls1x-cpufreq.c +@@ -217,6 +217,7 @@ static struct platform_driver ls1x_cpufreq_platdrv = { + + module_platform_driver(ls1x_cpufreq_platdrv); + ++MODULE_ALIAS("platform:ls1x-cpufreq"); + MODULE_AUTHOR("Kelvin Cheung "); + MODULE_DESCRIPTION("Loongson 1 CPUFreq driver"); + MODULE_LICENSE("GPL"); +-- +2.27.0 + diff --git a/queue-4.4/cpufreq-scpi-add-missing-module_alias.patch b/queue-4.4/cpufreq-scpi-add-missing-module_alias.patch new file mode 100644 index 00000000000..854046d4f1a --- /dev/null +++ b/queue-4.4/cpufreq-scpi-add-missing-module_alias.patch @@ -0,0 +1,38 @@ +From 8bdc284e34fd941658157e2f15286052fccc132b Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 16:11:38 +0100 +Subject: cpufreq: scpi: Add missing MODULE_ALIAS +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Pali Rohár + +[ Upstream commit c0382d049d2def37b81e907a8b22661a4a4a6eb5 ] + +This patch adds missing MODULE_ALIAS for automatic loading of this cpufreq +driver when it is compiled as an external module. + +Signed-off-by: Pali Rohár +Fixes: 8def31034d033 ("cpufreq: arm_big_little: add SCPI interface driver") +Signed-off-by: Viresh Kumar +Signed-off-by: Sasha Levin +--- + drivers/cpufreq/scpi-cpufreq.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c +index de5e89b2eaaa3..98f762cca9010 100644 +--- a/drivers/cpufreq/scpi-cpufreq.c ++++ b/drivers/cpufreq/scpi-cpufreq.c +@@ -119,6 +119,7 @@ static struct platform_driver scpi_cpufreq_platdrv = { + }; + module_platform_driver(scpi_cpufreq_platdrv); + ++MODULE_ALIAS("platform:scpi-cpufreq"); + MODULE_AUTHOR("Sudeep Holla "); + MODULE_DESCRIPTION("ARM SCPI CPUFreq interface driver"); + MODULE_LICENSE("GPL v2"); +-- +2.27.0 + diff --git a/queue-4.4/crypto-talitos-fix-return-type-of-current_desc_hdr.patch b/queue-4.4/crypto-talitos-fix-return-type-of-current_desc_hdr.patch new file mode 100644 index 00000000000..43c2c18a8ca --- /dev/null +++ b/queue-4.4/crypto-talitos-fix-return-type-of-current_desc_hdr.patch @@ -0,0 +1,55 @@ +From 8efe2fd82746632145f56608d6d7840b1b1709fd Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 8 Oct 2020 09:34:56 +0000 +Subject: crypto: talitos - Fix return type of current_desc_hdr() + +From: Christophe Leroy + +[ Upstream commit 0237616173fd363a54bd272aa3bd376faa1d7caa ] + +current_desc_hdr() returns a u32 but in fact this is a __be32, +leading to a lot of sparse warnings. + +Change the return type to __be32 and ensure it is handled as +sure by the caller. + +Fixes: 3e721aeb3df3 ("crypto: talitos - handle descriptor not found in error path") +Signed-off-by: Christophe Leroy +Signed-off-by: Herbert Xu +Signed-off-by: Sasha Levin +--- + drivers/crypto/talitos.c | 6 +++--- + 1 file changed, 3 insertions(+), 3 deletions(-) + +diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c +index 1c8857e7db894..cfefa18bca28b 100644 +--- a/drivers/crypto/talitos.c ++++ b/drivers/crypto/talitos.c +@@ -440,7 +440,7 @@ DEF_TALITOS2_DONE(ch1_3, TALITOS2_ISR_CH_1_3_DONE) + /* + * locate current (offending) descriptor + */ +-static u32 current_desc_hdr(struct device *dev, int ch) ++static __be32 current_desc_hdr(struct device *dev, int ch) + { + struct talitos_private *priv = dev_get_drvdata(dev); + int tail, iter; +@@ -471,13 +471,13 @@ static u32 current_desc_hdr(struct device *dev, int ch) + /* + * user diagnostics; report root cause of error based on execution unit status + */ +-static void report_eu_error(struct device *dev, int ch, u32 desc_hdr) ++static void report_eu_error(struct device *dev, int ch, __be32 desc_hdr) + { + struct talitos_private *priv = dev_get_drvdata(dev); + int i; + + if (!desc_hdr) +- desc_hdr = in_be32(priv->chan[ch].reg + TALITOS_DESCBUF); ++ desc_hdr = cpu_to_be32(in_be32(priv->chan[ch].reg + TALITOS_DESCBUF)); + + switch (desc_hdr & DESC_HDR_SEL0_MASK) { + case DESC_HDR_SEL0_AFEU: +-- +2.27.0 + diff --git a/queue-4.4/cw1200-fix-missing-destroy_workqueue-on-error-in-cw1.patch b/queue-4.4/cw1200-fix-missing-destroy_workqueue-on-error-in-cw1.patch new file mode 100644 index 00000000000..9de35468a1b --- /dev/null +++ b/queue-4.4/cw1200-fix-missing-destroy_workqueue-on-error-in-cw1.patch @@ -0,0 +1,46 @@ +From 5c08fc1a1399416f3095a0d41ef77fbd5b334428 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 19 Nov 2020 15:08:42 +0800 +Subject: cw1200: fix missing destroy_workqueue() on error in + cw1200_init_common + +From: Qinglang Miao + +[ Upstream commit 7ec8a926188eb8e7a3cbaca43ec44f2d7146d71b ] + +Add the missing destroy_workqueue() before return from +cw1200_init_common in the error handling case. + +Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") +Reported-by: Hulk Robot +Signed-off-by: Qinglang Miao +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20201119070842.1011-1-miaoqinglang@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/cw1200/main.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/net/wireless/cw1200/main.c b/drivers/net/wireless/cw1200/main.c +index 317daa968e037..057725b06f640 100644 +--- a/drivers/net/wireless/cw1200/main.c ++++ b/drivers/net/wireless/cw1200/main.c +@@ -385,6 +385,7 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr, + CW1200_LINK_ID_MAX, + cw1200_skb_dtor, + priv)) { ++ destroy_workqueue(priv->workqueue); + ieee80211_free_hw(hw); + return NULL; + } +@@ -396,6 +397,7 @@ static struct ieee80211_hw *cw1200_init_common(const u8 *macaddr, + for (; i > 0; i--) + cw1200_queue_deinit(&priv->tx_queue[i - 1]); + cw1200_queue_stats_deinit(&priv->tx_queue_stats); ++ destroy_workqueue(priv->workqueue); + ieee80211_free_hw(hw); + return NULL; + } +-- +2.27.0 + diff --git a/queue-4.4/dm-ioctl-fix-error-return-code-in-target_message.patch b/queue-4.4/dm-ioctl-fix-error-return-code-in-target_message.patch new file mode 100644 index 00000000000..6ed7bfc4379 --- /dev/null +++ b/queue-4.4/dm-ioctl-fix-error-return-code-in-target_message.patch @@ -0,0 +1,36 @@ +From 929c2d33ff3b6a93e673280200e0457feef32e67 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 28 Nov 2020 18:19:59 +0800 +Subject: dm ioctl: fix error return code in target_message + +From: Qinglang Miao + +[ Upstream commit 4d7659bfbe277a43399a4a2d90fca141e70f29e1 ] + +Fix to return a negative error code from the error handling +case instead of 0, as done elsewhere in this function. + +Fixes: 2ca4c92f58f9 ("dm ioctl: prevent empty message") +Reported-by: Hulk Robot +Signed-off-by: Qinglang Miao +Signed-off-by: Mike Snitzer +Signed-off-by: Sasha Levin +--- + drivers/md/dm-ioctl.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c +index 9371194677dc3..eab3f7325e310 100644 +--- a/drivers/md/dm-ioctl.c ++++ b/drivers/md/dm-ioctl.c +@@ -1539,6 +1539,7 @@ static int target_message(struct dm_ioctl *param, size_t param_size) + + if (!argc) { + DMWARN("Empty message received."); ++ r = -EINVAL; + goto out_argv; + } + +-- +2.27.0 + diff --git a/queue-4.4/drivers-soc-ti-knav_qmss_queue-fix-error-return-code.patch b/queue-4.4/drivers-soc-ti-knav_qmss_queue-fix-error-return-code.patch new file mode 100644 index 00000000000..96765849b8a --- /dev/null +++ b/queue-4.4/drivers-soc-ti-knav_qmss_queue-fix-error-return-code.patch @@ -0,0 +1,41 @@ +From b4d672e22967921d2c9556098b84a04f5a0da6ec Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 21 Nov 2020 19:22:38 -0800 +Subject: drivers: soc: ti: knav_qmss_queue: Fix error return code in + knav_queue_probe + +From: Zhihao Cheng + +[ Upstream commit 4cba398f37f868f515ff12868418dc28574853a1 ] + +Fix to return the error code from of_get_child_by_name() instaed of 0 +in knav_queue_probe(). + +Fixes: 41f93af900a20d1a0a ("soc: ti: add Keystone Navigator QMSS driver") +Reported-by: Hulk Robot +Signed-off-by: Zhihao Cheng +Signed-off-by: Santosh Shilimkar +Signed-off-by: Sasha Levin +--- + drivers/soc/ti/knav_qmss_queue.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c +index 3a3bc8ef532a7..1aff6659655e3 100644 +--- a/drivers/soc/ti/knav_qmss_queue.c ++++ b/drivers/soc/ti/knav_qmss_queue.c +@@ -1785,9 +1785,10 @@ static int knav_queue_probe(struct platform_device *pdev) + if (ret) + goto err; + +- regions = of_get_child_by_name(node, "descriptor-regions"); ++ regions = of_get_child_by_name(node, "descriptor-regions"); + if (!regions) { + dev_err(dev, "descriptor-regions not specified\n"); ++ ret = -ENODEV; + goto err; + } + ret = knav_queue_setup_regions(kdev, regions); +-- +2.27.0 + diff --git a/queue-4.4/drm-gma500-fix-double-free-of-gma_connector.patch b/queue-4.4/drm-gma500-fix-double-free-of-gma_connector.patch new file mode 100644 index 00000000000..d3a9325c259 --- /dev/null +++ b/queue-4.4/drm-gma500-fix-double-free-of-gma_connector.patch @@ -0,0 +1,45 @@ +From 037ff6b0f2d33d92cf667051209e90dca5058ce5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 3 Oct 2020 12:39:28 -0700 +Subject: drm/gma500: fix double free of gma_connector + +From: Tom Rix + +[ Upstream commit 4e19d51ca5b28a1d435a844c7b2a8e1b1b6fa237 ] + +clang static analysis reports this problem: + +cdv_intel_dp.c:2101:2: warning: Attempt to free released memory + kfree(gma_connector); + ^~~~~~~~~~~~~~~~~~~~ + +In cdv_intel_dp_init() when the call to cdv_intel_edp_panel_vdd_off() +fails, the handler calls cdv_intel_dp_destroy(connector) which does +the first free of gma_connector. So adjust the goto label and skip +the second free. + +Fixes: d112a8163f83 ("gma500/cdv: Add eDP support") +Signed-off-by: Tom Rix +Signed-off-by: Daniel Vetter +Link: https://patchwork.freedesktop.org/patch/msgid/20201003193928.18869-1-trix@redhat.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/gma500/cdv_intel_dp.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500/cdv_intel_dp.c +index 25c68e4dc7a53..e465d71272584 100644 +--- a/drivers/gpu/drm/gma500/cdv_intel_dp.c ++++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c +@@ -2125,7 +2125,7 @@ cdv_intel_dp_init(struct drm_device *dev, struct psb_intel_mode_device *mode_dev + DRM_INFO("failed to retrieve link info, disabling eDP\n"); + cdv_intel_dp_encoder_destroy(encoder); + cdv_intel_dp_destroy(connector); +- goto err_priv; ++ goto err_connector; + } else { + DRM_DEBUG_KMS("DPCD: Rev=%x LN_Rate=%x LN_CNT=%x LN_DOWNSP=%x\n", + intel_dp->dpcd[0], intel_dp->dpcd[1], +-- +2.27.0 + diff --git a/queue-4.4/drm-omap-dmm_tiler-fix-return-error-code-in-omap_dmm.patch b/queue-4.4/drm-omap-dmm_tiler-fix-return-error-code-in-omap_dmm.patch new file mode 100644 index 00000000000..1407150410b --- /dev/null +++ b/queue-4.4/drm-omap-dmm_tiler-fix-return-error-code-in-omap_dmm.patch @@ -0,0 +1,36 @@ +From 351dbb661ecfeccb68a741cc8de4ec65eb8cbbda Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 17 Nov 2020 14:10:45 +0800 +Subject: drm/omap: dmm_tiler: fix return error code in omap_dmm_probe() + +From: Yang Yingliang + +[ Upstream commit 723ae803218da993143387bf966042eccefac077 ] + +Return -ENOMEM when allocating refill memory failed. + +Fixes: 71e8831f6407 ("drm/omap: DMM/TILER support for OMAP4+ platform") +Reported-by: Hulk Robot +Signed-off-by: Yang Yingliang +Signed-off-by: Thomas Zimmermann +Link: https://patchwork.freedesktop.org/patch/msgid/20201117061045.3452287-1-yangyingliang@huawei.com +Signed-off-by: Sasha Levin +--- + drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +index 8282ae0c4fc3e..bed6862798825 100644 +--- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c ++++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c +@@ -720,6 +720,7 @@ static int omap_dmm_probe(struct platform_device *dev) + &omap_dmm->refill_pa, GFP_KERNEL); + if (!omap_dmm->refill_va) { + dev_err(&dev->dev, "could not allocate refill memory\n"); ++ ret = -ENOMEM; + goto fail; + } + +-- +2.27.0 + diff --git a/queue-4.4/extcon-max77693-fix-modalias-string.patch b/queue-4.4/extcon-max77693-fix-modalias-string.patch new file mode 100644 index 00000000000..ac7672b12aa --- /dev/null +++ b/queue-4.4/extcon-max77693-fix-modalias-string.patch @@ -0,0 +1,34 @@ +From 794fdf8ba516c7bc418beb4fb494e9faa521f4ea Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 8 Dec 2020 14:36:27 +0100 +Subject: extcon: max77693: Fix modalias string + +From: Marek Szyprowski + +[ Upstream commit e1efdb604f5c9903a5d92ef42244009d3c04880f ] + +The platform device driver name is "max77693-muic", so advertise it +properly in the modalias string. This fixes automated module loading when +this driver is compiled as a module. + +Fixes: db1b9037424b ("extcon: MAX77693: Add extcon-max77693 driver to support Maxim MAX77693 MUIC device") +Signed-off-by: Marek Szyprowski +Signed-off-by: Chanwoo Choi +Signed-off-by: Sasha Levin +--- + drivers/extcon/extcon-max77693.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/extcon/extcon-max77693.c b/drivers/extcon/extcon-max77693.c +index 44c499e1beeed..02b3feb76ca99 100644 +--- a/drivers/extcon/extcon-max77693.c ++++ b/drivers/extcon/extcon-max77693.c +@@ -1262,4 +1262,4 @@ module_platform_driver(max77693_muic_driver); + MODULE_DESCRIPTION("Maxim MAX77693 Extcon driver"); + MODULE_AUTHOR("Chanwoo Choi "); + MODULE_LICENSE("GPL"); +-MODULE_ALIAS("platform:extcon-max77693"); ++MODULE_ALIAS("platform:max77693-muic"); +-- +2.27.0 + diff --git a/queue-4.4/input-ads7846-fix-integer-overflow-on-rt-calculation.patch b/queue-4.4/input-ads7846-fix-integer-overflow-on-rt-calculation.patch new file mode 100644 index 00000000000..4a881f4488c --- /dev/null +++ b/queue-4.4/input-ads7846-fix-integer-overflow-on-rt-calculation.patch @@ -0,0 +1,52 @@ +From 97aecf84b43e65a12e3a4eb7c96a997ca7307cdb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 17 Nov 2020 15:33:24 -0800 +Subject: Input: ads7846 - fix integer overflow on Rt calculation + +From: Oleksij Rempel + +[ Upstream commit 820830ec918f6c3dcd77a54a1c6198ab57407916 ] + +In some rare cases the 32 bit Rt value will overflow if z2 and x is max, +z1 is minimal value and x_plate_ohms is relatively high (for example 800 +ohm). This would happen on some screen age with low pressure. + +There are two possible fixes: +- make Rt 64bit +- reorder calculation to avoid overflow + +The second variant seems to be preferable, since 64 bit calculation on +32 bit system is a bit more expensive. + +Fixes: ffa458c1bd9b6f653008d450f337602f3d52a646 ("spi: ads7846 driver") +Co-developed-by: David Jander +Signed-off-by: David Jander +Signed-off-by: Oleksij Rempel +Link: https://lore.kernel.org/r/20201113112240.1360-1-o.rempel@pengutronix.de +Signed-off-by: Dmitry Torokhov +Signed-off-by: Sasha Levin +--- + drivers/input/touchscreen/ads7846.c | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c +index a61b2153ab8c2..b4ded36cc4162 100644 +--- a/drivers/input/touchscreen/ads7846.c ++++ b/drivers/input/touchscreen/ads7846.c +@@ -785,10 +785,11 @@ static void ads7846_report_state(struct ads7846 *ts) + /* compute touch pressure resistance using equation #2 */ + Rt = z2; + Rt -= z1; +- Rt *= x; + Rt *= ts->x_plate_ohms; ++ Rt = DIV_ROUND_CLOSEST(Rt, 16); ++ Rt *= x; + Rt /= z1; +- Rt = (Rt + 2047) >> 12; ++ Rt = DIV_ROUND_CLOSEST(Rt, 256); + } else { + Rt = 0; + } +-- +2.27.0 + diff --git a/queue-4.4/input-ads7846-fix-unaligned-access-on-7845.patch b/queue-4.4/input-ads7846-fix-unaligned-access-on-7845.patch new file mode 100644 index 00000000000..22f815d5075 --- /dev/null +++ b/queue-4.4/input-ads7846-fix-unaligned-access-on-7845.patch @@ -0,0 +1,43 @@ +From 975c79cb695fe3346796d388cd4e3721aa6cfd95 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 11 Nov 2020 17:17:11 -0800 +Subject: Input: ads7846 - fix unaligned access on 7845 + +From: Dmitry Torokhov + +[ Upstream commit 03e2c9c782f721b661a0e42b1b58f394b5298544 ] + +req->sample[1] is not naturally aligned at word boundary, and therefore we +should use get_unaligned_be16() when accessing it. + +Fixes: 3eac5c7e44f3 ("Input: ads7846 - extend the driver for ads7845 controller support") +Signed-off-by: Dmitry Torokhov +Signed-off-by: Sasha Levin +--- + drivers/input/touchscreen/ads7846.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c +index b4ded36cc4162..1d98198c4bdfb 100644 +--- a/drivers/input/touchscreen/ads7846.c ++++ b/drivers/input/touchscreen/ads7846.c +@@ -35,6 +35,7 @@ + #include + #include + #include ++#include + + /* + * This code has been heavily tested on a Nokia 770, and lightly +@@ -410,7 +411,7 @@ static int ads7845_read12_ser(struct device *dev, unsigned command) + + if (status == 0) { + /* BE12 value, then padding */ +- status = be16_to_cpu(*((u16 *)&req->sample[1])); ++ status = get_unaligned_be16(&req->sample[1]); + status = status >> 3; + status &= 0x0fff; + } +-- +2.27.0 + diff --git a/queue-4.4/input-cros_ec_keyb-send-scancodes-in-addition-to-key.patch b/queue-4.4/input-cros_ec_keyb-send-scancodes-in-addition-to-key.patch new file mode 100644 index 00000000000..6f619cef5d7 --- /dev/null +++ b/queue-4.4/input-cros_ec_keyb-send-scancodes-in-addition-to-key.patch @@ -0,0 +1,37 @@ +From 83b5409324c4e06b2f6e7583dd2eba2d5c0853cb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 9 Dec 2020 17:59:53 -0800 +Subject: Input: cros_ec_keyb - send 'scancodes' in addition to key events + +From: Dmitry Torokhov + +[ Upstream commit 80db2a087f425b63f0163bc95217abd01c637cb5 ] + +To let userspace know what 'scancodes' should be used in EVIOCGKEYCODE +and EVIOCSKEYCODE ioctls, we should send EV_MSC/MSC_SCAN events in +addition to EV_KEY/KEY_* events. The driver already declared MSC_SCAN +capability, so it is only matter of actually sending the events. + +Link: https://lore.kernel.org/r/X87aOaSptPTvZ3nZ@google.com +Acked-by: Rajat Jain +Signed-off-by: Dmitry Torokhov +Signed-off-by: Sasha Levin +--- + drivers/input/keyboard/cros_ec_keyb.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c +index b01966dc7eb3d..44a5a5496cfd0 100644 +--- a/drivers/input/keyboard/cros_ec_keyb.c ++++ b/drivers/input/keyboard/cros_ec_keyb.c +@@ -137,6 +137,7 @@ static void cros_ec_keyb_process(struct cros_ec_keyb *ckdev, + "changed: [r%d c%d]: byte %02x\n", + row, col, new_state); + ++ input_event(idev, EV_MSC, MSC_SCAN, pos); + input_report_key(idev, keycodes[pos], + new_state); + } +-- +2.27.0 + diff --git a/queue-4.4/input-goodix-add-upside-down-quirk-for-teclast-x98-p.patch b/queue-4.4/input-goodix-add-upside-down-quirk-for-teclast-x98-p.patch new file mode 100644 index 00000000000..84314b554c1 --- /dev/null +++ b/queue-4.4/input-goodix-add-upside-down-quirk-for-teclast-x98-p.patch @@ -0,0 +1,47 @@ +From 0dcb887141e910de8edd177e37fef09a68e3fbf6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 11 Dec 2020 16:17:32 -0800 +Subject: Input: goodix - add upside-down quirk for Teclast X98 Pro tablet + +From: Simon Beginn + +[ Upstream commit cffdd6d90482316e18d686060a4397902ea04bd2 ] + +The touchscreen on the Teclast x98 Pro is also mounted upside-down in +relation to the display orientation. + +Signed-off-by: Simon Beginn +Signed-off-by: Bastien Nocera +Link: https://lore.kernel.org/r/20201117004253.27A5A27EFD@localhost +Signed-off-by: Dmitry Torokhov +Signed-off-by: Sasha Levin +--- + drivers/input/touchscreen/goodix.c | 12 ++++++++++++ + 1 file changed, 12 insertions(+) + +diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c +index 67cadda13ab17..d7cc8f6a292ea 100644 +--- a/drivers/input/touchscreen/goodix.c ++++ b/drivers/input/touchscreen/goodix.c +@@ -77,6 +77,18 @@ static const struct dmi_system_id rotated_screen[] = { + DMI_MATCH(DMI_BIOS_DATE, "12/19/2014"), + }, + }, ++ { ++ .ident = "Teclast X98 Pro", ++ .matches = { ++ /* ++ * Only match BIOS date, because the manufacturers ++ * BIOS does not report the board name at all ++ * (sometimes)... ++ */ ++ DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"), ++ DMI_MATCH(DMI_BIOS_DATE, "10/28/2015"), ++ }, ++ }, + { + .ident = "WinBook TW100", + .matches = { +-- +2.27.0 + diff --git a/queue-4.4/lockd-don-t-use-interval-based-rebinding-over-tcp.patch b/queue-4.4/lockd-don-t-use-interval-based-rebinding-over-tcp.patch new file mode 100644 index 00000000000..2f12e144b26 --- /dev/null +++ b/queue-4.4/lockd-don-t-use-interval-based-rebinding-over-tcp.patch @@ -0,0 +1,99 @@ +From 5b05acabecd66f1a8d4bc7dff696328c9268895d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 28 Oct 2020 20:16:27 +0000 +Subject: lockd: don't use interval-based rebinding over TCP + +From: Calum Mackay + +[ Upstream commit 9b82d88d5976e5f2b8015d58913654856576ace5 ] + +NLM uses an interval-based rebinding, i.e. it clears the transport's +binding under certain conditions if more than 60 seconds have elapsed +since the connection was last bound. + +This rebinding is not necessary for an autobind RPC client over a +connection-oriented protocol like TCP. + +It can also cause problems: it is possible for nlm_bind_host() to clear +XPRT_BOUND whilst a connection worker is in the middle of trying to +reconnect, after it had already been checked in xprt_connect(). + +When the connection worker notices that XPRT_BOUND has been cleared +under it, in xs_tcp_finish_connecting(), that results in: + + xs_tcp_setup_socket: connect returned unhandled error -107 + +Worse, it's possible that the two can get into lockstep, resulting in +the same behaviour repeated indefinitely, with the above error every +300 seconds, without ever recovering, and the connection never being +established. This has been seen in practice, with a large number of NLM +client tasks, following a server restart. + +The existing callers of nlm_bind_host & nlm_rebind_host should not need +to force the rebind, for TCP, so restrict the interval-based rebinding +to UDP only. + +For TCP, we will still rebind when needed, e.g. on timeout, and connection +error (including closure), since connection-related errors on an existing +connection, ECONNREFUSED when trying to connect, and rpc_check_timeout(), +already unconditionally clear XPRT_BOUND. + +To avoid having to add the fix, and explanation, to both nlm_bind_host() +and nlm_rebind_host(), remove the duplicate code from the former, and +have it call the latter. + +Drop the dprintk, which adds no value over a trace. + +Signed-off-by: Calum Mackay +Fixes: 35f5a422ce1a ("SUNRPC: new interface to force an RPC rebind") +Signed-off-by: Trond Myklebust +Signed-off-by: Sasha Levin +--- + fs/lockd/host.c | 20 +++++++++++--------- + 1 file changed, 11 insertions(+), 9 deletions(-) + +diff --git a/fs/lockd/host.c b/fs/lockd/host.c +index c7eb47f2fb6c3..603fa652b965d 100644 +--- a/fs/lockd/host.c ++++ b/fs/lockd/host.c +@@ -430,12 +430,7 @@ nlm_bind_host(struct nlm_host *host) + * RPC rebind is required + */ + if ((clnt = host->h_rpcclnt) != NULL) { +- if (time_after_eq(jiffies, host->h_nextrebind)) { +- rpc_force_rebind(clnt); +- host->h_nextrebind = jiffies + NLM_HOST_REBIND; +- dprintk("lockd: next rebind in %lu jiffies\n", +- host->h_nextrebind - jiffies); +- } ++ nlm_rebind_host(host); + } else { + unsigned long increment = nlmsvc_timeout; + struct rpc_timeout timeparms = { +@@ -483,13 +478,20 @@ nlm_bind_host(struct nlm_host *host) + return clnt; + } + +-/* +- * Force a portmap lookup of the remote lockd port ++/** ++ * nlm_rebind_host - If needed, force a portmap lookup of the peer's lockd port ++ * @host: NLM host handle for peer ++ * ++ * This is not needed when using a connection-oriented protocol, such as TCP. ++ * The existing autobind mechanism is sufficient to force a rebind when ++ * required, e.g. on connection state transitions. + */ + void + nlm_rebind_host(struct nlm_host *host) + { +- dprintk("lockd: rebind host %s\n", host->h_name); ++ if (host->h_proto != IPPROTO_UDP) ++ return; ++ + if (host->h_rpcclnt && time_after_eq(jiffies, host->h_nextrebind)) { + rpc_force_rebind(host->h_rpcclnt); + host->h_nextrebind = jiffies + NLM_HOST_REBIND; +-- +2.27.0 + diff --git a/queue-4.4/media-saa7146-fix-array-overflow-in-vidioc_s_audio.patch b/queue-4.4/media-saa7146-fix-array-overflow-in-vidioc_s_audio.patch new file mode 100644 index 00000000000..fef13f99a80 --- /dev/null +++ b/queue-4.4/media-saa7146-fix-array-overflow-in-vidioc_s_audio.patch @@ -0,0 +1,56 @@ +From c40dc85cf2893d51f1deba74dab982ebda4e8501 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 17 Nov 2020 08:23:40 +0100 +Subject: media: saa7146: fix array overflow in vidioc_s_audio() + +From: Dan Carpenter + +[ Upstream commit 8e4d86e241cf035d6d3467cd346e7ce490681937 ] + +The "a->index" value comes from the user via the ioctl. The problem is +that the shift can wrap resulting in setting "mxb->cur_audinput" to an +invalid value, which later results in an array overflow. + +Fixes: 6680427791c9 ("[media] mxb: fix audio handling") +Signed-off-by: Dan Carpenter +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/pci/saa7146/mxb.c | 19 ++++++++++--------- + 1 file changed, 10 insertions(+), 9 deletions(-) + +diff --git a/drivers/media/pci/saa7146/mxb.c b/drivers/media/pci/saa7146/mxb.c +index 0ca1e07ae7837..868af73c5536a 100644 +--- a/drivers/media/pci/saa7146/mxb.c ++++ b/drivers/media/pci/saa7146/mxb.c +@@ -652,16 +652,17 @@ static int vidioc_s_audio(struct file *file, void *fh, const struct v4l2_audio * + struct mxb *mxb = (struct mxb *)dev->ext_priv; + + DEB_D("VIDIOC_S_AUDIO %d\n", a->index); +- if (mxb_inputs[mxb->cur_input].audioset & (1 << a->index)) { +- if (mxb->cur_audinput != a->index) { +- mxb->cur_audinput = a->index; +- tea6420_route(mxb, a->index); +- if (mxb->cur_audinput == 0) +- mxb_update_audmode(mxb); +- } +- return 0; ++ if (a->index >= 32 || ++ !(mxb_inputs[mxb->cur_input].audioset & (1 << a->index))) ++ return -EINVAL; ++ ++ if (mxb->cur_audinput != a->index) { ++ mxb->cur_audinput = a->index; ++ tea6420_route(mxb, a->index); ++ if (mxb->cur_audinput == 0) ++ mxb_update_audmode(mxb); + } +- return -EINVAL; ++ return 0; + } + + #ifdef CONFIG_VIDEO_ADV_DEBUG +-- +2.27.0 + diff --git a/queue-4.4/media-solo6x10-fix-missing-snd_card_free-in-error-ha.patch b/queue-4.4/media-solo6x10-fix-missing-snd_card_free-in-error-ha.patch new file mode 100644 index 00000000000..dbb1ef81743 --- /dev/null +++ b/queue-4.4/media-solo6x10-fix-missing-snd_card_free-in-error-ha.patch @@ -0,0 +1,38 @@ +From f29a4b345754cd98f0e48aeec0b0d40826182d37 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 11 Nov 2020 04:22:01 +0100 +Subject: media: solo6x10: fix missing snd_card_free in error handling case + +From: Qinglang Miao + +[ Upstream commit dcdff74fa6bc00c32079d0bebd620764c26f2d89 ] + +Fix to goto snd_error in error handling case when fails +to do snd_ctl_add, as done elsewhere in this function. + +Fixes: 28cae868cd24 ("[media] solo6x10: move out of staging into drivers/media/pci.") +Reported-by: Hulk Robot +Signed-off-by: Qinglang Miao +Signed-off-by: Hans Verkuil +Signed-off-by: Mauro Carvalho Chehab +Signed-off-by: Sasha Levin +--- + drivers/media/pci/solo6x10/solo6x10-g723.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/media/pci/solo6x10/solo6x10-g723.c b/drivers/media/pci/solo6x10/solo6x10-g723.c +index 4a37a1c51c488..30407955a4d17 100644 +--- a/drivers/media/pci/solo6x10/solo6x10-g723.c ++++ b/drivers/media/pci/solo6x10/solo6x10-g723.c +@@ -385,7 +385,7 @@ int solo_g723_init(struct solo_dev *solo_dev) + + ret = snd_ctl_add(card, snd_ctl_new1(&kctl, solo_dev)); + if (ret < 0) +- return ret; ++ goto snd_error; + + ret = solo_snd_pcm_init(solo_dev); + if (ret < 0) +-- +2.27.0 + diff --git a/queue-4.4/memstick-fix-a-double-free-bug-in-memstick_check.patch b/queue-4.4/memstick-fix-a-double-free-bug-in-memstick_check.patch new file mode 100644 index 00000000000..90830fcc38f --- /dev/null +++ b/queue-4.4/memstick-fix-a-double-free-bug-in-memstick_check.patch @@ -0,0 +1,37 @@ +From 1012d19425d3c8572e5ec72f5ca917ac5708d577 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 20 Nov 2020 15:48:46 +0800 +Subject: memstick: fix a double-free bug in memstick_check + +From: Qinglang Miao + +[ Upstream commit e3e9ced5c93803d5b2ea1942c4bf0192622531d6 ] + +kfree(host->card) has been called in put_device so that +another kfree would raise cause a double-free bug. + +Fixes: 0193383a5833 ("memstick: core: fix device_register() error handling") +Reported-by: Hulk Robot +Signed-off-by: Qinglang Miao +Link: https://lore.kernel.org/r/20201120074846.31322-1-miaoqinglang@huawei.com +Signed-off-by: Ulf Hansson +Signed-off-by: Sasha Levin +--- + drivers/memstick/core/memstick.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c +index 1041eb7a61672..2cae85a7ca6de 100644 +--- a/drivers/memstick/core/memstick.c ++++ b/drivers/memstick/core/memstick.c +@@ -469,7 +469,6 @@ static void memstick_check(struct work_struct *work) + host->card = card; + if (device_register(&card->dev)) { + put_device(&card->dev); +- kfree(host->card); + host->card = NULL; + } + } else +-- +2.27.0 + diff --git a/queue-4.4/memstick-r592-fix-error-return-in-r592_probe.patch b/queue-4.4/memstick-r592-fix-error-return-in-r592_probe.patch new file mode 100644 index 00000000000..cbf6d7aea65 --- /dev/null +++ b/queue-4.4/memstick-r592-fix-error-return-in-r592_probe.patch @@ -0,0 +1,57 @@ +From c0bc371fc0008e3b15741a008914658ad2f25461 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 25 Nov 2020 09:47:18 +0800 +Subject: memstick: r592: Fix error return in r592_probe() + +From: Jing Xiangfeng + +[ Upstream commit db29d3d1c2451e673e29c7257471e3ce9d50383a ] + +Fix to return a error code from the error handling case instead of 0. + +Fixes: 926341250102 ("memstick: add driver for Ricoh R5C592 card reader") +Signed-off-by: Jing Xiangfeng +Link: https://lore.kernel.org/r/20201125014718.153563-1-jingxiangfeng@huawei.com +Signed-off-by: Ulf Hansson +Signed-off-by: Sasha Levin +--- + drivers/memstick/host/r592.c | 12 ++++++++---- + 1 file changed, 8 insertions(+), 4 deletions(-) + +diff --git a/drivers/memstick/host/r592.c b/drivers/memstick/host/r592.c +index ef09ba0289d72..b3857445d6736 100644 +--- a/drivers/memstick/host/r592.c ++++ b/drivers/memstick/host/r592.c +@@ -763,8 +763,10 @@ static int r592_probe(struct pci_dev *pdev, const struct pci_device_id *id) + goto error3; + + dev->mmio = pci_ioremap_bar(pdev, 0); +- if (!dev->mmio) ++ if (!dev->mmio) { ++ error = -ENOMEM; + goto error4; ++ } + + dev->irq = pdev->irq; + spin_lock_init(&dev->irq_lock); +@@ -791,12 +793,14 @@ static int r592_probe(struct pci_dev *pdev, const struct pci_device_id *id) + &dev->dummy_dma_page_physical_address, GFP_KERNEL); + r592_stop_dma(dev , 0); + +- if (request_irq(dev->irq, &r592_irq, IRQF_SHARED, +- DRV_NAME, dev)) ++ error = request_irq(dev->irq, &r592_irq, IRQF_SHARED, ++ DRV_NAME, dev); ++ if (error) + goto error6; + + r592_update_card_detect(dev); +- if (memstick_add_host(host)) ++ error = memstick_add_host(host); ++ if (error) + goto error7; + + message("driver successfully loaded"); +-- +2.27.0 + diff --git a/queue-4.4/mips-bcm47xx-fix-kconfig-dependency-bug-for-bcm47xx_.patch b/queue-4.4/mips-bcm47xx-fix-kconfig-dependency-bug-for-bcm47xx_.patch new file mode 100644 index 00000000000..5e7c1396ab2 --- /dev/null +++ b/queue-4.4/mips-bcm47xx-fix-kconfig-dependency-bug-for-bcm47xx_.patch @@ -0,0 +1,48 @@ +From 18688a2d03a81be7cb47e092ac34baf6fc5d815d Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 00:34:01 +0300 +Subject: MIPS: BCM47XX: fix kconfig dependency bug for BCM47XX_BCMA + +From: Necip Fazil Yildiran + +[ Upstream commit 3a5fe2fb9635c43359c9729352f45044f3c8df6b ] + +When BCM47XX_BCMA is enabled and BCMA_DRIVER_PCI is disabled, it results +in the following Kbuild warning: + +WARNING: unmet direct dependencies detected for BCMA_DRIVER_PCI_HOSTMODE + Depends on [n]: MIPS [=y] && BCMA_DRIVER_PCI [=n] && PCI_DRIVERS_LEGACY [=y] && BCMA [=y]=y + Selected by [y]: + - BCM47XX_BCMA [=y] && BCM47XX [=y] && PCI [=y] + +The reason is that BCM47XX_BCMA selects BCMA_DRIVER_PCI_HOSTMODE without +depending on or selecting BCMA_DRIVER_PCI while BCMA_DRIVER_PCI_HOSTMODE +depends on BCMA_DRIVER_PCI. This can also fail building the kernel. + +Honor the kconfig dependency to remove unmet direct dependency warnings +and avoid any potential build failures. + +Fixes: c1d1c5d4213e ("bcm47xx: add support for bcma bus") +Link: https://bugzilla.kernel.org/show_bug.cgi?id=209879 +Signed-off-by: Necip Fazil Yildiran +Signed-off-by: Thomas Bogendoerfer +Signed-off-by: Sasha Levin +--- + arch/mips/bcm47xx/Kconfig | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig +index e970fd9cf7693..7ca7384fd5c9d 100644 +--- a/arch/mips/bcm47xx/Kconfig ++++ b/arch/mips/bcm47xx/Kconfig +@@ -26,6 +26,7 @@ config BCM47XX_BCMA + select BCMA + select BCMA_HOST_SOC + select BCMA_DRIVER_MIPS ++ select BCMA_DRIVER_PCI if PCI + select BCMA_DRIVER_PCI_HOSTMODE if PCI + select BCMA_DRIVER_GPIO + default y +-- +2.27.0 + diff --git a/queue-4.4/mips-cdmm-fix-use-after-free-in-mips_cdmm_bus_discov.patch b/queue-4.4/mips-cdmm-fix-use-after-free-in-mips_cdmm_bus_discov.patch new file mode 100644 index 00000000000..954f1410cea --- /dev/null +++ b/queue-4.4/mips-cdmm-fix-use-after-free-in-mips_cdmm_bus_discov.patch @@ -0,0 +1,41 @@ +From e1c01eacab98e016cc0fab247cdf32995ded7f60 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 20 Nov 2020 15:48:47 +0800 +Subject: mips: cdmm: fix use-after-free in mips_cdmm_bus_discover + +From: Qinglang Miao + +[ Upstream commit f0e82242b16826077a2775eacfe201d803bb7a22 ] + +kfree(dev) has been called inside put_device so anther +kfree would cause a use-after-free bug/ + +Fixes: 8286ae03308c ("MIPS: Add CDMM bus support") +Reported-by: Hulk Robot +Signed-off-by: Qinglang Miao +Acked-by: Serge Semin +Signed-off-by: Thomas Bogendoerfer +Signed-off-by: Sasha Levin +--- + drivers/bus/mips_cdmm.c | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/drivers/bus/mips_cdmm.c b/drivers/bus/mips_cdmm.c +index 1c543effe062f..e6284fc1689b3 100644 +--- a/drivers/bus/mips_cdmm.c ++++ b/drivers/bus/mips_cdmm.c +@@ -544,10 +544,8 @@ static void mips_cdmm_bus_discover(struct mips_cdmm_bus *bus) + dev_set_name(&dev->dev, "cdmm%u-%u", cpu, id); + ++id; + ret = device_register(&dev->dev); +- if (ret) { ++ if (ret) + put_device(&dev->dev); +- kfree(dev); +- } + } + } + +-- +2.27.0 + diff --git a/queue-4.4/net-allwinner-fix-some-resources-leak-in-the-error-h.patch b/queue-4.4/net-allwinner-fix-some-resources-leak-in-the-error-h.patch new file mode 100644 index 00000000000..096bca8d5ee --- /dev/null +++ b/queue-4.4/net-allwinner-fix-some-resources-leak-in-the-error-h.patch @@ -0,0 +1,65 @@ +From 3a67737c12b0431bae149ad4d002806b7c9f08cf Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Dec 2020 21:21:17 +0100 +Subject: net: allwinner: Fix some resources leak in the error handling path of + the probe and in the remove function + +From: Christophe JAILLET + +[ Upstream commit 322e53d1e2529ae9d501f5e0f20604a79b873aef ] + +'irq_of_parse_and_map()' should be balanced by a corresponding +'irq_dispose_mapping()' call. Otherwise, there is some resources leaks. + +Add such a call in the error handling path of the probe function and in the +remove function. + +Fixes: 492205050d77 ("net: Add EMAC ethernet driver found on Allwinner A10 SoC's") +Signed-off-by: Christophe JAILLET +Link: https://lore.kernel.org/r/20201214202117.146293-1-christophe.jaillet@wanadoo.fr +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/allwinner/sun4i-emac.c | 7 +++++-- + 1 file changed, 5 insertions(+), 2 deletions(-) + +diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c +index dde3cd2d47631..10dda58849c6e 100644 +--- a/drivers/net/ethernet/allwinner/sun4i-emac.c ++++ b/drivers/net/ethernet/allwinner/sun4i-emac.c +@@ -853,13 +853,13 @@ static int emac_probe(struct platform_device *pdev) + db->clk = devm_clk_get(&pdev->dev, NULL); + if (IS_ERR(db->clk)) { + ret = PTR_ERR(db->clk); +- goto out_iounmap; ++ goto out_dispose_mapping; + } + + ret = clk_prepare_enable(db->clk); + if (ret) { + dev_err(&pdev->dev, "Error couldn't enable clock (%d)\n", ret); +- goto out_iounmap; ++ goto out_dispose_mapping; + } + + ret = sunxi_sram_claim(&pdev->dev); +@@ -916,6 +916,8 @@ out_release_sram: + sunxi_sram_release(&pdev->dev); + out_clk_disable_unprepare: + clk_disable_unprepare(db->clk); ++out_dispose_mapping: ++ irq_dispose_mapping(ndev->irq); + out_iounmap: + iounmap(db->membase); + out: +@@ -934,6 +936,7 @@ static int emac_remove(struct platform_device *pdev) + unregister_netdev(ndev); + sunxi_sram_release(&pdev->dev); + clk_disable_unprepare(db->clk); ++ irq_dispose_mapping(ndev->irq); + iounmap(db->membase); + free_netdev(ndev); + +-- +2.27.0 + diff --git a/queue-4.4/net-bcmgenet-fix-a-resource-leak-in-an-error-handlin.patch b/queue-4.4/net-bcmgenet-fix-a-resource-leak-in-an-error-handlin.patch new file mode 100644 index 00000000000..1fc3f8a5937 --- /dev/null +++ b/queue-4.4/net-bcmgenet-fix-a-resource-leak-in-an-error-handlin.patch @@ -0,0 +1,42 @@ +From 431f0d4242a17b146fc433deaf3e1765c6e0fa41 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 12 Dec 2020 19:20:05 +0100 +Subject: net: bcmgenet: Fix a resource leak in an error handling path in the + probe functin + +From: Christophe JAILLET + +[ Upstream commit 4375ada01963d1ebf733d60d1bb6e5db401e1ac6 ] + +If the 'register_netdev()' call fails, we must undo a previous +'bcmgenet_mii_init()' call. + +Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file") +Signed-off-by: Christophe JAILLET +Acked-by: Florian Fainelli +Link: https://lore.kernel.org/r/20201212182005.120437-1-christophe.jaillet@wanadoo.fr +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/broadcom/genet/bcmgenet.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c +index bae8df9517808..3a6cebff9f426 100644 +--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c ++++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c +@@ -3518,8 +3518,10 @@ static int bcmgenet_probe(struct platform_device *pdev) + clk_disable_unprepare(priv->clk); + + err = register_netdev(dev); +- if (err) ++ if (err) { ++ bcmgenet_mii_exit(dev); + goto err; ++ } + + return err; + +-- +2.27.0 + diff --git a/queue-4.4/net-evaluate-net.ipv4.conf.all.proxy_arp_pvlan.patch b/queue-4.4/net-evaluate-net.ipv4.conf.all.proxy_arp_pvlan.patch new file mode 100644 index 00000000000..3226869b92c --- /dev/null +++ b/queue-4.4/net-evaluate-net.ipv4.conf.all.proxy_arp_pvlan.patch @@ -0,0 +1,38 @@ +From 81455cd6580cc87cc71d330115bdd67fe16dec22 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 7 Nov 2020 20:35:14 +0100 +Subject: net: evaluate net.ipv4.conf.all.proxy_arp_pvlan + +From: Vincent Bernat + +[ Upstream commit 1af5318c00a8acc33a90537af49b3f23f72a2c4b ] + +Introduced in 65324144b50b, the "proxy_arp_vlan" sysctl is a +per-interface sysctl to tune proxy ARP support for private VLANs. +While the "all" variant is exposed, it was a noop and never evaluated. +We use the usual "or" logic for this kind of sysctls. + +Fixes: 65324144b50b ("net: RFC3069, private VLAN proxy arp support") +Signed-off-by: Vincent Bernat +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + include/linux/inetdevice.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h +index 0e6cd645f67f3..65e88c62db7b2 100644 +--- a/include/linux/inetdevice.h ++++ b/include/linux/inetdevice.h +@@ -100,7 +100,7 @@ static inline void ipv4_devconf_setall(struct in_device *in_dev) + + #define IN_DEV_LOG_MARTIANS(in_dev) IN_DEV_ORCONF((in_dev), LOG_MARTIANS) + #define IN_DEV_PROXY_ARP(in_dev) IN_DEV_ORCONF((in_dev), PROXY_ARP) +-#define IN_DEV_PROXY_ARP_PVLAN(in_dev) IN_DEV_CONF_GET(in_dev, PROXY_ARP_PVLAN) ++#define IN_DEV_PROXY_ARP_PVLAN(in_dev) IN_DEV_ORCONF((in_dev), PROXY_ARP_PVLAN) + #define IN_DEV_SHARED_MEDIA(in_dev) IN_DEV_ORCONF((in_dev), SHARED_MEDIA) + #define IN_DEV_TX_REDIRECTS(in_dev) IN_DEV_ORCONF((in_dev), SEND_REDIRECTS) + #define IN_DEV_SEC_REDIRECTS(in_dev) IN_DEV_ORCONF((in_dev), \ +-- +2.27.0 + diff --git a/queue-4.4/net-evaluate-net.ipvx.conf.all.ignore_routes_with_li.patch b/queue-4.4/net-evaluate-net.ipvx.conf.all.ignore_routes_with_li.patch new file mode 100644 index 00000000000..57d38ae9e6a --- /dev/null +++ b/queue-4.4/net-evaluate-net.ipvx.conf.all.ignore_routes_with_li.patch @@ -0,0 +1,111 @@ +From 459cd0600436d7ea55378951c63f4eacac570c35 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 7 Nov 2020 20:35:13 +0100 +Subject: net: evaluate net.ipvX.conf.all.ignore_routes_with_linkdown + +From: Vincent Bernat + +[ Upstream commit c0c5a60f0f1311bcf08bbe735122096d6326fb5b ] + +Introduced in 0eeb075fad73, the "ignore_routes_with_linkdown" sysctl +ignores a route whose interface is down. It is provided as a +per-interface sysctl. However, while a "all" variant is exposed, it +was a noop since it was never evaluated. We use the usual "or" logic +for this kind of sysctls. + +Tested with: + + ip link add type veth # veth0 + veth1 + ip link add type veth # veth1 + veth2 + ip link set up dev veth0 + ip link set up dev veth1 # link-status paired with veth0 + ip link set up dev veth2 + ip link set up dev veth3 # link-status paired with veth2 + + # First available path + ip -4 addr add 203.0.113.${uts#H}/24 dev veth0 + ip -6 addr add 2001:db8:1::${uts#H}/64 dev veth0 + + # Second available path + ip -4 addr add 192.0.2.${uts#H}/24 dev veth2 + ip -6 addr add 2001:db8:2::${uts#H}/64 dev veth2 + + # More specific route through first path + ip -4 route add 198.51.100.0/25 via 203.0.113.254 # via veth0 + ip -6 route add 2001:db8:3::/56 via 2001:db8:1::ff # via veth0 + + # Less specific route through second path + ip -4 route add 198.51.100.0/24 via 192.0.2.254 # via veth2 + ip -6 route add 2001:db8:3::/48 via 2001:db8:2::ff # via veth2 + + # H1: enable on "all" + # H2: enable on "veth0" + for v in ipv4 ipv6; do + case $uts in + H1) + sysctl -qw net.${v}.conf.all.ignore_routes_with_linkdown=1 + ;; + H2) + sysctl -qw net.${v}.conf.veth0.ignore_routes_with_linkdown=1 + ;; + esac + done + + set -xe + # When veth0 is up, best route is through veth0 + ip -o route get 198.51.100.1 | grep -Fw veth0 + ip -o route get 2001:db8:3::1 | grep -Fw veth0 + + # When veth0 is down, best route should be through veth2 on H1/H2, + # but on veth0 on H2 + ip link set down dev veth1 # down veth0 + ip route show + [ $uts != H3 ] || ip -o route get 198.51.100.1 | grep -Fw veth0 + [ $uts != H3 ] || ip -o route get 2001:db8:3::1 | grep -Fw veth0 + [ $uts = H3 ] || ip -o route get 198.51.100.1 | grep -Fw veth2 + [ $uts = H3 ] || ip -o route get 2001:db8:3::1 | grep -Fw veth2 + +Without this patch, the two last lines would fail on H1 (the one using +the "all" sysctl). With the patch, everything succeeds as expected. + +Also document the sysctl in `ip-sysctl.rst`. + +Fixes: 0eeb075fad73 ("net: ipv4 sysctl option to ignore routes when nexthop link is down") +Signed-off-by: Vincent Bernat +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + Documentation/networking/ip-sysctl.txt | 3 +++ + include/linux/inetdevice.h | 2 +- + 2 files changed, 4 insertions(+), 1 deletion(-) + +diff --git a/Documentation/networking/ip-sysctl.txt b/Documentation/networking/ip-sysctl.txt +index eac939abe6c4c..b25308b621d6f 100644 +--- a/Documentation/networking/ip-sysctl.txt ++++ b/Documentation/networking/ip-sysctl.txt +@@ -1211,6 +1211,9 @@ igmpv3_unsolicited_report_interval - INTEGER + IGMPv3 report retransmit will take place. + Default: 1000 (1 seconds) + ++ignore_routes_with_linkdown - BOOLEAN ++ Ignore routes whose link is down when performing a FIB lookup. ++ + promote_secondaries - BOOLEAN + When a primary IP address is removed from this interface + promote a corresponding secondary IP address instead of +diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h +index ee971f335a8b6..0e6cd645f67f3 100644 +--- a/include/linux/inetdevice.h ++++ b/include/linux/inetdevice.h +@@ -121,7 +121,7 @@ static inline void ipv4_devconf_setall(struct in_device *in_dev) + IN_DEV_ORCONF((in_dev), ACCEPT_REDIRECTS))) + + #define IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN(in_dev) \ +- IN_DEV_CONF_GET((in_dev), IGNORE_ROUTES_WITH_LINKDOWN) ++ IN_DEV_ORCONF((in_dev), IGNORE_ROUTES_WITH_LINKDOWN) + + #define IN_DEV_ARPFILTER(in_dev) IN_DEV_ORCONF((in_dev), ARPFILTER) + #define IN_DEV_ARP_ACCEPT(in_dev) IN_DEV_ORCONF((in_dev), ARP_ACCEPT) +-- +2.27.0 + diff --git a/queue-4.4/net-korina-fix-return-value.patch b/queue-4.4/net-korina-fix-return-value.patch new file mode 100644 index 00000000000..0ad36304652 --- /dev/null +++ b/queue-4.4/net-korina-fix-return-value.patch @@ -0,0 +1,43 @@ +From 2eee66ec58d4f6796ee254fd831c7a0ef7fce805 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 14 Dec 2020 23:09:52 +0100 +Subject: net: korina: fix return value +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Vincent Stehlé + +[ Upstream commit 7eb000bdbe7c7da811ef51942b356f6e819b13ba ] + +The ndo_start_xmit() method must not attempt to free the skb to transmit +when returning NETDEV_TX_BUSY. Therefore, make sure the +korina_send_packet() function returns NETDEV_TX_OK when it frees a packet. + +Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") +Suggested-by: Jakub Kicinski +Signed-off-by: Vincent Stehlé +Acked-by: Florian Fainelli +Link: https://lore.kernel.org/r/20201214220952.19935-1-vincent.stehle@laposte.net +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/korina.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c +index b491de946a0e6..88f5c45d9eef4 100644 +--- a/drivers/net/ethernet/korina.c ++++ b/drivers/net/ethernet/korina.c +@@ -216,7 +216,7 @@ static int korina_send_packet(struct sk_buff *skb, struct net_device *dev) + dev_kfree_skb_any(skb); + spin_unlock_irqrestore(&lp->lock, flags); + +- return NETDEV_TX_BUSY; ++ return NETDEV_TX_OK; + } + } + +-- +2.27.0 + diff --git a/queue-4.4/nfc-s3fwrn5-release-the-nfc-firmware.patch b/queue-4.4/nfc-s3fwrn5-release-the-nfc-firmware.patch new file mode 100644 index 00000000000..b9cf4631d06 --- /dev/null +++ b/queue-4.4/nfc-s3fwrn5-release-the-nfc-firmware.patch @@ -0,0 +1,41 @@ +From 6c9be301e75f386cb8fc498e276606ea61e700e1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Dec 2020 18:58:50 +0900 +Subject: nfc: s3fwrn5: Release the nfc firmware + +From: Bongsu Jeon + +[ Upstream commit a4485baefa1efa596702ebffd5a9c760d42b14b5 ] + +add the code to release the nfc firmware when the firmware image size is +wrong. + +Fixes: c04c674fadeb ("nfc: s3fwrn5: Add driver for Samsung S3FWRN5 NFC Chip") +Signed-off-by: Bongsu Jeon +Reviewed-by: Krzysztof Kozlowski +Link: https://lore.kernel.org/r/20201213095850.28169-1-bongsu.jeon@samsung.com +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/nfc/s3fwrn5/firmware.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/nfc/s3fwrn5/firmware.c b/drivers/nfc/s3fwrn5/firmware.c +index 64a90252c57f2..b387845d3c72a 100644 +--- a/drivers/nfc/s3fwrn5/firmware.c ++++ b/drivers/nfc/s3fwrn5/firmware.c +@@ -304,8 +304,10 @@ static int s3fwrn5_fw_request_firmware(struct s3fwrn5_fw_info *fw_info) + if (ret < 0) + return ret; + +- if (fw->fw->size < S3FWRN5_FW_IMAGE_HEADER_SIZE) ++ if (fw->fw->size < S3FWRN5_FW_IMAGE_HEADER_SIZE) { ++ release_firmware(fw->fw); + return -EINVAL; ++ } + + memcpy(fw->date, fw->fw->data + 0x00, 12); + fw->date[12] = '\0'; +-- +2.27.0 + diff --git a/queue-4.4/nfs-switch-nfsiod-to-be-an-unbound-workqueue.patch b/queue-4.4/nfs-switch-nfsiod-to-be-an-unbound-workqueue.patch new file mode 100644 index 00000000000..e77066bf0ee --- /dev/null +++ b/queue-4.4/nfs-switch-nfsiod-to-be-an-unbound-workqueue.patch @@ -0,0 +1,52 @@ +From 15cae18c7945935259ebae0a2c399e3497e20295 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 27 Nov 2020 11:24:33 +1100 +Subject: NFS: switch nfsiod to be an UNBOUND workqueue. + +From: NeilBrown + +[ Upstream commit bf701b765eaa82dd164d65edc5747ec7288bb5c3 ] + +nfsiod is currently a concurrency-managed workqueue (CMWQ). +This means that workitems scheduled to nfsiod on a given CPU are queued +behind all other work items queued on any CMWQ on the same CPU. This +can introduce unexpected latency. + +Occaionally nfsiod can even cause excessive latency. If the work item +to complete a CLOSE request calls the final iput() on an inode, the +address_space of that inode will be dismantled. This takes time +proportional to the number of in-memory pages, which on a large host +working on large files (e.g.. 5TB), can be a large number of pages +resulting in a noticable number of seconds. + +We can avoid these latency problems by switching nfsiod to WQ_UNBOUND. +This causes each concurrent work item to gets a dedicated thread which +can be scheduled to an idle CPU. + +There is precedent for this as several other filesystems use WQ_UNBOUND +workqueue for handling various async events. + +Signed-off-by: NeilBrown +Fixes: ada609ee2ac2 ("workqueue: use WQ_MEM_RECLAIM instead of WQ_RESCUER") +Signed-off-by: Trond Myklebust +Signed-off-by: Sasha Levin +--- + fs/nfs/inode.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c +index d25b55ceb9d58..b152366411917 100644 +--- a/fs/nfs/inode.c ++++ b/fs/nfs/inode.c +@@ -1964,7 +1964,7 @@ static int nfsiod_start(void) + { + struct workqueue_struct *wq; + dprintk("RPC: creating workqueue nfsiod\n"); +- wq = alloc_workqueue("nfsiod", WQ_MEM_RECLAIM, 0); ++ wq = alloc_workqueue("nfsiod", WQ_MEM_RECLAIM | WQ_UNBOUND, 0); + if (wq == NULL) + return -ENOMEM; + nfsiod_workqueue = wq; +-- +2.27.0 + diff --git a/queue-4.4/nfs_common-need-lock-during-iterate-through-the-list.patch b/queue-4.4/nfs_common-need-lock-during-iterate-through-the-list.patch new file mode 100644 index 00000000000..4f5e29b3149 --- /dev/null +++ b/queue-4.4/nfs_common-need-lock-during-iterate-through-the-list.patch @@ -0,0 +1,79 @@ +From 4c935737acf4b39a76dcd1fac67a3bb9aed48bd6 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 1 Dec 2020 07:06:35 -0500 +Subject: nfs_common: need lock during iterate through the list +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Cheng Lin + +[ Upstream commit 4a9d81caf841cd2c0ae36abec9c2963bf21d0284 ] + +If the elem is deleted during be iterated on it, the iteration +process will fall into an endless loop. + +kernel: NMI watchdog: BUG: soft lockup - CPU#4 stuck for 22s! [nfsd:17137] + +PID: 17137  TASK: ffff8818d93c0000  CPU: 4   COMMAND: "nfsd" +    [exception RIP: __state_in_grace+76] +    RIP: ffffffffc00e817c  RSP: ffff8818d3aefc98  RFLAGS: 00000246 +    RAX: ffff881dc0c38298  RBX: ffffffff81b03580  RCX: ffff881dc02c9f50 +    RDX: ffff881e3fce8500  RSI: 0000000000000001  RDI: ffffffff81b03580 +    RBP: ffff8818d3aefca0   R8: 0000000000000020   R9: ffff8818d3aefd40 +    R10: ffff88017fc03800  R11: ffff8818e83933c0  R12: ffff8818d3aefd40 +    R13: 0000000000000000  R14: ffff8818e8391068  R15: ffff8818fa6e4000 +    CS: 0010  SS: 0018 + #0 [ffff8818d3aefc98] opens_in_grace at ffffffffc00e81e3 [grace] + #1 [ffff8818d3aefca8] nfs4_preprocess_stateid_op at ffffffffc02a3e6c [nfsd] + #2 [ffff8818d3aefd18] nfsd4_write at ffffffffc028ed5b [nfsd] + #3 [ffff8818d3aefd80] nfsd4_proc_compound at ffffffffc0290a0d [nfsd] + #4 [ffff8818d3aefdd0] nfsd_dispatch at ffffffffc027b800 [nfsd] + #5 [ffff8818d3aefe08] svc_process_common at ffffffffc02017f3 [sunrpc] + #6 [ffff8818d3aefe70] svc_process at ffffffffc0201ce3 [sunrpc] + #7 [ffff8818d3aefe98] nfsd at ffffffffc027b117 [nfsd] + #8 [ffff8818d3aefec8] kthread at ffffffff810b88c1 + #9 [ffff8818d3aeff50] ret_from_fork at ffffffff816d1607 + +The troublemake elem: +crash> lock_manager ffff881dc0c38298 +struct lock_manager { +  list = { +    next = 0xffff881dc0c38298, +    prev = 0xffff881dc0c38298 +  }, +  block_opens = false +} + +Fixes: c87fb4a378f9 ("lockd: NLM grace period shouldn't block NFSv4 opens") +Signed-off-by: Cheng Lin  +Signed-off-by: Yi Wang  +Signed-off-by: Chuck Lever +Signed-off-by: Sasha Levin +--- + fs/nfs_common/grace.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/fs/nfs_common/grace.c b/fs/nfs_common/grace.c +index 77d136ac89099..c21fca0dcba74 100644 +--- a/fs/nfs_common/grace.c ++++ b/fs/nfs_common/grace.c +@@ -75,10 +75,14 @@ __state_in_grace(struct net *net, bool open) + if (!open) + return !list_empty(grace_list); + ++ spin_lock(&grace_lock); + list_for_each_entry(lm, grace_list, list) { +- if (lm->block_opens) ++ if (lm->block_opens) { ++ spin_unlock(&grace_lock); + return true; ++ } + } ++ spin_unlock(&grace_lock); + return false; + } + +-- +2.27.0 + diff --git a/queue-4.4/nfsv4.2-condition-readdir-s-mask-for-security-label-.patch b/queue-4.4/nfsv4.2-condition-readdir-s-mask-for-security-label-.patch new file mode 100644 index 00000000000..6d2ffc5fe2f --- /dev/null +++ b/queue-4.4/nfsv4.2-condition-readdir-s-mask-for-security-label-.patch @@ -0,0 +1,74 @@ +From e876deb21784dbfd43eddcb7ea61945a1858aeb5 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 6 Nov 2020 16:03:38 -0500 +Subject: NFSv4.2: condition READDIR's mask for security label based on LSM + state + +From: Olga Kornievskaia + +[ Upstream commit 05ad917561fca39a03338cb21fe9622f998b0f9c ] + +Currently, the client will always ask for security_labels if the server +returns that it supports that feature regardless of any LSM modules +(such as Selinux) enforcing security policy. This adds performance +penalty to the READDIR operation. + +Client adjusts superblock's support of the security_label based on +the server's support but also current client's configuration of the +LSM modules. Thus, prior to using the default bitmask in READDIR, +this patch checks the server's capabilities and then instructs +READDIR to remove FATTR4_WORD2_SECURITY_LABEL from the bitmask. + +v5: fixing silly mistakes of the rushed v4 +v4: simplifying logic +v3: changing label's initialization per Ondrej's comment +v2: dropping selinux hook and using the sb cap. + +Suggested-by: Ondrej Mosnacek +Suggested-by: Scott Mayhew +Signed-off-by: Olga Kornievskaia +Fixes: 2b0143b5c986 ("VFS: normal filesystems (and lustre): d_inode() annotations") +Signed-off-by: Trond Myklebust +Signed-off-by: Sasha Levin +--- + fs/nfs/nfs4proc.c | 10 ++++++++-- + 1 file changed, 8 insertions(+), 2 deletions(-) + +diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c +index 64d15c2662db6..3c15291ba1aaa 100644 +--- a/fs/nfs/nfs4proc.c ++++ b/fs/nfs/nfs4proc.c +@@ -4047,12 +4047,12 @@ static int _nfs4_proc_readdir(struct dentry *dentry, struct rpc_cred *cred, + u64 cookie, struct page **pages, unsigned int count, int plus) + { + struct inode *dir = d_inode(dentry); ++ struct nfs_server *server = NFS_SERVER(dir); + struct nfs4_readdir_arg args = { + .fh = NFS_FH(dir), + .pages = pages, + .pgbase = 0, + .count = count, +- .bitmask = NFS_SERVER(d_inode(dentry))->attr_bitmask, + .plus = plus, + }; + struct nfs4_readdir_res res; +@@ -4067,9 +4067,15 @@ static int _nfs4_proc_readdir(struct dentry *dentry, struct rpc_cred *cred, + dprintk("%s: dentry = %pd2, cookie = %Lu\n", __func__, + dentry, + (unsigned long long)cookie); ++ if (!(server->caps & NFS_CAP_SECURITY_LABEL)) ++ args.bitmask = server->attr_bitmask_nl; ++ else ++ args.bitmask = server->attr_bitmask; ++ + nfs4_setup_readdir(cookie, NFS_I(dir)->cookieverf, dentry, &args); + res.pgbase = args.pgbase; +- status = nfs4_call_sync(NFS_SERVER(dir)->client, NFS_SERVER(dir), &msg, &args.seq_args, &res.seq_res, 0); ++ status = nfs4_call_sync(server->client, server, &msg, &args.seq_args, ++ &res.seq_res, 0); + if (status >= 0) { + memcpy(NFS_I(dir)->cookieverf, res.verifier.data, NFS4_VERIFIER_SIZE); + status += args.pgbase; +-- +2.27.0 + diff --git a/queue-4.4/orinoco-move-context-allocation-after-processing-the.patch b/queue-4.4/orinoco-move-context-allocation-after-processing-the.patch new file mode 100644 index 00000000000..f7482ba7d41 --- /dev/null +++ b/queue-4.4/orinoco-move-context-allocation-after-processing-the.patch @@ -0,0 +1,60 @@ +From 1909b582c8ea70a635c35c9db46db12a7e2e8190 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 13 Nov 2020 22:22:43 +0100 +Subject: orinoco: Move context allocation after processing the skb + +From: Sebastian Andrzej Siewior + +[ Upstream commit a31eb615646a63370aa1da1053c45439c7653d83 ] + +ezusb_xmit() allocates a context which is leaked if +orinoco_process_xmit_skb() returns an error. + +Move ezusb_alloc_ctx() after the invocation of +orinoco_process_xmit_skb() because the context is not needed so early. +ezusb_access_ltv() will cleanup the context in case of an error. + +Fixes: bac6fafd4d6a0 ("orinoco: refactor xmit path") +Signed-off-by: Sebastian Andrzej Siewior +Signed-off-by: Kalle Valo +Link: https://lore.kernel.org/r/20201113212252.2243570-2-bigeasy@linutronix.de +Signed-off-by: Sasha Levin +--- + drivers/net/wireless/orinoco/orinoco_usb.c | 14 +++++++------- + 1 file changed, 7 insertions(+), 7 deletions(-) + +diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c b/drivers/net/wireless/orinoco/orinoco_usb.c +index 3c5baccd67922..8eb73d54b1d6d 100644 +--- a/drivers/net/wireless/orinoco/orinoco_usb.c ++++ b/drivers/net/wireless/orinoco/orinoco_usb.c +@@ -1224,13 +1224,6 @@ static netdev_tx_t ezusb_xmit(struct sk_buff *skb, struct net_device *dev) + if (skb->len < ETH_HLEN) + goto drop; + +- ctx = ezusb_alloc_ctx(upriv, EZUSB_RID_TX, 0); +- if (!ctx) +- goto busy; +- +- memset(ctx->buf, 0, BULK_BUF_SIZE); +- buf = ctx->buf->data; +- + tx_control = 0; + + err = orinoco_process_xmit_skb(skb, dev, priv, &tx_control, +@@ -1238,6 +1231,13 @@ static netdev_tx_t ezusb_xmit(struct sk_buff *skb, struct net_device *dev) + if (err) + goto drop; + ++ ctx = ezusb_alloc_ctx(upriv, EZUSB_RID_TX, 0); ++ if (!ctx) ++ goto drop; ++ ++ memset(ctx->buf, 0, BULK_BUF_SIZE); ++ buf = ctx->buf->data; ++ + { + __le16 *tx_cntl = (__le16 *)buf; + *tx_cntl = cpu_to_le16(tx_control); +-- +2.27.0 + diff --git a/queue-4.4/perf-record-fix-memory-leak-when-using-user-regs-to-.patch b/queue-4.4/perf-record-fix-memory-leak-when-using-user-regs-to-.patch new file mode 100644 index 00000000000..0b273df1538 --- /dev/null +++ b/queue-4.4/perf-record-fix-memory-leak-when-using-user-regs-to-.patch @@ -0,0 +1,45 @@ +From d4fc2e8aed6d75fd2ca6bae6b7d83c592bde68eb Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 3 Jul 2020 17:33:44 +0800 +Subject: =?UTF-8?q?perf=20record:=20Fix=20memory=20leak=20when=20using=20'?= + =?UTF-8?q?--user-regs=3D=3F'=20to=20list=20registers?= + +From: Zheng Zengkai + +[ Upstream commit 2eb5dd418034ecea2f7031e3d33f2991a878b148 ] + +When using 'perf record's option '-I' or '--user-regs=' along with +argument '?' to list available register names, memory of variable 'os' +allocated by strdup() needs to be released before __parse_regs() +returns, otherwise memory leak will occur. + +Fixes: bcc84ec65ad1 ("perf record: Add ability to name registers to record") +Signed-off-by: Zheng Zengkai +Acked-by: Jiri Olsa +Cc: Alexander Shishkin +Cc: Li Bin +Cc: Mark Rutland +Cc: Namhyung Kim +Link: https://lore.kernel.org/r/20200703093344.189450-1-zhengzengkai@huawei.com +Signed-off-by: Arnaldo Carvalho de Melo +Signed-off-by: Sasha Levin +--- + tools/perf/util/parse-regs-options.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tools/perf/util/parse-regs-options.c b/tools/perf/util/parse-regs-options.c +index 4f2c1c255d818..a8865d1c3e818 100644 +--- a/tools/perf/util/parse-regs-options.c ++++ b/tools/perf/util/parse-regs-options.c +@@ -40,7 +40,7 @@ parse_regs(const struct option *opt, const char *str, int unset) + } + fputc('\n', stderr); + /* just printing available regs */ +- return -1; ++ goto error; + } + for (r = sample_reg_masks; r->name; r++) { + if (!strcasecmp(s, r->name)) +-- +2.27.0 + diff --git a/queue-4.4/pinctrl-falcon-add-missing-put_device-call-in-pinctr.patch b/queue-4.4/pinctrl-falcon-add-missing-put_device-call-in-pinctr.patch new file mode 100644 index 00000000000..bf3f66bc20f --- /dev/null +++ b/queue-4.4/pinctrl-falcon-add-missing-put_device-call-in-pinctr.patch @@ -0,0 +1,64 @@ +From 944d4395465ea9466ec128f23d6d54f99cb9f924 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Thu, 19 Nov 2020 09:12:19 +0800 +Subject: pinctrl: falcon: add missing put_device() call in + pinctrl_falcon_probe() + +From: Yu Kuai + +[ Upstream commit 89cce2b3f247a434ee174ab6803698041df98014 ] + +if of_find_device_by_node() succeed, pinctrl_falcon_probe() doesn't have +a corresponding put_device(). Thus add put_device() to fix the exception +handling for this function implementation. + +Fixes: e316cb2b16bb ("OF: pinctrl: MIPS: lantiq: adds support for FALCON SoC") +Signed-off-by: Yu Kuai +Link: https://lore.kernel.org/r/20201119011219.2248232-1-yukuai3@huawei.com +Signed-off-by: Linus Walleij +Signed-off-by: Sasha Levin +--- + drivers/pinctrl/pinctrl-falcon.c | 14 +++++++++----- + 1 file changed, 9 insertions(+), 5 deletions(-) + +diff --git a/drivers/pinctrl/pinctrl-falcon.c b/drivers/pinctrl/pinctrl-falcon.c +index 0b0fc2eb48e0b..adcdb0585d398 100644 +--- a/drivers/pinctrl/pinctrl-falcon.c ++++ b/drivers/pinctrl/pinctrl-falcon.c +@@ -438,24 +438,28 @@ static int pinctrl_falcon_probe(struct platform_device *pdev) + + /* load and remap the pad resources of the different banks */ + for_each_compatible_node(np, NULL, "lantiq,pad-falcon") { +- struct platform_device *ppdev = of_find_device_by_node(np); + const __be32 *bank = of_get_property(np, "lantiq,bank", NULL); + struct resource res; ++ struct platform_device *ppdev; + u32 avail; + int pins; + + if (!of_device_is_available(np)) + continue; + +- if (!ppdev) { +- dev_err(&pdev->dev, "failed to find pad pdev\n"); +- continue; +- } + if (!bank || *bank >= PORTS) + continue; + if (of_address_to_resource(np, 0, &res)) + continue; ++ ++ ppdev = of_find_device_by_node(np); ++ if (!ppdev) { ++ dev_err(&pdev->dev, "failed to find pad pdev\n"); ++ continue; ++ } ++ + falcon_info.clk[*bank] = clk_get(&ppdev->dev, NULL); ++ put_device(&ppdev->dev); + if (IS_ERR(falcon_info.clk[*bank])) { + dev_err(&ppdev->dev, "failed to get clock\n"); + return PTR_ERR(falcon_info.clk[*bank]); +-- +2.27.0 + diff --git a/queue-4.4/powerpc-feature-fix-cpu_ftrs_always-by-removing-cpu_.patch b/queue-4.4/powerpc-feature-fix-cpu_ftrs_always-by-removing-cpu_.patch new file mode 100644 index 00000000000..399cd0938bf --- /dev/null +++ b/queue-4.4/powerpc-feature-fix-cpu_ftrs_always-by-removing-cpu_.patch @@ -0,0 +1,68 @@ +From 1adcccddc1c4413172f47f3d7e83a02b7f329e23 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 18:07:12 +0000 +Subject: powerpc/feature: Fix CPU_FTRS_ALWAYS by removing CPU_FTRS_GENERIC_32 + +From: Christophe Leroy + +[ Upstream commit 78665179e569c7e1fe102fb6c21d0f5b6951f084 ] + +On 8xx, we get the following features: + +[ 0.000000] cpu_features = 0x0000000000000100 +[ 0.000000] possible = 0x0000000000000120 +[ 0.000000] always = 0x0000000000000000 + +This is not correct. As CONFIG_PPC_8xx is mutually exclusive with all +other configurations, the three lines should be equal. + +The problem is due to CPU_FTRS_GENERIC_32 which is taken when +CONFIG_BOOK3S_32 is NOT selected. This CPU_FTRS_GENERIC_32 is +pointless because there is no generic configuration supporting +all 32 bits but book3s/32. + +Remove this pointless generic features definition to unbreak the +calculation of 'possible' features and 'always' features. + +Fixes: 76bc080ef5a3 ("[POWERPC] Make default cputable entries reflect selected CPU family") +Signed-off-by: Christophe Leroy +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/76a85f30bf981d1aeaae00df99321235494da254.1604426550.git.christophe.leroy@csgroup.eu +Signed-off-by: Sasha Levin +--- + arch/powerpc/include/asm/cputable.h | 5 ----- + 1 file changed, 5 deletions(-) + +diff --git a/arch/powerpc/include/asm/cputable.h b/arch/powerpc/include/asm/cputable.h +index b118072670fb1..9fe3f05000e31 100644 +--- a/arch/powerpc/include/asm/cputable.h ++++ b/arch/powerpc/include/asm/cputable.h +@@ -400,7 +400,6 @@ enum { + CPU_FTR_DBELL | CPU_FTR_POPCNTB | CPU_FTR_POPCNTD | \ + CPU_FTR_DEBUG_LVL_EXC | CPU_FTR_EMB_HV | CPU_FTR_ALTIVEC_COMP | \ + CPU_FTR_CELL_TB_BUG | CPU_FTR_SMT) +-#define CPU_FTRS_GENERIC_32 (CPU_FTR_COMMON | CPU_FTR_NODSISRALIGN) + + /* 64-bit CPUs */ + #define CPU_FTRS_POWER4 (CPU_FTR_USE_TB | CPU_FTR_LWSYNC | \ +@@ -479,8 +478,6 @@ enum { + CPU_FTRS_7447 | CPU_FTRS_7447A | CPU_FTRS_82XX | + CPU_FTRS_G2_LE | CPU_FTRS_E300 | CPU_FTRS_E300C2 | + CPU_FTRS_CLASSIC32 | +-#else +- CPU_FTRS_GENERIC_32 | + #endif + #ifdef CONFIG_8xx + CPU_FTRS_8XX | +@@ -530,8 +527,6 @@ enum { + CPU_FTRS_7447 & CPU_FTRS_7447A & CPU_FTRS_82XX & + CPU_FTRS_G2_LE & CPU_FTRS_E300 & CPU_FTRS_E300C2 & + CPU_FTRS_CLASSIC32 & +-#else +- CPU_FTRS_GENERIC_32 & + #endif + #ifdef CONFIG_8xx + CPU_FTRS_8XX & +-- +2.27.0 + diff --git a/queue-4.4/powerpc-ps3-use-dma_mapping_error.patch b/queue-4.4/powerpc-ps3-use-dma_mapping_error.patch new file mode 100644 index 00000000000..828cbd0f967 --- /dev/null +++ b/queue-4.4/powerpc-ps3-use-dma_mapping_error.patch @@ -0,0 +1,41 @@ +From 90416fbdf222f524ee47b3378d787753c8ffce83 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sun, 13 Dec 2020 19:26:22 +0100 +Subject: powerpc/ps3: use dma_mapping_error() +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +From: Vincent Stehlé + +[ Upstream commit d0edaa28a1f7830997131cbce87b6c52472825d1 ] + +The DMA address returned by dma_map_single() should be checked with +dma_mapping_error(). Fix the ps3stor_setup() function accordingly. + +Fixes: 80071802cb9c ("[POWERPC] PS3: Storage Driver Core") +Signed-off-by: Vincent Stehlé +Reviewed-by: Geert Uytterhoeven +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20201213182622.23047-1-vincent.stehle@laposte.net +Signed-off-by: Sasha Levin +--- + drivers/ps3/ps3stor_lib.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/ps3/ps3stor_lib.c b/drivers/ps3/ps3stor_lib.c +index 8c3f5adf1bc65..2d76183756626 100644 +--- a/drivers/ps3/ps3stor_lib.c ++++ b/drivers/ps3/ps3stor_lib.c +@@ -201,7 +201,7 @@ int ps3stor_setup(struct ps3_storage_device *dev, irq_handler_t handler) + dev->bounce_lpar = ps3_mm_phys_to_lpar(__pa(dev->bounce_buf)); + dev->bounce_dma = dma_map_single(&dev->sbd.core, dev->bounce_buf, + dev->bounce_size, DMA_BIDIRECTIONAL); +- if (!dev->bounce_dma) { ++ if (dma_mapping_error(&dev->sbd.core, dev->bounce_dma)) { + dev_err(&dev->sbd.core, "%s:%u: map DMA region failed\n", + __func__, __LINE__); + error = -ENODEV; +-- +2.27.0 + diff --git a/queue-4.4/powerpc-pseries-hibernation-drop-pseries_suspend_beg.patch b/queue-4.4/powerpc-pseries-hibernation-drop-pseries_suspend_beg.patch new file mode 100644 index 00000000000..c9bc7987992 --- /dev/null +++ b/queue-4.4/powerpc-pseries-hibernation-drop-pseries_suspend_beg.patch @@ -0,0 +1,73 @@ +From 8736d841fd5cad8de4e1da2ba161d6b33e46d2e9 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Dec 2020 15:51:49 -0600 +Subject: powerpc/pseries/hibernation: drop pseries_suspend_begin() from + suspend ops + +From: Nathan Lynch + +[ Upstream commit 52719fce3f4c7a8ac9eaa191e8d75a697f9fbcbc ] + +There are three ways pseries_suspend_begin() can be reached: + +1. When "mem" is written to /sys/power/state: + +kobj_attr_store() +-> state_store() + -> pm_suspend() + -> suspend_devices_and_enter() + -> pseries_suspend_begin() + +This never works because there is no way to supply a valid stream id +using this interface, and H_VASI_STATE is called with a stream id of +zero. So this call path is useless at best. + +2. When a stream id is written to /sys/devices/system/power/hibernate. +pseries_suspend_begin() is polled directly from store_hibernate() +until the stream is in the "Suspending" state (i.e. the platform is +ready for the OS to suspend execution): + +dev_attr_store() +-> store_hibernate() + -> pseries_suspend_begin() + +3. When a stream id is written to /sys/devices/system/power/hibernate +(continued). After #2, pseries_suspend_begin() is called once again +from the pm core: + +dev_attr_store() +-> store_hibernate() + -> pm_suspend() + -> suspend_devices_and_enter() + -> pseries_suspend_begin() + +This is redundant because the VASI suspend state is already known to +be Suspending. + +The begin() callback of platform_suspend_ops is optional, so we can +simply remove that assignment with no loss of function. + +Fixes: 32d8ad4e621d ("powerpc/pseries: Partition hibernation support") +Signed-off-by: Nathan Lynch +Signed-off-by: Michael Ellerman +Link: https://lore.kernel.org/r/20201207215200.1785968-18-nathanl@linux.ibm.com +Signed-off-by: Sasha Levin +--- + arch/powerpc/platforms/pseries/suspend.c | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/arch/powerpc/platforms/pseries/suspend.c b/arch/powerpc/platforms/pseries/suspend.c +index e76aefae2aa2b..0a0e0c8256f67 100644 +--- a/arch/powerpc/platforms/pseries/suspend.c ++++ b/arch/powerpc/platforms/pseries/suspend.c +@@ -224,7 +224,6 @@ static struct bus_type suspend_subsys = { + + static const struct platform_suspend_ops pseries_suspend_ops = { + .valid = suspend_valid_only_mem, +- .begin = pseries_suspend_begin, + .prepare_late = pseries_prepare_late, + .enter = pseries_suspend_enter, + }; +-- +2.27.0 + diff --git a/queue-4.4/qlcnic-fix-error-code-in-probe.patch b/queue-4.4/qlcnic-fix-error-code-in-probe.patch new file mode 100644 index 00000000000..88191dd407e --- /dev/null +++ b/queue-4.4/qlcnic-fix-error-code-in-probe.patch @@ -0,0 +1,36 @@ +From 272053a9769943f143a3cb033ddc983965c24f66 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 16 Dec 2020 11:38:04 +0300 +Subject: qlcnic: Fix error code in probe + +From: Dan Carpenter + +[ Upstream commit 0d52848632a357948028eab67ff9b7cc0c12a0fb ] + +Return -EINVAL if we can't find the correct device. Currently it +returns success. + +Fixes: 13159183ec7a ("qlcnic: 83xx base driver") +Signed-off-by: Dan Carpenter +Link: https://lore.kernel.org/r/X9nHbMqEyI/xPfGd@mwanda +Signed-off-by: Jakub Kicinski +Signed-off-by: Sasha Levin +--- + drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +index 1205f6f9c9417..a4b10776f8346 100644 +--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c ++++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +@@ -2506,6 +2506,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) + qlcnic_sriov_vf_register_map(ahw); + break; + default: ++ err = -EINVAL; + goto err_out_free_hw_res; + } + +-- +2.27.0 + diff --git a/queue-4.4/rdma-mthca-work-around-wenum-conversion-warning.patch b/queue-4.4/rdma-mthca-work-around-wenum-conversion-warning.patch new file mode 100644 index 00000000000..e9621330253 --- /dev/null +++ b/queue-4.4/rdma-mthca-work-around-wenum-conversion-warning.patch @@ -0,0 +1,61 @@ +From fb28aaa0c3fd198cb71a439fb2497357ce35e27a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 26 Oct 2020 22:12:30 +0100 +Subject: RDMa/mthca: Work around -Wenum-conversion warning + +From: Arnd Bergmann + +[ Upstream commit fbb7dc5db6dee553b5a07c27e86364a5223e244c ] + +gcc points out a suspicious mixing of enum types in a function that +converts from MTHCA_OPCODE_* values to IB_WC_* values: + +drivers/infiniband/hw/mthca/mthca_cq.c: In function 'mthca_poll_one': +drivers/infiniband/hw/mthca/mthca_cq.c:607:21: warning: implicit conversion from 'enum ' to 'enum ib_wc_opcode' [-Wenum-conversion] + 607 | entry->opcode = MTHCA_OPCODE_INVALID; + +Nothing seems to ever check for MTHCA_OPCODE_INVALID again, no idea if +this is meaningful, but it seems harmless as it deals with an invalid +input. + +Remove MTHCA_OPCODE_INVALID and set the ib_wc_opcode to 0xFF, which is +still bogus, but at least doesn't make compiler warnings. + +Fixes: 2a4443a69934 ("[PATCH] IB/mthca: fill in opcode field for send completions") +Link: https://lore.kernel.org/r/20201026211311.3887003-1-arnd@kernel.org +Signed-off-by: Arnd Bergmann +Signed-off-by: Jason Gunthorpe +Signed-off-by: Sasha Levin +--- + drivers/infiniband/hw/mthca/mthca_cq.c | 2 +- + drivers/infiniband/hw/mthca/mthca_dev.h | 1 - + 2 files changed, 1 insertion(+), 2 deletions(-) + +diff --git a/drivers/infiniband/hw/mthca/mthca_cq.c b/drivers/infiniband/hw/mthca/mthca_cq.c +index 59e1f6ea2ede9..1b0bb340281e6 100644 +--- a/drivers/infiniband/hw/mthca/mthca_cq.c ++++ b/drivers/infiniband/hw/mthca/mthca_cq.c +@@ -612,7 +612,7 @@ static inline int mthca_poll_one(struct mthca_dev *dev, + entry->opcode = IB_WC_BIND_MW; + break; + default: +- entry->opcode = MTHCA_OPCODE_INVALID; ++ entry->opcode = 0xFF; + break; + } + } else { +diff --git a/drivers/infiniband/hw/mthca/mthca_dev.h b/drivers/infiniband/hw/mthca/mthca_dev.h +index 4393a022867ba..e1fc67e73bf87 100644 +--- a/drivers/infiniband/hw/mthca/mthca_dev.h ++++ b/drivers/infiniband/hw/mthca/mthca_dev.h +@@ -105,7 +105,6 @@ enum { + MTHCA_OPCODE_ATOMIC_CS = 0x11, + MTHCA_OPCODE_ATOMIC_FA = 0x12, + MTHCA_OPCODE_BIND_MW = 0x18, +- MTHCA_OPCODE_INVALID = 0xff + }; + + enum { +-- +2.27.0 + diff --git a/queue-4.4/scsi-fnic-fix-error-return-code-in-fnic_probe.patch b/queue-4.4/scsi-fnic-fix-error-return-code-in-fnic_probe.patch new file mode 100644 index 00000000000..53ed75a1281 --- /dev/null +++ b/queue-4.4/scsi-fnic-fix-error-return-code-in-fnic_probe.patch @@ -0,0 +1,38 @@ +From c5ce44aabaf01ff06bbafa2e4644dc5a5c34a336 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Fri, 4 Dec 2020 15:47:39 +0800 +Subject: scsi: fnic: Fix error return code in fnic_probe() + +From: Zhang Changzhong + +[ Upstream commit d4fc94fe65578738ded138e9fce043db6bfc3241 ] + +Return a negative error code from the error handling case instead of 0 as +done elsewhere in this function. + +Link: https://lore.kernel.org/r/1607068060-31203-1-git-send-email-zhangchangzhong@huawei.com +Fixes: 5df6d737dd4b ("[SCSI] fnic: Add new Cisco PCI-Express FCoE HBA") +Reported-by: Hulk Robot +Reviewed-by: Karan Tilak Kumar +Signed-off-by: Zhang Changzhong +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/fnic/fnic_main.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c +index 58ce9020d69c5..389c13e1c9788 100644 +--- a/drivers/scsi/fnic/fnic_main.c ++++ b/drivers/scsi/fnic/fnic_main.c +@@ -735,6 +735,7 @@ static int fnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) + for (i = 0; i < FNIC_IO_LOCKS; i++) + spin_lock_init(&fnic->io_req_lock[i]); + ++ err = -ENOMEM; + fnic->io_req_pool = mempool_create_slab_pool(2, fnic_io_req_cache); + if (!fnic->io_req_pool) + goto err_out_free_resources; +-- +2.27.0 + diff --git a/queue-4.4/scsi-pm80xx-fix-error-return-in-pm8001_pci_probe.patch b/queue-4.4/scsi-pm80xx-fix-error-return-in-pm8001_pci_probe.patch new file mode 100644 index 00000000000..6521302ddca --- /dev/null +++ b/queue-4.4/scsi-pm80xx-fix-error-return-in-pm8001_pci_probe.patch @@ -0,0 +1,41 @@ +From 273240ae347a24c5f8d974c280ce0a907707d822 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 5 Dec 2020 19:55:51 +0800 +Subject: scsi: pm80xx: Fix error return in pm8001_pci_probe() + +From: Zhang Qilong + +[ Upstream commit 97031ccffa4f62728602bfea8439dd045cd3aeb2 ] + +The driver did not return an error in the case where +pm8001_configure_phy_settings() failed. + +Use rc to store the return value of pm8001_configure_phy_settings(). + +Link: https://lore.kernel.org/r/20201205115551.2079471-1-zhangqilong3@huawei.com +Fixes: 279094079a44 ("[SCSI] pm80xx: Phy settings support for motherboard controller.") +Acked-by: Jack Wang +Signed-off-by: Zhang Qilong +Signed-off-by: Martin K. Petersen +Signed-off-by: Sasha Levin +--- + drivers/scsi/pm8001/pm8001_init.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c +index 062ab34b86f8b..a982701bc3e0c 100644 +--- a/drivers/scsi/pm8001/pm8001_init.c ++++ b/drivers/scsi/pm8001/pm8001_init.c +@@ -1063,7 +1063,8 @@ static int pm8001_pci_probe(struct pci_dev *pdev, + + pm8001_init_sas_add(pm8001_ha); + /* phy setting support for motherboard controller */ +- if (pm8001_configure_phy_settings(pm8001_ha)) ++ rc = pm8001_configure_phy_settings(pm8001_ha); ++ if (rc) + goto err_out_shost; + + pm8001_post_sas_ha_init(shost, chip); +-- +2.27.0 + diff --git a/queue-4.4/seq_buf-avoid-type-mismatch-for-seq_buf_init.patch b/queue-4.4/seq_buf-avoid-type-mismatch-for-seq_buf_init.patch new file mode 100644 index 00000000000..f5b472afbd7 --- /dev/null +++ b/queue-4.4/seq_buf-avoid-type-mismatch-for-seq_buf_init.patch @@ -0,0 +1,68 @@ +From 83d34b734877f4f54c9699dce1378a40f22c2d17 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 26 Oct 2020 17:10:58 +0100 +Subject: seq_buf: Avoid type mismatch for seq_buf_init + +From: Arnd Bergmann + +[ Upstream commit d9a9280a0d0ae51dc1d4142138b99242b7ec8ac6 ] + +Building with W=2 prints a number of warnings for one function that +has a pointer type mismatch: + +linux/seq_buf.h: In function 'seq_buf_init': +linux/seq_buf.h:35:12: warning: pointer targets in assignment from 'unsigned char *' to 'char *' differ in signedness [-Wpointer-sign] + +Change the type in the function prototype according to the type in +the structure. + +Link: https://lkml.kernel.org/r/20201026161108.3707783-1-arnd@kernel.org + +Fixes: 9a7777935c34 ("tracing: Convert seq_buf fields to be like seq_file fields") +Reviewed-by: Cezary Rojewski +Signed-off-by: Arnd Bergmann +Signed-off-by: Steven Rostedt (VMware) +Signed-off-by: Sasha Levin +--- + include/linux/seq_buf.h | 2 +- + include/linux/trace_seq.h | 4 ++-- + 2 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/include/linux/seq_buf.h b/include/linux/seq_buf.h +index fb7eb9ccb1cd4..d4c3c9bab5826 100644 +--- a/include/linux/seq_buf.h ++++ b/include/linux/seq_buf.h +@@ -29,7 +29,7 @@ static inline void seq_buf_clear(struct seq_buf *s) + } + + static inline void +-seq_buf_init(struct seq_buf *s, unsigned char *buf, unsigned int size) ++seq_buf_init(struct seq_buf *s, char *buf, unsigned int size) + { + s->buffer = buf; + s->size = size; +diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h +index cfaf5a1d4bad7..f5be2716b01c6 100644 +--- a/include/linux/trace_seq.h ++++ b/include/linux/trace_seq.h +@@ -11,7 +11,7 @@ + */ + + struct trace_seq { +- unsigned char buffer[PAGE_SIZE]; ++ char buffer[PAGE_SIZE]; + struct seq_buf seq; + int full; + }; +@@ -50,7 +50,7 @@ static inline int trace_seq_used(struct trace_seq *s) + * that is about to be written to and then return the result + * of that write. + */ +-static inline unsigned char * ++static inline char * + trace_seq_buffer_ptr(struct trace_seq *s) + { + return s->buffer + seq_buf_used(&s->seq); +-- +2.27.0 + diff --git a/queue-4.4/series b/queue-4.4/series index c34573fb59c..b9907191d35 100644 --- a/queue-4.4/series +++ b/queue-4.4/series @@ -29,3 +29,68 @@ usb-gadget-f_rndis-fix-bitrate-for-superspeed-and-above.patch usb-chipidea-ci_hdrc_imx-pass-disable_device_streaming-flag-to-imx6ul.patch media-msi2500-assign-spi-bus-number-dynamically.patch bluetooth-fix-slab-out-of-bounds-read-in-hci_le_direct_adv_report_evt.patch +drm-gma500-fix-double-free-of-gma_connector.patch +arm-p2v-fix-handling-of-lpae-translation-in-be-mode.patch +crypto-talitos-fix-return-type-of-current_desc_hdr.patch +spi-img-spfi-fix-reference-leak-in-img_spfi_resume.patch +asoc-pcm-drain-support-reactivation.patch +bluetooth-fix-null-pointer-dereference-in-hci_event_.patch +spi-spi-ti-qspi-fix-reference-leak-in-ti_qspi_setup.patch +spi-tegra20-slink-fix-reference-leak-in-slink-ops-of.patch +spi-tegra20-sflash-fix-reference-leak-in-tegra_sflas.patch +spi-tegra114-fix-reference-leak-in-tegra-spi-ops.patch +net-evaluate-net.ipvx.conf.all.ignore_routes_with_li.patch +net-evaluate-net.ipv4.conf.all.proxy_arp_pvlan.patch +rdma-mthca-work-around-wenum-conversion-warning.patch +mips-bcm47xx-fix-kconfig-dependency-bug-for-bcm47xx_.patch +media-solo6x10-fix-missing-snd_card_free-in-error-ha.patch +drm-omap-dmm_tiler-fix-return-error-code-in-omap_dmm.patch +input-ads7846-fix-integer-overflow-on-rt-calculation.patch +input-ads7846-fix-unaligned-access-on-7845.patch +powerpc-feature-fix-cpu_ftrs_always-by-removing-cpu_.patch +soc-ti-knav_qmss-fix-reference-leak-in-knav_queue_pr.patch +soc-ti-fix-reference-imbalance-in-knav_dma_probe.patch +drivers-soc-ti-knav_qmss_queue-fix-error-return-code.patch +memstick-fix-a-double-free-bug-in-memstick_check.patch +arm-dts-at91-sama5d4_xplained-add-pincontrol-for-usb.patch +arm-dts-at91-sama5d3_xplained-add-pincontrol-for-usb.patch +orinoco-move-context-allocation-after-processing-the.patch +cw1200-fix-missing-destroy_workqueue-on-error-in-cw1.patch +mips-cdmm-fix-use-after-free-in-mips_cdmm_bus_discov.patch +nfsv4.2-condition-readdir-s-mask-for-security-label-.patch +lockd-don-t-use-interval-based-rebinding-over-tcp.patch +nfs-switch-nfsiod-to-be-an-unbound-workqueue.patch +media-saa7146-fix-array-overflow-in-vidioc_s_audio.patch +pinctrl-falcon-add-missing-put_device-call-in-pinctr.patch +memstick-r592-fix-error-return-in-r592_probe.patch +asoc-jz4740-i2s-add-missed-checks-for-clk_get.patch +dm-ioctl-fix-error-return-code-in-target_message.patch +clocksource-drivers-arm_arch_timer-correct-fault-pro.patch +cpufreq-highbank-add-missing-module_device_table.patch +cpufreq-loongson1-add-missing-module_alias.patch +cpufreq-scpi-add-missing-module_alias.patch +scsi-pm80xx-fix-error-return-in-pm8001_pci_probe.patch +seq_buf-avoid-type-mismatch-for-seq_buf_init.patch +scsi-fnic-fix-error-return-code-in-fnic_probe.patch +powerpc-pseries-hibernation-drop-pseries_suspend_beg.patch +usb-ehci-omap-fix-pm-disable-depth-umbalance-in-ehci.patch +usb-oxu210hp-hcd-fix-memory-leak-in-oxu_create.patch +speakup-fix-uninitialized-flush_lock.patch +nfs_common-need-lock-during-iterate-through-the-list.patch +x86-kprobes-restore-btf-if-the-single-stepping-is-ca.patch +extcon-max77693-fix-modalias-string.patch +asoc-wm_adsp-remove-ctl-from-list-on-error-in-wm_ads.patch +um-chan_xterm-fix-fd-leak.patch +nfc-s3fwrn5-release-the-nfc-firmware.patch +powerpc-ps3-use-dma_mapping_error.patch +checkpatch-fix-unescaped-left-brace.patch +net-bcmgenet-fix-a-resource-leak-in-an-error-handlin.patch +net-allwinner-fix-some-resources-leak-in-the-error-h.patch +net-korina-fix-return-value.patch +clk-ti-fix-memleak-in-ti_fapll_synth_setup.patch +perf-record-fix-memory-leak-when-using-user-regs-to-.patch +qlcnic-fix-error-code-in-probe.patch +clk-s2mps11-fix-a-resource-leak-in-error-handling-pa.patch +cfg80211-initialize-rekey_data.patch +input-cros_ec_keyb-send-scancodes-in-addition-to-key.patch +input-goodix-add-upside-down-quirk-for-teclast-x98-p.patch diff --git a/queue-4.4/soc-ti-fix-reference-imbalance-in-knav_dma_probe.patch b/queue-4.4/soc-ti-fix-reference-imbalance-in-knav_dma_probe.patch new file mode 100644 index 00000000000..b27227afabf --- /dev/null +++ b/queue-4.4/soc-ti-fix-reference-imbalance-in-knav_dma_probe.patch @@ -0,0 +1,72 @@ +From 8af77734a3955335dc4ec8830a30fc72862f7a29 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 21 Nov 2020 19:22:37 -0800 +Subject: soc: ti: Fix reference imbalance in knav_dma_probe + +From: Zhang Qilong + +[ Upstream commit b4fa73358c306d747a2200aec6f7acb97e5750e6 ] + +The patch fix two reference leak. + + 1) pm_runtime_get_sync will increment pm usage counter even it + failed. Forgetting to call put operation will result in + reference leak. + + 2) The pm_runtime_enable will increase power disable depth. Thus + a pairing decrement is needed on the error handling path to + keep it balanced. + +We fix it by: 1) adding call pm_runtime_put_noidle or +pm_runtime_put_sync in error handling. 2) adding pm_runtime_disable +in error handling, to keep usage counter and disable depth balanced. + +Fixes: 88139ed030583 ("soc: ti: add Keystone Navigator DMA support") +Signed-off-by: Zhang Qilong +Signed-off-by: Santosh Shilimkar +Signed-off-by: Sasha Levin +--- + drivers/soc/ti/knav_dma.c | 13 +++++++++++-- + 1 file changed, 11 insertions(+), 2 deletions(-) + +diff --git a/drivers/soc/ti/knav_dma.c b/drivers/soc/ti/knav_dma.c +index bc1b80ec6afe3..838b87adf48bb 100644 +--- a/drivers/soc/ti/knav_dma.c ++++ b/drivers/soc/ti/knav_dma.c +@@ -752,8 +752,9 @@ static int knav_dma_probe(struct platform_device *pdev) + pm_runtime_enable(kdev->dev); + ret = pm_runtime_get_sync(kdev->dev); + if (ret < 0) { ++ pm_runtime_put_noidle(kdev->dev); + dev_err(kdev->dev, "unable to enable pktdma, err %d\n", ret); +- return ret; ++ goto err_pm_disable; + } + + /* Initialise all packet dmas */ +@@ -767,13 +768,21 @@ static int knav_dma_probe(struct platform_device *pdev) + + if (list_empty(&kdev->list)) { + dev_err(dev, "no valid dma instance\n"); +- return -ENODEV; ++ ret = -ENODEV; ++ goto err_put_sync; + } + + debugfs_create_file("knav_dma", S_IFREG | S_IRUGO, NULL, NULL, + &knav_dma_debug_ops); + + return ret; ++ ++err_put_sync: ++ pm_runtime_put_sync(kdev->dev); ++err_pm_disable: ++ pm_runtime_disable(kdev->dev); ++ ++ return ret; + } + + static int knav_dma_remove(struct platform_device *pdev) +-- +2.27.0 + diff --git a/queue-4.4/soc-ti-knav_qmss-fix-reference-leak-in-knav_queue_pr.patch b/queue-4.4/soc-ti-knav_qmss-fix-reference-leak-in-knav_queue_pr.patch new file mode 100644 index 00000000000..743ce6a0bfa --- /dev/null +++ b/queue-4.4/soc-ti-knav_qmss-fix-reference-leak-in-knav_queue_pr.patch @@ -0,0 +1,36 @@ +From 2f166f16cc4811d2e29c294cedde92ea89f854b0 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Sat, 21 Nov 2020 19:22:00 -0800 +Subject: soc: ti: knav_qmss: fix reference leak in knav_queue_probe + +From: Zhang Qilong + +[ Upstream commit ec8684847d8062496c4619bc3fcff31c19d56847 ] + +pm_runtime_get_sync will increment pm usage counter even it +failed. Forgetting to pm_runtime_put_noidle will result in +reference leak in knav_queue_probe, so we should fix it. + +Fixes: 41f93af900a20 ("soc: ti: add Keystone Navigator QMSS driver") +Signed-off-by: Zhang Qilong +Signed-off-by: Santosh Shilimkar +Signed-off-by: Sasha Levin +--- + drivers/soc/ti/knav_qmss_queue.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c +index 8c03a80b482dd..3a3bc8ef532a7 100644 +--- a/drivers/soc/ti/knav_qmss_queue.c ++++ b/drivers/soc/ti/knav_qmss_queue.c +@@ -1717,6 +1717,7 @@ static int knav_queue_probe(struct platform_device *pdev) + pm_runtime_enable(&pdev->dev); + ret = pm_runtime_get_sync(&pdev->dev); + if (ret < 0) { ++ pm_runtime_put_noidle(&pdev->dev); + dev_err(dev, "Failed to enable QMSS\n"); + return ret; + } +-- +2.27.0 + diff --git a/queue-4.4/speakup-fix-uninitialized-flush_lock.patch b/queue-4.4/speakup-fix-uninitialized-flush_lock.patch new file mode 100644 index 00000000000..badd934a856 --- /dev/null +++ b/queue-4.4/speakup-fix-uninitialized-flush_lock.patch @@ -0,0 +1,39 @@ +From fce0f39e164f5704caf4fb854ad1805408e03677 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 17 Nov 2020 09:22:29 +0800 +Subject: speakup: fix uninitialized flush_lock + +From: Yang Yingliang + +[ Upstream commit d1b928ee1cfa965a3327bbaa59bfa005d97fa0fe ] + +The flush_lock is uninitialized, use DEFINE_SPINLOCK +to define and initialize flush_lock. + +Fixes: c6e3fd22cd53 ("Staging: add speakup to the staging directory") +Reported-by: Hulk Robot +Reviewed-by: Samuel Thibault +Signed-off-by: Yang Yingliang +Link: https://lore.kernel.org/r/20201117012229.3395186-1-yangyingliang@huawei.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/staging/speakup/speakup_dectlk.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/drivers/staging/speakup/speakup_dectlk.c b/drivers/staging/speakup/speakup_dectlk.c +index 09063b82326f1..71aa623facd69 100644 +--- a/drivers/staging/speakup/speakup_dectlk.c ++++ b/drivers/staging/speakup/speakup_dectlk.c +@@ -51,7 +51,7 @@ static unsigned char get_index(void); + static int in_escape; + static int is_flushing; + +-static spinlock_t flush_lock; ++static DEFINE_SPINLOCK(flush_lock); + static DECLARE_WAIT_QUEUE_HEAD(flush); + + static struct var_t vars[] = { +-- +2.27.0 + diff --git a/queue-4.4/spi-img-spfi-fix-reference-leak-in-img_spfi_resume.patch b/queue-4.4/spi-img-spfi-fix-reference-leak-in-img_spfi_resume.patch new file mode 100644 index 00000000000..f031c65f681 --- /dev/null +++ b/queue-4.4/spi-img-spfi-fix-reference-leak-in-img_spfi_resume.patch @@ -0,0 +1,41 @@ +From fe3f8eba0ba5af82a6775b4c90368fe9ba51142a Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 2 Nov 2020 22:56:51 +0800 +Subject: spi: img-spfi: fix reference leak in img_spfi_resume + +From: Zhang Qilong + +[ Upstream commit ee5558a9084584015c8754ffd029ce14a5827fa8 ] + +pm_runtime_get_sync will increment pm usage counter even it +failed. Forgetting to pm_runtime_put_noidle will result in +reference leak in img_spfi_resume, so we should fix it. + +Fixes: deba25800a12b ("spi: Add driver for IMG SPFI controller") +Signed-off-by: Zhang Qilong +Link: https://lore.kernel.org/r/20201102145651.3875-1-zhangqilong3@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-img-spfi.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/spi/spi-img-spfi.c b/drivers/spi/spi-img-spfi.c +index c46c0738c7340..e58319e58ba4b 100644 +--- a/drivers/spi/spi-img-spfi.c ++++ b/drivers/spi/spi-img-spfi.c +@@ -773,8 +773,10 @@ static int img_spfi_resume(struct device *dev) + int ret; + + ret = pm_runtime_get_sync(dev); +- if (ret) ++ if (ret) { ++ pm_runtime_put_noidle(dev); + return ret; ++ } + spfi_reset(spfi); + pm_runtime_put(dev); + +-- +2.27.0 + diff --git a/queue-4.4/spi-spi-ti-qspi-fix-reference-leak-in-ti_qspi_setup.patch b/queue-4.4/spi-spi-ti-qspi-fix-reference-leak-in-ti_qspi_setup.patch new file mode 100644 index 00000000000..31dc86ac7c0 --- /dev/null +++ b/queue-4.4/spi-spi-ti-qspi-fix-reference-leak-in-ti_qspi_setup.patch @@ -0,0 +1,37 @@ +From a5f40cd1d0a84ec68c74a841678b3a3435c8fae7 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 22:09:47 +0800 +Subject: spi: spi-ti-qspi: fix reference leak in ti_qspi_setup + +From: Zhang Qilong + +[ Upstream commit 45c0cba753641e5d7c3207f04241bd0e7a021698 ] + +pm_runtime_get_sync will increment pm usage counter even it +failed. Forgetting to pm_runtime_put_noidle will result in +reference leak in ti_qspi_setup, so we should fix it. + +Fixes: 505a14954e2d7 ("spi/qspi: Add qspi flash controller") +Signed-off-by: Zhang Qilong +Link: https://lore.kernel.org/r/20201103140947.3815-1-zhangqilong3@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-ti-qspi.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c +index 5044c61983324..6e97f71a8cea3 100644 +--- a/drivers/spi/spi-ti-qspi.c ++++ b/drivers/spi/spi-ti-qspi.c +@@ -159,6 +159,7 @@ static int ti_qspi_setup(struct spi_device *spi) + + ret = pm_runtime_get_sync(qspi->dev); + if (ret < 0) { ++ pm_runtime_put_noidle(qspi->dev); + dev_err(qspi->dev, "pm_runtime_get_sync() failed\n"); + return ret; + } +-- +2.27.0 + diff --git a/queue-4.4/spi-tegra114-fix-reference-leak-in-tegra-spi-ops.patch b/queue-4.4/spi-tegra114-fix-reference-leak-in-tegra-spi-ops.patch new file mode 100644 index 00000000000..c9c35b0d9aa --- /dev/null +++ b/queue-4.4/spi-tegra114-fix-reference-leak-in-tegra-spi-ops.patch @@ -0,0 +1,46 @@ +From 182ee68d102a8d5bdcd19f2004fddb258005ef72 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 22:13:06 +0800 +Subject: spi: tegra114: fix reference leak in tegra spi ops + +From: Zhang Qilong + +[ Upstream commit a042184c7fb99961ea083d4ec192614bec671969 ] + +pm_runtime_get_sync will increment pm usage counter even it +failed. Forgetting to pm_runtime_put_noidle will result in +reference leak in two callers(tegra_spi_setup and +tegra_spi_resume), so we should fix it. + +Fixes: f333a331adfac ("spi/tegra114: add spi driver") +Signed-off-by: Zhang Qilong +Link: https://lore.kernel.org/r/20201103141306.5607-1-zhangqilong3@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-tegra114.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c +index e37712bed0b2d..d1ca8f619b828 100644 +--- a/drivers/spi/spi-tegra114.c ++++ b/drivers/spi/spi-tegra114.c +@@ -801,6 +801,7 @@ static int tegra_spi_setup(struct spi_device *spi) + + ret = pm_runtime_get_sync(tspi->dev); + if (ret < 0) { ++ pm_runtime_put_noidle(tspi->dev); + dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret); + return ret; + } +@@ -1214,6 +1215,7 @@ static int tegra_spi_resume(struct device *dev) + + ret = pm_runtime_get_sync(dev); + if (ret < 0) { ++ pm_runtime_put_noidle(dev); + dev_err(dev, "pm runtime failed, e = %d\n", ret); + return ret; + } +-- +2.27.0 + diff --git a/queue-4.4/spi-tegra20-sflash-fix-reference-leak-in-tegra_sflas.patch b/queue-4.4/spi-tegra20-sflash-fix-reference-leak-in-tegra_sflas.patch new file mode 100644 index 00000000000..4005e9e82b7 --- /dev/null +++ b/queue-4.4/spi-tegra20-sflash-fix-reference-leak-in-tegra_sflas.patch @@ -0,0 +1,37 @@ +From 5b2c304ddea46ba81c296fa6424336d7b2e8e752 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 22:13:23 +0800 +Subject: spi: tegra20-sflash: fix reference leak in tegra_sflash_resume + +From: Zhang Qilong + +[ Upstream commit 3482e797ab688da6703fe18d8bad52f94199f4f2 ] + +pm_runtime_get_sync will increment pm usage counter even it +failed. Forgetting to pm_runtime_put_noidle will result in +reference leak in tegra_sflash_resume, so we should fix it. + +Fixes: 8528547bcc336 ("spi: tegra: add spi driver for sflash controller") +Signed-off-by: Zhang Qilong +Link: https://lore.kernel.org/r/20201103141323.5841-1-zhangqilong3@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-tegra20-sflash.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/spi/spi-tegra20-sflash.c b/drivers/spi/spi-tegra20-sflash.c +index b6558bb6f9dfc..4b9541e1726a5 100644 +--- a/drivers/spi/spi-tegra20-sflash.c ++++ b/drivers/spi/spi-tegra20-sflash.c +@@ -564,6 +564,7 @@ static int tegra_sflash_resume(struct device *dev) + + ret = pm_runtime_get_sync(dev); + if (ret < 0) { ++ pm_runtime_put_noidle(dev); + dev_err(dev, "pm runtime failed, e = %d\n", ret); + return ret; + } +-- +2.27.0 + diff --git a/queue-4.4/spi-tegra20-slink-fix-reference-leak-in-slink-ops-of.patch b/queue-4.4/spi-tegra20-slink-fix-reference-leak-in-slink-ops-of.patch new file mode 100644 index 00000000000..b6498d45302 --- /dev/null +++ b/queue-4.4/spi-tegra20-slink-fix-reference-leak-in-slink-ops-of.patch @@ -0,0 +1,46 @@ +From 42482c1e81afcb1cb92fca1a4de4746bf3af69e1 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Tue, 3 Nov 2020 22:13:45 +0800 +Subject: spi: tegra20-slink: fix reference leak in slink ops of tegra20 + +From: Zhang Qilong + +[ Upstream commit 763eab7074f6e71babd85d796156f05a675f9510 ] + +pm_runtime_get_sync will increment pm usage counter even it +failed. Forgetting to pm_runtime_put_noidle will result in +reference leak in two callers(tegra_slink_setup and +tegra_slink_resume), so we should fix it. + +Fixes: dc4dc36056392 ("spi: tegra: add spi driver for SLINK controller") +Signed-off-by: Zhang Qilong +Link: https://lore.kernel.org/r/20201103141345.6188-1-zhangqilong3@huawei.com +Signed-off-by: Mark Brown +Signed-off-by: Sasha Levin +--- + drivers/spi/spi-tegra20-slink.c | 2 ++ + 1 file changed, 2 insertions(+) + +diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c +index cf2a329fd8958..9f14560686b68 100644 +--- a/drivers/spi/spi-tegra20-slink.c ++++ b/drivers/spi/spi-tegra20-slink.c +@@ -761,6 +761,7 @@ static int tegra_slink_setup(struct spi_device *spi) + + ret = pm_runtime_get_sync(tspi->dev); + if (ret < 0) { ++ pm_runtime_put_noidle(tspi->dev); + dev_err(tspi->dev, "pm runtime failed, e = %d\n", ret); + return ret; + } +@@ -1197,6 +1198,7 @@ static int tegra_slink_resume(struct device *dev) + + ret = pm_runtime_get_sync(dev); + if (ret < 0) { ++ pm_runtime_put_noidle(dev); + dev_err(dev, "pm runtime failed, e = %d\n", ret); + return ret; + } +-- +2.27.0 + diff --git a/queue-4.4/um-chan_xterm-fix-fd-leak.patch b/queue-4.4/um-chan_xterm-fix-fd-leak.patch new file mode 100644 index 00000000000..3ddd741a5b5 --- /dev/null +++ b/queue-4.4/um-chan_xterm-fix-fd-leak.patch @@ -0,0 +1,66 @@ +From 1842ec45805d6c50cde5eacfb4e64749410c2598 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 7 Dec 2020 17:19:40 +0000 +Subject: um: chan_xterm: Fix fd leak + +From: Anton Ivanov + +[ Upstream commit 9431f7c199ab0d02da1482d62255e0b4621cb1b5 ] + +xterm serial channel was leaking a fd used in setting up the +port helper + +This bug is prehistoric - it predates switching to git. The "fixes" +header here is really just to mark all the versions we would like this to +apply to which is "Anything from the Cretaceous period onwards". + +No dinosaurs were harmed in fixing this bug. + +Fixes: b40997b872cd ("um: drivers/xterm.c: fix a file descriptor leak") +Signed-off-by: Anton Ivanov +Signed-off-by: Richard Weinberger +Signed-off-by: Sasha Levin +--- + arch/um/drivers/xterm.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/arch/um/drivers/xterm.c b/arch/um/drivers/xterm.c +index 20e30be44795b..e3b422ebce09f 100644 +--- a/arch/um/drivers/xterm.c ++++ b/arch/um/drivers/xterm.c +@@ -18,6 +18,7 @@ + struct xterm_chan { + int pid; + int helper_pid; ++ int chan_fd; + char *title; + int device; + int raw; +@@ -33,6 +34,7 @@ static void *xterm_init(char *str, int device, const struct chan_opts *opts) + return NULL; + *data = ((struct xterm_chan) { .pid = -1, + .helper_pid = -1, ++ .chan_fd = -1, + .device = device, + .title = opts->xterm_title, + .raw = opts->raw } ); +@@ -149,6 +151,7 @@ static int xterm_open(int input, int output, int primary, void *d, + goto out_kill; + } + ++ data->chan_fd = fd; + new = xterm_fd(fd, &data->helper_pid); + if (new < 0) { + err = new; +@@ -206,6 +209,8 @@ static void xterm_close(int fd, void *d) + os_kill_process(data->helper_pid, 0); + data->helper_pid = -1; + ++ if (data->chan_fd != -1) ++ os_close_file(data->chan_fd); + os_close_file(fd); + } + +-- +2.27.0 + diff --git a/queue-4.4/usb-ehci-omap-fix-pm-disable-depth-umbalance-in-ehci.patch b/queue-4.4/usb-ehci-omap-fix-pm-disable-depth-umbalance-in-ehci.patch new file mode 100644 index 00000000000..3a752c73b53 --- /dev/null +++ b/queue-4.4/usb-ehci-omap-fix-pm-disable-depth-umbalance-in-ehci.patch @@ -0,0 +1,39 @@ +From fb7c32a6073b72046d7bbc3acf2e65dcd372589f Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 23 Nov 2020 22:57:19 +0800 +Subject: usb: ehci-omap: Fix PM disable depth umbalance in ehci_hcd_omap_probe + +From: Zhang Qilong + +[ Upstream commit d6ff32478d7e95d6ca199b5c852710d6964d5811 ] + +The pm_runtime_enable will decrement the power disable depth. Imbalance +depth will resulted in enabling runtime PM of device fails later. Thus +a pairing decrement must be needed on the error handling path to keep it +balanced. + +Fixes: 6c984b066d84b ("ARM: OMAP: USBHOST: Replace usbhs core driver APIs by Runtime pm APIs") +Acked-by: Alan Stern +Signed-off-by: Zhang Qilong +Link: https://lore.kernel.org/r/20201123145719.1455849-1-zhangqilong3@huawei.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/usb/host/ehci-omap.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c +index cccde8217f288..8e0625cc1801b 100644 +--- a/drivers/usb/host/ehci-omap.c ++++ b/drivers/usb/host/ehci-omap.c +@@ -237,6 +237,7 @@ static int ehci_hcd_omap_probe(struct platform_device *pdev) + + err_pm_runtime: + pm_runtime_put_sync(dev); ++ pm_runtime_disable(dev); + + err_phy: + for (i = 0; i < omap->nports; i++) { +-- +2.27.0 + diff --git a/queue-4.4/usb-oxu210hp-hcd-fix-memory-leak-in-oxu_create.patch b/queue-4.4/usb-oxu210hp-hcd-fix-memory-leak-in-oxu_create.patch new file mode 100644 index 00000000000..53b7963fef1 --- /dev/null +++ b/queue-4.4/usb-oxu210hp-hcd-fix-memory-leak-in-oxu_create.patch @@ -0,0 +1,42 @@ +From 9711ec455b1c419f63afeff286e7fc86b9564cd3 Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Mon, 23 Nov 2020 22:58:09 +0800 +Subject: usb: oxu210hp-hcd: Fix memory leak in oxu_create + +From: Zhang Qilong + +[ Upstream commit e5548b05631ec3e6bfdaef1cad28c799545b791b ] + +usb_create_hcd will alloc memory for hcd, and we should +call usb_put_hcd to free it when adding fails to prevent +memory leak. + +Fixes: b92a78e582b1a ("usb host: Oxford OXU210HP HCD driver") +Reported-by: Hulk Robot +Signed-off-by: Zhang Qilong +Link: https://lore.kernel.org/r/20201123145809.1456541-1-zhangqilong3@huawei.com +Signed-off-by: Greg Kroah-Hartman +Signed-off-by: Sasha Levin +--- + drivers/usb/host/oxu210hp-hcd.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c +index 1f139d82cee08..d1e0d9d4e7a60 100644 +--- a/drivers/usb/host/oxu210hp-hcd.c ++++ b/drivers/usb/host/oxu210hp-hcd.c +@@ -3741,8 +3741,10 @@ static struct usb_hcd *oxu_create(struct platform_device *pdev, + oxu->is_otg = otg; + + ret = usb_add_hcd(hcd, irq, IRQF_SHARED); +- if (ret < 0) ++ if (ret < 0) { ++ usb_put_hcd(hcd); + return ERR_PTR(ret); ++ } + + device_wakeup_enable(hcd->self.controller); + return hcd; +-- +2.27.0 + diff --git a/queue-4.4/x86-kprobes-restore-btf-if-the-single-stepping-is-ca.patch b/queue-4.4/x86-kprobes-restore-btf-if-the-single-stepping-is-ca.patch new file mode 100644 index 00000000000..c5924c7587e --- /dev/null +++ b/queue-4.4/x86-kprobes-restore-btf-if-the-single-stepping-is-ca.patch @@ -0,0 +1,46 @@ +From 897b56b088ce8b8a1f6f44336e6303275b70b1be Mon Sep 17 00:00:00 2001 +From: Sasha Levin +Date: Wed, 28 Oct 2020 23:31:10 +0900 +Subject: x86/kprobes: Restore BTF if the single-stepping is cancelled + +From: Masami Hiramatsu + +[ Upstream commit 78ff2733ff352175eb7f4418a34654346e1b6cd2 ] + +Fix to restore BTF if single-stepping causes a page fault and +it is cancelled. + +Usually the BTF flag was restored when the single stepping is done +(in resume_execution()). However, if a page fault happens on the +single stepping instruction, the fault handler is invoked and +the single stepping is cancelled. Thus, the BTF flag is not +restored. + +Fixes: 1ecc798c6764 ("x86: debugctlmsr kprobes") +Signed-off-by: Masami Hiramatsu +Signed-off-by: Peter Zijlstra (Intel) +Link: https://lkml.kernel.org/r/160389546985.106936.12727996109376240993.stgit@devnote2 +Signed-off-by: Sasha Levin +--- + arch/x86/kernel/kprobes/core.c | 5 +++++ + 1 file changed, 5 insertions(+) + +diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c +index 5a6cb30b1c621..ebd4da00a56ea 100644 +--- a/arch/x86/kernel/kprobes/core.c ++++ b/arch/x86/kernel/kprobes/core.c +@@ -1014,6 +1014,11 @@ int kprobe_fault_handler(struct pt_regs *regs, int trapnr) + * So clear it by resetting the current kprobe: + */ + regs->flags &= ~X86_EFLAGS_TF; ++ /* ++ * Since the single step (trap) has been cancelled, ++ * we need to restore BTF here. ++ */ ++ restore_btf(); + + /* + * If the TF flag was set before the kprobe hit, +-- +2.27.0 + -- 2.47.3