From 5aa0cb0ea490a426dd9e8a581ee408d7f3a35340 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 14 Nov 2024 20:48:14 +0100 Subject: [PATCH] smbpasswd4: Simplify smbpasswd_sethexpwd() Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme --- source4/lib/samba3/smbpasswd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/source4/lib/samba3/smbpasswd.c b/source4/lib/samba3/smbpasswd.c index 6f4d832ae2b..d0b7e9dbd48 100644 --- a/source4/lib/samba3/smbpasswd.c +++ b/source4/lib/samba3/smbpasswd.c @@ -89,11 +89,7 @@ char *smbpasswd_sethexpwd(TALLOC_CTX *mem_ctx, struct samr_Password *pwd, uint16 { char *p; if (pwd != NULL) { - p = talloc_array(mem_ctx, char, 33); - if (!p) { - return NULL; - } - hex_encode_buf(p, pwd->hash, sizeof(pwd->hash)); + p = hex_encode_talloc(mem_ctx, pwd->hash, sizeof(pwd->hash)); } else { if (acb_info & ACB_PWNOTREQ) p = talloc_strdup(mem_ctx, "NO PASSWORDXXXXXXXXXXXXXXXXXXXXX"); -- 2.47.3