From 5ef3b6deba421b55b4d84c333e3316d9d024df14 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Tue, 24 Nov 2020 17:42:24 +0100 Subject: [PATCH] s3:lib: Check return code of set_blocking() Found by covscan. Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett --- source3/lib/server_prefork.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/source3/lib/server_prefork.c b/source3/lib/server_prefork.c index d3fb8d1a8bc..d0cea7c30c0 100644 --- a/source3/lib/server_prefork.c +++ b/source3/lib/server_prefork.c @@ -84,7 +84,11 @@ bool prefork_create_pool(TALLOC_CTX *mem_ctx, for (i = 0; i < listen_fd_size; i++) { pfp->listen_fds[i] = listen_fds[i]; /* force sockets in non-blocking mode */ - set_blocking(listen_fds[i].fd, false); + ret = set_blocking(listen_fds[i].fd, false); + if (ret < 0) { + DBG_WARNING("Failed to set sockets to non-blocking!\n"); + return false; + } } pfp->main_fn = main_fn; pfp->private_data = private_data; -- 2.47.3