From 5f8443eec9d54e1f74b69aa547e6810da6afa90b Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Tue, 4 Jun 2019 12:07:03 -0700 Subject: [PATCH] bpo-37153: test_venv.test_mutiprocessing() calls pool.terminate() (GH-13816) (GH-13819) test_venv.test_mutiprocessing() now explicitly calls pool.terminate() to wait until the pool completes. (cherry picked from commit bc6469f79ca13217b784fb47da7ec83484a3debe) Co-authored-by: Victor Stinner --- Lib/test/test_venv.py | 6 ++++-- .../next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 Misc/NEWS.d/next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst diff --git a/Lib/test/test_venv.py b/Lib/test/test_venv.py index 19a5aab7a210..a8dc59cb81c3 100644 --- a/Lib/test/test_venv.py +++ b/Lib/test/test_venv.py @@ -312,8 +312,10 @@ class BasicTest(BaseTest): envpy = os.path.join(os.path.realpath(self.env_dir), self.bindir, self.exe) out, err = check_output([envpy, '-c', - 'from multiprocessing import Pool; ' + - 'print(Pool(1).apply_async("Python".lower).get(3))']) + 'from multiprocessing import Pool; ' + 'pool = Pool(1); ' + 'print(pool.apply_async("Python".lower).get(3)); ' + 'pool.terminate()']) self.assertEqual(out.strip(), "python".encode()) @requireVenvCreate diff --git a/Misc/NEWS.d/next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst b/Misc/NEWS.d/next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst new file mode 100644 index 000000000000..138a22f6acc2 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2019-06-04-18-30-39.bpo-37153.711INB.rst @@ -0,0 +1,2 @@ +``test_venv.test_mutiprocessing()`` now explicitly calls +``pool.terminate()`` to wait until the pool completes. -- 2.47.3