From 602fab5ba601db999de21d0da2cb65923802b2c3 Mon Sep 17 00:00:00 2001 From: Eliezer Croitoru Date: Sun, 3 Feb 2013 18:45:19 +1300 Subject: [PATCH] Polish debugging on HelperReply parse --- src/HelperReply.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/HelperReply.cc b/src/HelperReply.cc index 2b416c6d70..847cbf3646 100644 --- a/src/HelperReply.cc +++ b/src/HelperReply.cc @@ -8,6 +8,7 @@ #include "helper.h" #include "rfc1738.h" #include "SquidString.h" +#include "Debug.h" HelperReply::HelperReply(char *buf, size_t len) : result(HelperReply::Unknown), @@ -19,9 +20,11 @@ HelperReply::HelperReply(char *buf, size_t len) : void HelperReply::parse(char *buf, size_t len) { + debugs(84, 3, "Parsing helper buffer"); // check we have something to parse if (!buf || len < 1) { // for now ensure that legacy handlers are not presented with NULL strings. + debugs(84, 3, "Reply length is smaller than 1 or none at all "); other_.init(1,1); other_.terminate(); return; @@ -33,15 +36,19 @@ HelperReply::parse(char *buf, size_t len) // URL-rewriter may return relative URLs or empty response for a large portion // of its replies. if (len >= 2) { + debugs(84, 3, "Buff length is larger than 2"); // some helper formats (digest auth, URL-rewriter) just send a data string // we must also check for the ' ' character after the response token (if anything) if (!strncmp(p,"OK",2) && (len == 2 || p[2] == ' ')) { + debugs(84, 3, "helper Result = OK"); result = HelperReply::Okay; p+=2; } else if (!strncmp(p,"ERR",3) && (len == 3 || p[3] == ' ')) { + debugs(84, 3, "helper Result = ERR"); result = HelperReply::Error; p+=3; } else if (!strncmp(p,"BH",2) && (len == 2 || p[2] == ' ')) { + debugs(84, 3, "helper Result = BH"); result = HelperReply::BrokenHelper; p+=2; } else if (!strncmp(p,"TT ",3)) { -- 2.47.3