From 62464bd2db2a95b1253364f4493bbb6770b73193 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Bj=C3=B6rn=20Jacke?= Date: Fri, 17 Jun 2022 07:26:02 +0200 Subject: [PATCH] vfs_default.c: prefer capabilities over become_root Signed-off-by: Bjoern Jacke Reviewed-by: Christof Schmitt --- source3/modules/vfs_default.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source3/modules/vfs_default.c b/source3/modules/vfs_default.c index d1a19568e4e..3c412f346e1 100644 --- a/source3/modules/vfs_default.c +++ b/source3/modules/vfs_default.c @@ -1891,14 +1891,14 @@ static void vfswrap_get_dos_attributes_getxattr_done(struct tevent_req *subreq) state->as_root = true; - become_root(); + set_effective_capability(DAC_OVERRIDE_CAPABILITY); subreq = SMB_VFS_GETXATTRAT_SEND(state, state->ev, state->dir_fsp, state->smb_fname, SAMBA_XATTR_DOS_ATTRIB, sizeof(fstring)); - unbecome_root(); + drop_effective_capability(DAC_OVERRIDE_CAPABILITY); if (tevent_req_nomem(subreq, req)) { return; } -- 2.47.3