From 646366cc56793d663d98f9ec58a7cecc9734fcd8 Mon Sep 17 00:00:00 2001
From: Stephen Finucane <stephen@that.guru>
Date: Tue, 4 Apr 2017 22:38:19 +0100
Subject: [PATCH] requirements: Test older versions of DRF (v2)

In commit febad055, we attempted to start testing older versions of
Django REST Framework for use with older versions of Django. This work
was later reverted in commit 6f2ddab6 due to issues with 'django-filter'
versions.

There are additional reasons for validating older versions of DRF, such
as supporting the versions provide as part of distributions. It turns
out that those issues aren't such a big deal and can be handled with a
shim. All in all, this means we can and should support these older
versions of Django REST Framework, and that is what we'll do.

Note that the minimum version supported in requirements.txt is not
changed as it's good practice to use the latest available version.
However, that doesn't make it any less supported.

Signed-off-by: Stephen Finucane <stephen@that.guru>
---
 README.rst                | 11 +++++++++++
 patchwork/settings/dev.py |  3 +--
 tox.ini                   |  4 ++++
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/README.rst b/README.rst
index 79c83705..36515737 100644
--- a/README.rst
+++ b/README.rst
@@ -38,6 +38,17 @@ subsystems of the Linux kernel. Although Patchwork has been developed with the
 kernel workflow in mind, the aim is to be flexible enough to suit the majority
 of community projects.
 
+Requirements
+------------
+
+- Python (2.7, 3.3 - 3.5)
+
+- Django (1.6 - 1.10)
+
+- Django REST Framework (3.2 - 3.6)
+
+- Django Filters (0.11 - 1.0)
+
 Development Installation
 ------------------------
 
diff --git a/patchwork/settings/dev.py b/patchwork/settings/dev.py
index ee5b203d..86b0f1b2 100644
--- a/patchwork/settings/dev.py
+++ b/patchwork/settings/dev.py
@@ -92,5 +92,4 @@ if django.VERSION >= (1, 8):
 
 ENABLE_XMLRPC = True
 
-if django.VERSION >= (1, 8):
-    ENABLE_REST_API = True
+ENABLE_REST_API = True
diff --git a/tox.ini b/tox.ini
index f1b892c9..3da222c2 100644
--- a/tox.ini
+++ b/tox.ini
@@ -7,7 +7,11 @@ skipsdist = True
 deps =
     -r{toxinidir}/requirements-test.txt
     django16: django>=1.6,<1.7
+    django16: djangorestframework>=3.2,<3.3
+    django16: django-filter>=0.11,<0.12
     django17: django>=1.7,<1.8
+    django17: djangorestframework>=3.3,<3.4
+    django17: django-filter>=0.11,<0.12
     django18: django>=1.8,<1.9
     django19: django>=1.9,<1.10
     django110: django>=1.10,<1.11
-- 
2.47.3