From 69edfd7b11ab01ca321eaa85a80e5e44e4b2ff02 Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Mon, 30 Oct 2023 14:52:42 +1300 Subject: [PATCH] libcli/security: Make use of sids_contains_sid() Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- libcli/security/util_sid.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c index 8b548199261..1b2ebaf9c55 100644 --- a/libcli/security/util_sid.c +++ b/libcli/security/util_sid.c @@ -383,12 +383,11 @@ NTSTATUS add_sid_to_array(TALLOC_CTX *mem_ctx, const struct dom_sid *sid, NTSTATUS add_sid_to_array_unique(TALLOC_CTX *mem_ctx, const struct dom_sid *sid, struct dom_sid **sids, uint32_t *num_sids) { - uint32_t i; + bool contains; - for (i=0; i<(*num_sids); i++) { - if (dom_sid_equal(sid, &(*sids)[i])) { - return NT_STATUS_OK; - } + contains = sids_contains_sid(*sids, *num_sids, sid); + if (contains) { + return NT_STATUS_OK; } return add_sid_to_array(mem_ctx, sid, sids, num_sids); -- 2.47.3