From 6cdc236f09d1c207a815ad0828474c8dc03eb96f Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Thu, 29 Mar 2007 17:17:41 +0000 Subject: [PATCH] Merged revisions 59357 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r59357 | russell | 2007-03-29 12:14:33 -0500 (Thu, 29 Mar 2007) | 5 lines If an error occurs when reading from an RTP socket, and the error code does not indicate that we should try again, then return NULL instead of a "null frame". This will prevent Asterisk from trying over and over again, and eventually causing the system to crash. (issue #8285, john) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59358 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/rtp.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/main/rtp.c b/main/rtp.c index 42074146a5..35409ed2cf 100644 --- a/main/rtp.c +++ b/main/rtp.c @@ -850,10 +850,12 @@ struct ast_frame *ast_rtcp_read(struct ast_rtp *rtp) rtcpheader = (unsigned int *)(rtcpdata + AST_FRIENDLY_OFFSET); if (res < 0) { - if (errno != EAGAIN) - ast_log(LOG_WARNING, "RTCP Read error: %s\n", strerror(errno)); if (errno == EBADF) CRASH; + if (errno != EAGAIN) { + ast_log(LOG_WARNING, "RTCP Read error: %s. Hanging up.\n", strerror(errno)); + return NULL; + } return &ast_null_frame; } @@ -1105,10 +1107,12 @@ struct ast_frame *ast_rtp_read(struct ast_rtp *rtp) rtpheader = (unsigned int *)(rtp->rawdata + AST_FRIENDLY_OFFSET); if (res < 0) { - if (errno != EAGAIN) - ast_log(LOG_WARNING, "RTP Read error: %s\n", strerror(errno)); if (errno == EBADF) CRASH; + if (errno != EAGAIN) { + ast_log(LOG_WARNING, "RTP Read error: %s. Hanging up.\n", strerror(errno)); + return NULL; + } return &ast_null_frame; } -- 2.47.3