From 6cf3e435658ba50b0e094ca3237af3b96b9165c8 Mon Sep 17 00:00:00 2001 From: Francesco Chemolli Date: Mon, 20 Jul 2015 12:19:04 +0200 Subject: [PATCH] Check return code from setsockopt (CID 1231350) --- src/clients/FtpGateway.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/clients/FtpGateway.cc b/src/clients/FtpGateway.cc index 8b6dbfbdcb..3e44ba1586 100644 --- a/src/clients/FtpGateway.cc +++ b/src/clients/FtpGateway.cc @@ -1802,7 +1802,12 @@ ftpOpenListenSocket(Ftp::Gateway * ftpState, int fallback) */ if (fallback) { int on = 1; - setsockopt(ftpState->ctrl.conn->fd, SOL_SOCKET, SO_REUSEADDR, (char *) &on, sizeof(on)); + errno = 0; + if (setsockopt(ftpState->ctrl.conn->fd, SOL_SOCKET, SO_REUSEADDR, + (char *) &on, sizeof(on)) == -1) { + // SO_REUSEADDR is only an optimization, no need to be verbose about error + debugs(9, 4, "setsockopt failed: " << xstrerror()); + } ftpState->ctrl.conn->flags |= COMM_REUSEADDR; temp->flags |= COMM_REUSEADDR; } else { -- 2.47.3