From 6d67a89a88c14a67f290bfca3d99ba9c84ed45c7 Mon Sep 17 00:00:00 2001 From: Noel Power Date: Thu, 19 Dec 2019 15:55:22 +0000 Subject: [PATCH] selftest/knownfail.d Add samba3.blackbox.smbclient_ntlm.plain (NT1) NT1 flavour of samba3.blackbox.smbclient_ntlm.plain tests will fail against ad_member, maptoguest, fl2000dc & nt4_member (because these envs don't support SMB1) We do however have some coverage with test envs nt4_dc_smb1_done & ad_dc_ntvfs. We could maybe just delete these tests for these environments, creating new envs for such a small amount of strictly SMB1 tests anyway seem overkill. For the moment just create specific knownfail entries associated entries from skip_smb1_fail have also been deleted Signed-off-by: Noel Power Reviewed-by: Ralph Boehme --- selftest/knownfail.d/smb1-tests | 6 ++++++ selftest/skip_smb1_fails | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) create mode 100644 selftest/knownfail.d/smb1-tests diff --git a/selftest/knownfail.d/smb1-tests b/selftest/knownfail.d/smb1-tests new file mode 100644 index 00000000000..a8d8a573687 --- /dev/null +++ b/selftest/knownfail.d/smb1-tests @@ -0,0 +1,6 @@ +^samba3.blackbox.smbclient_ntlm.plain.*NT1.smbclient anonymous.badpassword.NT1NEW.guest\(maptoguest\) +^samba3.blackbox.smbclient_ntlm.plain.*NT1.smbclient baduser.badpassword.NT1NEW.guest\(maptoguest\) +^samba3.blackbox.smbclient_ntlm.plain.*NT1.smbclient username.password.NT1OLD\((ad_member|fl2000dc|maptoguest|nt4_member)\) +^samba3.blackbox.smbclient_ntlm.plain.*NT1.smbclient username.password.NT1NEW\((ad_member|fl2000dc|maptoguest|nt4_member)\) +^samba3.blackbox.smbclient_ntlm.plain.*NT1.smbclient anonymous.nopassword.NT1OLD\((ad_member|fl2000dc|maptoguest|nt4_member)\) +^samba3.blackbox.smbclient_ntlm.plain.*NT1.smbclient anonymous.nopassword.NT1NEW\((ad_member|fl2000dc|maptoguest|nt4_member)\) diff --git a/selftest/skip_smb1_fails b/selftest/skip_smb1_fails index 532ab7e7aa5..7a983df7a7b 100644 --- a/selftest/skip_smb1_fails +++ b/selftest/skip_smb1_fails @@ -11,10 +11,6 @@ ^samba3.blackbox.smbclient_auth.plain.--option=clientusespnego=no --option=clientntlmv2auth=no -mNT1.member_creds\(nt4_member\) ^samba3.blackbox.smbclient_auth.plain.--option=clientusespnego=no --option=clientntlmv2auth=no -mNT1\(nt4_member\) ^samba3.blackbox.smbclient_basic.NT1\(nt4_dc_schannel\) -^samba3.blackbox.smbclient_ntlm.plain NT1\(ad_member\) -^samba3.blackbox.smbclient_ntlm.plain NT1\(fl2000dc\) -^samba3.blackbox.smbclient_ntlm.plain.NT1\(maptoguest\) -^samba3.blackbox.smbclient_ntlm.plain NT1\(nt4_member\) ^samba3.blackbox.smbclient_s3.NT1.plain.member_creds\(ad_member\) ^samba3.blackbox.smbclient_s3.NT1.plain.member_creds\(nt4_member\) ^samba3.blackbox.smbclient_s3.NT1.sign.member_creds\(ad_member\) -- 2.47.3