From 73c731779986ab2971d3b15a9cc1a77c22bbacaf Mon Sep 17 00:00:00 2001 From: Joshua Rogers Date: Wed, 10 Sep 2025 03:48:22 +0000 Subject: [PATCH] Do not leak file handle on _open_osfhandle() xaccept() failure (#2231) --- compat/socket.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/compat/socket.cc b/compat/socket.cc index 5fac7c2244..fd3c5c4f3f 100644 --- a/compat/socket.cc +++ b/compat/socket.cc @@ -34,8 +34,10 @@ xaccept(int socketFd, struct sockaddr *sa, socklen_t *saLength) return SOCKET_ERROR; } const auto rv = _open_osfhandle(result, 0); - if (rv == -1) + if (rv == -1) { + closesocket(result); errno = EBADF; + } if (saLength) *saLength = static_cast(al); return rv; -- 2.47.3