From 752cb6ef816c8b2b37e38e418bd11698c00027e4 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Ren=C3=A9=20Scharfe?= Date: Sun, 3 Mar 2024 11:13:26 +0100 Subject: [PATCH] t-ctype: simplify EOF check MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit EOF is not a member of any character class. If a classifier function returns a non-zero result for it, presumably by mistake, then the unit test check reports: # check "!iseof(EOF)" failed at t/unit-tests/t-ctype.c:53 # i: 0xffffffff (EOF) The numeric value of EOF is not particularly interesting in this context. Stop printing the second line. Signed-off-by: René Scharfe Signed-off-by: Junio C Hamano --- t/unit-tests/t-ctype.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/t/unit-tests/t-ctype.c b/t/unit-tests/t-ctype.c index 35473c41d8..f0d61d6eb2 100644 --- a/t/unit-tests/t-ctype.c +++ b/t/unit-tests/t-ctype.c @@ -10,8 +10,7 @@ static void test_ctype_##func(void) { \ if (!check_int(func(i), ==, !!memchr(string, i, len))) \ test_msg(" i: 0x%02x", i); \ } \ - if (!check(!func(EOF))) \ - test_msg(" i: 0x%02x (EOF)", EOF); \ + check(!func(EOF)); \ } #define TEST_CHAR_CLASS(class) TEST(test_ctype_##class(), #class " works") -- 2.47.3